Re: [Qemu-devel] [PATCH v4 2/5] change pvscsi_init_msi() type to void

[Marcel Apfelbaum <marcel@redhat.com>]

On 04/05/2016 02:26 PM, Cao jin wrote:
> Nobody use its return value, so change the type to void
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Dmitry Fleytman <dmitry@daynix.com>
> ---
>   hw/scsi/vmw_pvscsi.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
> index 9abc086..4ce3581 100644
> --- a/hw/scsi/vmw_pvscsi.c
> +++ b/hw/scsi/vmw_pvscsi.c
> @@ -1039,7 +1039,7 @@ pvscsi_io_read(void *opaque, hwaddr addr, unsigned size)
>   }
>
>
> -static bool
> +static void
>   pvscsi_init_msi(PVSCSIState *s)
>   {
>       int res;
> @@ -1053,8 +1053,6 @@ pvscsi_init_msi(PVSCSIState *s)
>       } else {
>           s->msi_used = true;
>       }
> -
> -    return s->msi_used;
>   }
>
>   static void
>


Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>

Thanks,
Marcel