From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Marcel Apfelbaum <marcel@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com, jasowang@redhat.com,
alex.williamson@redhat.com, hare@suse.de, dmitry@daynix.com,
pbonzini@redhat.com, jsnow@redhat.com, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 5/5] Add param Error ** for msi_init()
Date: Mon, 11 Apr 2016 20:02:25 +0800 [thread overview]
Message-ID: <570B9251.5040403@cn.fujitsu.com> (raw)
In-Reply-To: <570B75BA.3050800@redhat.com>
On 04/11/2016 06:00 PM, Marcel Apfelbaum wrote:
>
>> 2). If user doesn`t order msi on(so device have msi on by default),
>> when msi_init returns -ENOTSUP, I am ok with Markus`s suggestion:
>> *caller should silently switch to the non-MSI variant*
>>
>> But now the condition is, qemu can`t distinguish whether user ordered
>> msi or not, so for the condition 2) above, my suggestion is the same
>> as 1)
>>
>
> If we can't distinguish between the cases, 2 would not be user-friendly.
> Once it would be possible to differentiate we could go for 2.
>
Hi,
How to differentiate? Do you mean: let these msi(msix) property default
to 'off'? It seem most device have it on, a few have it off.
>
> Thanks,
> Marcel
>
--
Yours Sincerely,
Cao jin
next prev parent reply other threads:[~2016-04-11 11:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 11:26 [Qemu-devel] [PATCH v4 0/5] Add param Error ** for msi_init() Cao jin
2016-04-05 11:26 ` [Qemu-devel] [PATCH v4 1/5] fix some coding style problems Cao jin
2016-04-08 6:29 ` Markus Armbruster
2016-04-09 8:49 ` Cao jin
2016-04-05 11:26 ` [Qemu-devel] [PATCH v4 2/5] change pvscsi_init_msi() type to void Cao jin
2016-04-06 7:19 ` Dmitry Fleytman
2016-04-10 7:41 ` Marcel Apfelbaum
2016-04-05 11:26 ` [Qemu-devel] [PATCH v4 3/5] megasas: bugfix Cao jin
2016-04-08 7:16 ` Markus Armbruster
2016-04-09 13:07 ` Cao jin
2016-04-10 7:40 ` Marcel Apfelbaum
2016-04-05 11:26 ` [Qemu-devel] [PATCH v4 4/5] mptsas: change .realize function name Cao jin
2016-04-10 7:43 ` Marcel Apfelbaum
2016-04-05 11:26 ` [Qemu-devel] [PATCH v4 5/5] Add param Error ** for msi_init() Cao jin
2016-04-08 8:44 ` Markus Armbruster
2016-04-09 12:19 ` Cao jin
2016-04-09 13:00 ` Cao jin
2016-04-10 8:20 ` Marcel Apfelbaum
2016-04-10 9:38 ` Cao jin
2016-04-11 10:00 ` Marcel Apfelbaum
2016-04-11 12:02 ` Cao jin [this message]
2016-04-12 11:50 ` Markus Armbruster
2016-04-29 9:28 ` Cao jin
2016-04-29 12:46 ` Markus Armbruster
2016-04-12 8:34 ` Markus Armbruster
2016-04-05 11:27 ` [Qemu-devel] [PATCH v4 0/5] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570B9251.5040403@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=dmitry@daynix.com \
--cc=hare@suse.de \
--cc=jasowang@redhat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.