From: wangkefeng.wang@huawei.com (Kefeng Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] irqchip/mbigen: Display message of MBIGEN domain created
Date: Mon, 11 Apr 2016 09:04:29 +0800 [thread overview]
Message-ID: <570AF81D.90302@huawei.com> (raw)
In-Reply-To: <57078BE8.8040604@arm.com>
On 2016/4/8 18:46, Marc Zyngier wrote:
> On 08/04/16 11:33, Kefeng Wang wrote:
>>
>>
>> On 2016/4/8 16:53, Marc Zyngier wrote:
>>> On Fri, 8 Apr 2016 16:26:21 +0800
>>> Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>>
[...]
>> But there is still one issue in the for_each_child_of_node loop of
>> mbigen_device_probe. Assume that there are 3+ child node(mbigen_gmac,
>> mbigen_i2c, mbigen_xxx, etc) in mbigen_chip_dsa, if one of them with
>> incorrect configuration, then the loop will end, but we still need
>> parse the left child node. we should consider this situation, right?
>
> That's up to whoever designed the driver to decide, really. I don't know
> if it is worth continuing in that case (and you are in a better position
> than me to find out).
Ok, will talk with Ma Jun directly, and if the change is needed, I will send
a new patch after reviewed by Ma Jun.
Thanks,
Kefeng
WARNING: multiple messages have this Message-ID (diff)
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Jason Cooper <jason@lakedaemon.net>, <majun258@huawei.com>,
<guohanjun@huawei.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] irqchip/mbigen: Display message of MBIGEN domain created
Date: Mon, 11 Apr 2016 09:04:29 +0800 [thread overview]
Message-ID: <570AF81D.90302@huawei.com> (raw)
In-Reply-To: <57078BE8.8040604@arm.com>
On 2016/4/8 18:46, Marc Zyngier wrote:
> On 08/04/16 11:33, Kefeng Wang wrote:
>>
>>
>> On 2016/4/8 16:53, Marc Zyngier wrote:
>>> On Fri, 8 Apr 2016 16:26:21 +0800
>>> Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>>
[...]
>> But there is still one issue in the for_each_child_of_node loop of
>> mbigen_device_probe. Assume that there are 3+ child node(mbigen_gmac,
>> mbigen_i2c, mbigen_xxx, etc) in mbigen_chip_dsa, if one of them with
>> incorrect configuration, then the loop will end, but we still need
>> parse the left child node. we should consider this situation, right?
>
> That's up to whoever designed the driver to decide, really. I don't know
> if it is worth continuing in that case (and you are in a better position
> than me to find out).
Ok, will talk with Ma Jun directly, and if the change is needed, I will send
a new patch after reviewed by Ma Jun.
Thanks,
Kefeng
next prev parent reply other threads:[~2016-04-11 1:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 7:16 [PATCH] irqchip/mbigen: Display message of MBIGEN domain created Kefeng Wang
2016-04-08 7:16 ` Kefeng Wang
2016-04-08 8:09 ` Marc Zyngier
2016-04-08 8:09 ` Marc Zyngier
2016-04-08 8:26 ` Kefeng Wang
2016-04-08 8:26 ` Kefeng Wang
2016-04-08 8:53 ` Marc Zyngier
2016-04-08 8:53 ` Marc Zyngier
2016-04-08 10:33 ` Kefeng Wang
2016-04-08 10:33 ` Kefeng Wang
2016-04-08 10:46 ` Marc Zyngier
2016-04-08 10:46 ` Marc Zyngier
2016-04-11 1:04 ` Kefeng Wang [this message]
2016-04-11 1:04 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570AF81D.90302@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.