From: Vlastimil Babka <vbabka@suse.cz>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mel Gorman <mgorman@techsingularity.net>,
Rik van Riel <riel@redhat.com>,
David Rientjes <rientjes@google.com>,
Minchan Kim <minchan@kernel.org>, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v2 4/4] mm, compaction: direct freepage allocation for async direct compaction
Date: Mon, 11 Apr 2016 09:27:02 +0200 [thread overview]
Message-ID: <570B51C6.4050005@suse.cz> (raw)
In-Reply-To: <20160411071351.GB26116@js1304-P5Q-DELUXE>
On 04/11/2016 09:13 AM, Joonsoo Kim wrote:
> On Thu, Mar 31, 2016 at 10:50:36AM +0200, Vlastimil Babka wrote:
>> The goal of direct compaction is to quickly make a high-order page available
>> for the pending allocation. The free page scanner can add significant latency
>> when searching for migration targets, although to succeed the compaction, the
>> only important limit on the target free pages is that they must not come from
>> the same order-aligned block as the migrated pages.
>
> If we fails migration, free pages will remain and they can interfere
> further compaction success because they doesn't come from previous
> order-aligned block but can come from next order-aligned block. You
> need to free remaining freelist after migration attempt fails?
Oh, good point, thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Mel Gorman <mgorman@techsingularity.net>,
Rik van Riel <riel@redhat.com>,
David Rientjes <rientjes@google.com>,
Minchan Kim <minchan@kernel.org>, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v2 4/4] mm, compaction: direct freepage allocation for async direct compaction
Date: Mon, 11 Apr 2016 09:27:02 +0200 [thread overview]
Message-ID: <570B51C6.4050005@suse.cz> (raw)
In-Reply-To: <20160411071351.GB26116@js1304-P5Q-DELUXE>
On 04/11/2016 09:13 AM, Joonsoo Kim wrote:
> On Thu, Mar 31, 2016 at 10:50:36AM +0200, Vlastimil Babka wrote:
>> The goal of direct compaction is to quickly make a high-order page available
>> for the pending allocation. The free page scanner can add significant latency
>> when searching for migration targets, although to succeed the compaction, the
>> only important limit on the target free pages is that they must not come from
>> the same order-aligned block as the migrated pages.
>
> If we fails migration, free pages will remain and they can interfere
> further compaction success because they doesn't come from previous
> order-aligned block but can come from next order-aligned block. You
> need to free remaining freelist after migration attempt fails?
Oh, good point, thanks!
next prev parent reply other threads:[~2016-04-11 7:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 8:50 [PATCH v2 0/4] reduce latency of direct async compaction Vlastimil Babka
2016-03-31 8:50 ` Vlastimil Babka
2016-03-31 8:50 ` [PATCH v2 1/4] mm, compaction: wrap calculating first and last pfn of pageblock Vlastimil Babka
2016-03-31 8:50 ` Vlastimil Babka
2016-03-31 8:50 ` [PATCH v2 2/4] mm, compaction: reduce spurious pcplist drains Vlastimil Babka
2016-03-31 8:50 ` Vlastimil Babka
2016-03-31 8:50 ` [PATCH v2 3/4] mm, compaction: skip blocks where isolation fails in async direct compaction Vlastimil Babka
2016-03-31 8:50 ` Vlastimil Babka
2016-03-31 8:50 ` [PATCH v2 4/4] mm, compaction: direct freepage allocation for " Vlastimil Babka
2016-03-31 8:50 ` Vlastimil Babka
2016-04-04 9:31 ` Mel Gorman
2016-04-04 9:31 ` Mel Gorman
2016-04-04 11:05 ` Vlastimil Babka
2016-04-04 11:05 ` Vlastimil Babka
2016-04-11 7:13 ` Joonsoo Kim
2016-04-11 7:13 ` Joonsoo Kim
2016-04-11 7:27 ` Vlastimil Babka [this message]
2016-04-11 7:27 ` Vlastimil Babka
2016-04-11 7:05 ` [PATCH v2 0/4] reduce latency of direct async compaction Joonsoo Kim
2016-04-11 7:05 ` Joonsoo Kim
2016-04-11 8:17 ` Vlastimil Babka
2016-04-11 8:17 ` Vlastimil Babka
2016-04-12 4:49 ` Joonsoo Kim
2016-04-12 4:49 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570B51C6.4050005@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.