All of lore.kernel.org
 help / color / mirror / Atom feed
From: acourbot@nvidia.com (Alexandre Courbot)
To: linux-arm-kernel@lists.infradead.org
Subject: Nouveau crashes in 4.6-rc on arm64
Date: Mon, 11 Apr 2016 16:55:38 +0900	[thread overview]
Message-ID: <570B587A.5090509@nvidia.com> (raw)
In-Reply-To: <570B50B4.4020304@nvidia.com>

On 04/11/2016 04:22 PM, Alexandre Courbot wrote:
> ... or maybe we could just unconditionally sync all buffers and let the
> DMA API abstract this away. My concern is that on coherent architectures
> we would still need to loop over all the pages for nothing, as I don't
> think the loop (see e.g. nouveau_bo_sync_for_cpu in nouveau_bo.c) can be
> optimized away by the compiler.

Looking at the code it actually turns out we are already calling the 
sync functions on coherent buses anyway, so maybe we have little reasons 
to keep this at all?

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Courbot <acourbot@nvidia.com>
To: Robin Murphy <robin.murphy@arm.com>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: bskeggs@redhat.com
Subject: Re: Nouveau crashes in 4.6-rc on arm64
Date: Mon, 11 Apr 2016 16:55:38 +0900	[thread overview]
Message-ID: <570B587A.5090509@nvidia.com> (raw)
In-Reply-To: <570B50B4.4020304@nvidia.com>

On 04/11/2016 04:22 PM, Alexandre Courbot wrote:
> ... or maybe we could just unconditionally sync all buffers and let the
> DMA API abstract this away. My concern is that on coherent architectures
> we would still need to loop over all the pages for nothing, as I don't
> think the loop (see e.g. nouveau_bo_sync_for_cpu in nouveau_bo.c) can be
> optimized away by the compiler.

Looking at the code it actually turns out we are already calling the 
sync functions on coherent buses anyway, so maybe we have little reasons 
to keep this at all?
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Courbot <acourbot@nvidia.com>
To: Robin Murphy <robin.murphy@arm.com>,
	<dri-devel@lists.freedesktop.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Cc: <bskeggs@redhat.com>
Subject: Re: Nouveau crashes in 4.6-rc on arm64
Date: Mon, 11 Apr 2016 16:55:38 +0900	[thread overview]
Message-ID: <570B587A.5090509@nvidia.com> (raw)
In-Reply-To: <570B50B4.4020304@nvidia.com>

On 04/11/2016 04:22 PM, Alexandre Courbot wrote:
> ... or maybe we could just unconditionally sync all buffers and let the
> DMA API abstract this away. My concern is that on coherent architectures
> we would still need to loop over all the pages for nothing, as I don't
> think the loop (see e.g. nouveau_bo_sync_for_cpu in nouveau_bo.c) can be
> optimized away by the compiler.

Looking at the code it actually turns out we are already calling the 
sync functions on coherent buses anyway, so maybe we have little reasons 
to keep this at all?

  reply	other threads:[~2016-04-11  7:55 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07 11:50 Nouveau crashes in 4.6-rc on arm64 Robin Murphy
2016-04-07 11:50 ` Robin Murphy
2016-04-08  4:47 ` Alexandre Courbot
2016-04-08  4:47   ` Alexandre Courbot
2016-04-08  4:47   ` Alexandre Courbot
2016-04-08  6:27   ` Ilia Mirkin
2016-04-08  6:27     ` Ilia Mirkin
2016-04-08  6:27     ` Ilia Mirkin
2016-04-08 18:46   ` Robin Murphy
2016-04-08 18:46     ` Robin Murphy
2016-04-08 18:46     ` Robin Murphy
2016-04-11  7:22     ` Alexandre Courbot
2016-04-11  7:22       ` Alexandre Courbot
2016-04-11  7:22       ` Alexandre Courbot
2016-04-11  7:55       ` Alexandre Courbot [this message]
2016-04-11  7:55         ` Alexandre Courbot
2016-04-11  7:55         ` Alexandre Courbot
2016-04-20  4:35       ` Alexandre Courbot
2016-04-20  4:35         ` Alexandre Courbot
2016-04-20  4:35         ` Alexandre Courbot
2016-04-20 10:44         ` Robin Murphy
2016-04-20 10:44           ` Robin Murphy
2016-04-20 10:44           ` Robin Murphy
2016-04-20 10:51           ` Robin Murphy
2016-04-20 10:51             ` Robin Murphy
2016-04-20 10:51             ` Robin Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570B587A.5090509@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.