Re: [meta-oe][PATCH] hwdata: add new recipe

[Gary Thomas <gary@mlbassoc.com>]

On 2016-04-11 10:34, Dai Caiyun wrote:
> Signed-off-by: Dai Caiyun <daicy.fnst@cn.fujitsu.com>
> ---
>   meta-oe/recipes-support/hwdata/hwdata_0.284.bb | 67 ++++++++++++++++++++++++++
>   1 file changed, 67 insertions(+)
>   create mode 100644 meta-oe/recipes-support/hwdata/hwdata_0.284.bb
>
> diff --git a/meta-oe/recipes-support/hwdata/hwdata_0.284.bb b/meta-oe/recipes-support/hwdata/hwdata_0.284.bb
> new file mode 100644
> index 0000000..91013b6
> --- /dev/null
> +++ b/meta-oe/recipes-support/hwdata/hwdata_0.284.bb
> @@ -0,0 +1,67 @@
> +DESCRIPTION = "Hardware identification and configuration data"
> +HOMEPAGE = "http://git.fedorahosted.org/git/hwdata.git"
> +SECTION = "System/Base"
> +
> +LICENSE = "GPL-2.0+"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=1556547711e8246992b999edd9445a57"
> +SRC_URI = "https://git.fedorahosted.org/cgit/hwdata.git/snapshot/${PN}-${PV}.tar.gz"
> +
> +SRC_URI[md5sum] = "30ba61f058d2c2295fd6b3ab575eb5ce"
> +SRC_URI[sha256sum] = "bf08c8e6200467669ffc5919141f7a47cc70756c97b819427e60b6c1a0cdcfa6"
> +
> +inherit autotools-brokensep
> +
> +#PROVIDES by hwdata
> +#the PROVIDES rules is ignore "pciutils-ids"
> +
> +PROVIDES += "pciutils-ids"
> +
> +#PROVIDES by hwdata-ivi
> +PROVIDES += "hwdata-ivi"
> +
> +do_prep() {
> +    cd ${S}
> +    chmod -Rf a+rX,u+w,g-w,o-w ${S}

What's the point of changing permissions like this?

> +}
> +
> +do_patch_append() {
> +    bb.build.exec_func('do_prep',d)
> +}
> +
> +do_compile() {
> +    cd ${S}
> +    LANG=C
> +    export LANG
> +    unset DISPLAY
> +    LD_AS_NEEDED=1; export LD_AS_NEEDED ;
> +    autotools_do_configure

Why isn't this done in do_configure()?

> +}
> +
> +do_install() {
> +    export RPM_BUILD_ROOT=${D}

What's the point of setting RPM_BUILD_ROOT?  That seems like Fedora creep...

> +    cd ${S}
> +    LANG=C
> +    export LANG
> +    unset DISPLAY
> +    rm -rf ${D}
> +    mkdir -p ${D}
> +
> +    oe_runmake \
> +        DESTDIR=${D} \
> +        INSTALL_ROOT=${D} \
> +        BINDIR=${prefix}/bin \
> +        install

The lines below are incorrectly indented
> +        rm -f ${D}${infodir}/dir
> +        find ${D} -regex ".*\.la$" | xargs rm -f --
> +        find ${D} -regex ".*\.a$" | xargs rm -f --
> +        mkdir -p ${D}${sysconfdir}/modprobe.d
> +        mv ${D}${prefix}/lib/modprobe.d/dist-blacklist.conf \
> +        ${D}${sysconfdir}/modprobe.d/blacklist.conf
> +        rm -rf ${D}${prefix}/lib
> +        install -m644 blacklist.conf ${D}/${sysconfdir}/modprobe.d
... until here

> +}
> +
> +RDEPENDS_${PN}-ivi += "hwdata"
> +INSANE_SKIP_${PN}-ivi += "build-deps"
> +
> +PACKAGES = "${PN} ${PN}-dbg ${PN}-doc ${PN}-locale ${PN}-ivi"
>


-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------