[meta-oe][PATCH] hwdata: add new recipe

[meta-oe][PATCH] hwdata: add new recipe

[Dai Caiyun]

Signed-off-by: Dai Caiyun <daicy.fnst@cn.fujitsu.com>
---
 meta-oe/recipes-support/hwdata/hwdata_0.284.bb | 75 ++++++++++++++++++++++++++
 1 file changed, 75 insertions(+)
 create mode 100644 meta-oe/recipes-support/hwdata/hwdata_0.284.bb

diff --git a/meta-oe/recipes-support/hwdata/hwdata_0.284.bb b/meta-oe/recipes-support/hwdata/hwdata_0.284.bb
new file mode 100644
index 0000000..342f1a1
--- /dev/null
+++ b/meta-oe/recipes-support/hwdata/hwdata_0.284.bb
@@ -0,0 +1,75 @@
+DESCRIPTION = "Hardware identification and configuration data"
+HOMEPAGE = "http://git.fedorahosted.org/git/hwdata.git"
+SECTION = "System/Base"
+
+LICENSE = "GPL-2.0+"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=1556547711e8246992b999edd9445a57"
+
+SRC_URI = "https://git.fedorahosted.org/cgit/hwdata.git/snapshot/${PN}-${PV}.tar.gz"
+
+SRC_URI[md5sum] = "30ba61f058d2c2295fd6b3ab575eb5ce"
+SRC_URI[sha256sum] = "bf08c8e6200467669ffc5919141f7a47cc70756c97b819427e60b6c1a0cdcfa6"
+
+inherit autotools-brokensep
+
+#PROVIDES by hwdata
+# the PROVIDES rules is ignore "pciutils-ids  "
+PROVIDES += "pciutils-ids"
+RPROVIDES_hwdata += "pciutils-ids"
+
+
+#PROVIDES by hwdata-ivi
+PROVIDES += "hwdata-ivi"
+
+#RDEPENDS of hwdata-ivi (${PN}-ivi)
+RDEPENDS_${PN}-ivi += "hwdata"
+
+do_prep() {
+    cd ${S}
+    chmod -Rf a+rX,u+w,g-w,o-w ${S}
+}
+
+do_patch_append() {
+    bb.build.exec_func('do_prep', d)
+}
+
+do_configure() {
+}
+
+do_compile() {
+    cd ${S}
+    LANG=C
+    export LANG
+    unset DISPLAY
+    LD_AS_NEEDED=1; export LD_AS_NEEDED ;
+	
+    autotools_do_configure
+}
+
+do_install() {
+    export RPM_BUILD_ROOT=${D}
+    cd ${S}
+    LANG=C
+    export LANG
+    unset DISPLAY
+    rm -rf ${D}
+    mkdir -p ${D}
+
+    oe_runmake \
+        DESTDIR=${D} \
+        INSTALL_ROOT=${D} \
+        BINDIR=${prefix}/bin \
+        install
+        rm -f ${D}${infodir}/dir
+        find ${D} -regex ".*\.la$" | xargs rm -f --
+        find ${D} -regex ".*\.a$" | xargs rm -f --
+        mkdir -p ${D}${sysconfdir}/modprobe.d
+        mv ${D}${prefix}/lib/modprobe.d/dist-blacklist.conf \
+        ${D}${sysconfdir}/modprobe.d/blacklist.conf
+        rm -rf ${D}${prefix}/lib
+        install -m644 blacklist.conf ${D}/${sysconfdir}/modprobe.d
+}
+
+PACKAGES = "${PN}-dbg ${PN}-doc ${PN}-locale"
+PACKAGES += " hwdata "
+
-- 
1.9.1

Re: [meta-oe][PATCH] hwdata: add new recipe

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3195 bytes --]

On Fri, Jan 15, 2016 at 02:08:49AM -0800, Dai Caiyun wrote:
> Signed-off-by: Dai Caiyun <daicy.fnst@cn.fujitsu.com>
> ---
>  meta-oe/recipes-support/hwdata/hwdata_0.284.bb | 75 ++++++++++++++++++++++++++
>  1 file changed, 75 insertions(+)
>  create mode 100644 meta-oe/recipes-support/hwdata/hwdata_0.284.bb
> 
> diff --git a/meta-oe/recipes-support/hwdata/hwdata_0.284.bb b/meta-oe/recipes-support/hwdata/hwdata_0.284.bb
> new file mode 100644
> index 0000000..342f1a1
> --- /dev/null
> +++ b/meta-oe/recipes-support/hwdata/hwdata_0.284.bb
> @@ -0,0 +1,75 @@
> +DESCRIPTION = "Hardware identification and configuration data"
> +HOMEPAGE = "http://git.fedorahosted.org/git/hwdata.git"
> +SECTION = "System/Base"
> +
> +LICENSE = "GPL-2.0+"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=1556547711e8246992b999edd9445a57"
> +
> +SRC_URI = "https://git.fedorahosted.org/cgit/hwdata.git/snapshot/${PN}-${PV}.tar.gz"
> +
> +SRC_URI[md5sum] = "30ba61f058d2c2295fd6b3ab575eb5ce"
> +SRC_URI[sha256sum] = "bf08c8e6200467669ffc5919141f7a47cc70756c97b819427e60b6c1a0cdcfa6"
> +
> +inherit autotools-brokensep
> +
> +#PROVIDES by hwdata
> +# the PROVIDES rules is ignore "pciutils-ids  "
> +PROVIDES += "pciutils-ids"
> +RPROVIDES_hwdata += "pciutils-ids"

Causes multiple providers:

NOTE: multiple providers are available for runtime pciutils-ids (hwdata, pciutils)
NOTE: consider defining a PREFERRED_PROVIDER entry to match pciutils-ids


> +
> +
> +#PROVIDES by hwdata-ivi
> +PROVIDES += "hwdata-ivi"
> +
> +#RDEPENDS of hwdata-ivi (${PN}-ivi)
> +RDEPENDS_${PN}-ivi += "hwdata"
> +
> +do_prep() {
> +    cd ${S}
> +    chmod -Rf a+rX,u+w,g-w,o-w ${S}
> +}
> +
> +do_patch_append() {
> +    bb.build.exec_func('do_prep', d)
> +}
> +
> +do_configure() {
> +}
> +
> +do_compile() {
> +    cd ${S}
> +    LANG=C
> +    export LANG
> +    unset DISPLAY
> +    LD_AS_NEEDED=1; export LD_AS_NEEDED ;
> +	
> +    autotools_do_configure
> +}
> +
> +do_install() {
> +    export RPM_BUILD_ROOT=${D}
> +    cd ${S}
> +    LANG=C
> +    export LANG
> +    unset DISPLAY
> +    rm -rf ${D}
> +    mkdir -p ${D}
> +
> +    oe_runmake \
> +        DESTDIR=${D} \
> +        INSTALL_ROOT=${D} \
> +        BINDIR=${prefix}/bin \
> +        install
> +        rm -f ${D}${infodir}/dir
> +        find ${D} -regex ".*\.la$" | xargs rm -f --
> +        find ${D} -regex ".*\.a$" | xargs rm -f --
> +        mkdir -p ${D}${sysconfdir}/modprobe.d
> +        mv ${D}${prefix}/lib/modprobe.d/dist-blacklist.conf \
> +        ${D}${sysconfdir}/modprobe.d/blacklist.conf
> +        rm -rf ${D}${prefix}/lib
> +        install -m644 blacklist.conf ${D}/${sysconfdir}/modprobe.d
> +}
> +
> +PACKAGES = "${PN}-dbg ${PN}-doc ${PN}-locale"
> +PACKAGES += " hwdata "

Don't redefine PACKAGES, what are you trying to achieve with this?

> +
> -- 
> 1.9.1
> 
> 
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

[meta-oe][PATCH] hwdata: add new recipe

[Dai Caiyun]

Signed-off-by: Dai Caiyun <daicy.fnst@cn.fujitsu.com>
---
 meta-oe/recipes-support/hwdata/hwdata_0.284.bb | 67 ++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)
 create mode 100644 meta-oe/recipes-support/hwdata/hwdata_0.284.bb

diff --git a/meta-oe/recipes-support/hwdata/hwdata_0.284.bb b/meta-oe/recipes-support/hwdata/hwdata_0.284.bb
new file mode 100644
index 0000000..91013b6
--- /dev/null
+++ b/meta-oe/recipes-support/hwdata/hwdata_0.284.bb
@@ -0,0 +1,67 @@
+DESCRIPTION = "Hardware identification and configuration data"
+HOMEPAGE = "http://git.fedorahosted.org/git/hwdata.git"
+SECTION = "System/Base"
+
+LICENSE = "GPL-2.0+"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=1556547711e8246992b999edd9445a57"
+SRC_URI = "https://git.fedorahosted.org/cgit/hwdata.git/snapshot/${PN}-${PV}.tar.gz"
+
+SRC_URI[md5sum] = "30ba61f058d2c2295fd6b3ab575eb5ce"
+SRC_URI[sha256sum] = "bf08c8e6200467669ffc5919141f7a47cc70756c97b819427e60b6c1a0cdcfa6"
+
+inherit autotools-brokensep
+
+#PROVIDES by hwdata
+#the PROVIDES rules is ignore "pciutils-ids"
+
+PROVIDES += "pciutils-ids"
+
+#PROVIDES by hwdata-ivi
+PROVIDES += "hwdata-ivi"
+
+do_prep() {
+    cd ${S}
+    chmod -Rf a+rX,u+w,g-w,o-w ${S}
+}
+
+do_patch_append() {
+    bb.build.exec_func('do_prep',d)
+}
+
+do_compile() {
+    cd ${S}
+    LANG=C
+    export LANG
+    unset DISPLAY
+    LD_AS_NEEDED=1; export LD_AS_NEEDED ;
+    autotools_do_configure
+}
+
+do_install() {
+    export RPM_BUILD_ROOT=${D}
+    cd ${S}
+    LANG=C
+    export LANG
+    unset DISPLAY
+    rm -rf ${D}
+    mkdir -p ${D}
+
+    oe_runmake \
+        DESTDIR=${D} \
+        INSTALL_ROOT=${D} \
+        BINDIR=${prefix}/bin \
+        install
+        rm -f ${D}${infodir}/dir
+        find ${D} -regex ".*\.la$" | xargs rm -f --
+        find ${D} -regex ".*\.a$" | xargs rm -f --
+        mkdir -p ${D}${sysconfdir}/modprobe.d
+        mv ${D}${prefix}/lib/modprobe.d/dist-blacklist.conf \
+        ${D}${sysconfdir}/modprobe.d/blacklist.conf
+        rm -rf ${D}${prefix}/lib
+        install -m644 blacklist.conf ${D}/${sysconfdir}/modprobe.d
+}
+
+RDEPENDS_${PN}-ivi += "hwdata"
+INSANE_SKIP_${PN}-ivi += "build-deps"
+
+PACKAGES = "${PN} ${PN}-dbg ${PN}-doc ${PN}-locale ${PN}-ivi"
-- 
1.9.1

Re: [meta-oe][PATCH] hwdata: add new recipe

[Gary Thomas]

On 2016-04-11 10:34, Dai Caiyun wrote:
> Signed-off-by: Dai Caiyun <daicy.fnst@cn.fujitsu.com>
> ---
>   meta-oe/recipes-support/hwdata/hwdata_0.284.bb | 67 ++++++++++++++++++++++++++
>   1 file changed, 67 insertions(+)
>   create mode 100644 meta-oe/recipes-support/hwdata/hwdata_0.284.bb
>
> diff --git a/meta-oe/recipes-support/hwdata/hwdata_0.284.bb b/meta-oe/recipes-support/hwdata/hwdata_0.284.bb
> new file mode 100644
> index 0000000..91013b6
> --- /dev/null
> +++ b/meta-oe/recipes-support/hwdata/hwdata_0.284.bb
> @@ -0,0 +1,67 @@
> +DESCRIPTION = "Hardware identification and configuration data"
> +HOMEPAGE = "http://git.fedorahosted.org/git/hwdata.git"
> +SECTION = "System/Base"
> +
> +LICENSE = "GPL-2.0+"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=1556547711e8246992b999edd9445a57"
> +SRC_URI = "https://git.fedorahosted.org/cgit/hwdata.git/snapshot/${PN}-${PV}.tar.gz"
> +
> +SRC_URI[md5sum] = "30ba61f058d2c2295fd6b3ab575eb5ce"
> +SRC_URI[sha256sum] = "bf08c8e6200467669ffc5919141f7a47cc70756c97b819427e60b6c1a0cdcfa6"
> +
> +inherit autotools-brokensep
> +
> +#PROVIDES by hwdata
> +#the PROVIDES rules is ignore "pciutils-ids"
> +
> +PROVIDES += "pciutils-ids"
> +
> +#PROVIDES by hwdata-ivi
> +PROVIDES += "hwdata-ivi"
> +
> +do_prep() {
> +    cd ${S}
> +    chmod -Rf a+rX,u+w,g-w,o-w ${S}

What's the point of changing permissions like this?

> +}
> +
> +do_patch_append() {
> +    bb.build.exec_func('do_prep',d)
> +}
> +
> +do_compile() {
> +    cd ${S}
> +    LANG=C
> +    export LANG
> +    unset DISPLAY
> +    LD_AS_NEEDED=1; export LD_AS_NEEDED ;
> +    autotools_do_configure

Why isn't this done in do_configure()?

> +}
> +
> +do_install() {
> +    export RPM_BUILD_ROOT=${D}

What's the point of setting RPM_BUILD_ROOT?  That seems like Fedora creep...

> +    cd ${S}
> +    LANG=C
> +    export LANG
> +    unset DISPLAY
> +    rm -rf ${D}
> +    mkdir -p ${D}
> +
> +    oe_runmake \
> +        DESTDIR=${D} \
> +        INSTALL_ROOT=${D} \
> +        BINDIR=${prefix}/bin \
> +        install

The lines below are incorrectly indented
> +        rm -f ${D}${infodir}/dir
> +        find ${D} -regex ".*\.la$" | xargs rm -f --
> +        find ${D} -regex ".*\.a$" | xargs rm -f --
> +        mkdir -p ${D}${sysconfdir}/modprobe.d
> +        mv ${D}${prefix}/lib/modprobe.d/dist-blacklist.conf \
> +        ${D}${sysconfdir}/modprobe.d/blacklist.conf
> +        rm -rf ${D}${prefix}/lib
> +        install -m644 blacklist.conf ${D}/${sysconfdir}/modprobe.d
... until here

> +}
> +
> +RDEPENDS_${PN}-ivi += "hwdata"
> +INSANE_SKIP_${PN}-ivi += "build-deps"
> +
> +PACKAGES = "${PN} ${PN}-dbg ${PN}-doc ${PN}-locale ${PN}-ivi"
>


-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [meta-oe][PATCH] hwdata: add new recipe

[Burton, Ross]

On 11 April 2016 at 09:59, Gary Thomas <gary@mlbassoc.com> wrote:

> +do_compile() {
>> +    cd ${S}
>> +    LANG=C
>> +    export LANG
>> +    unset DISPLAY
>> +    LD_AS_NEEDED=1; export LD_AS_NEEDED ;
>> +    autotools_do_configure
>>
>
> Why isn't this done in do_configure()?


More to the point, why is this done at all?  What's wrong with just inherit
autotools?  Exceptional recipes require justification.

Ross

[meta-oe][PATCH v2] hwdata: add new recipe

[Dai Caiyun]

Signed-off-by: Dai Caiyun <daicy.fnst@cn.fujitsu.com>
---
 meta-oe/recipes-support/hwdata/hwdata_0.288.bb | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 meta-oe/recipes-support/hwdata/hwdata_0.288.bb

diff --git a/meta-oe/recipes-support/hwdata/hwdata_0.288.bb b/meta-oe/recipes-support/hwdata/hwdata_0.288.bb
new file mode 100644
index 0000000..bac6618
--- /dev/null
+++ b/meta-oe/recipes-support/hwdata/hwdata_0.288.bb
@@ -0,0 +1,22 @@
+DESCRIPTION = "Hardware identification and configuration data"
+HOMEPAGE = "http://git.fedorahosted.org/git/hwdata.git"
+SECTION = "System/Base"
+
+LICENSE = "GPL-2.0+"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=1556547711e8246992b999edd9445a57"
+
+SRC_URI = "https://git.fedorahosted.org/cgit/${BPN}.git/snapshot/${BP}.tar.gz"
+
+SRC_URI[md5sum] = "f3fa1c5edb66ce5b376d95e772b2d303"
+SRC_URI[sha256sum] = "56fc26275b102e538fcfcf9c1093a09f476a1ea8d4e0c733d3c578442923693d"
+
+do_compile() {
+}
+
+do_install() {
+    install -m 0744 -d ${D}${sysconfdir}/modprobe.d
+    install -m 0644 -p ${S}/blacklist.conf ${D}/${sysconfdir}/modprobe.d
+    install -m 0744 -d ${D}${datadir}/${PN}
+    install -m 0644 -p ${S}/*.ids ${D}${datadir}/${PN}
+    install -m 0644 -p ${S}/oui.txt ${D}${datadir}/${PN}
+}
-- 
1.9.1

Re: [meta-oe][PATCH v2] hwdata: add new recipe

[Burton, Ross]

On 25 April 2016 at 10:35, Dai Caiyun <daicy.fnst@cn.fujitsu.com> wrote:

> +do_compile() {
> +}
> +
> +do_install() {
> +    install -m 0744 -d ${D}${sysconfdir}/modprobe.d
> +    install -m 0644 -p ${S}/blacklist.conf ${D}/${sysconfdir}/modprobe.d
> +    install -m 0744 -d ${D}${datadir}/${PN}
> +    install -m 0644 -p ${S}/*.ids ${D}${datadir}/${PN}
> +    install -m 0644 -p ${S}/oui.txt ${D}${datadir}/${PN}
> +}
>

So upstream ships a hand-coded configure script that writes a Makefile.inc
that the hand-crafted (but sane) Makefile then reads.  I'd do this:

do_configure() {
  ${S}/configure --datadir=${datadir} --libdir=${libdir}
}

do_install() {
  oe_runmake install DESTDIR=${D}
}

This is untested, but should work and use the makefile that upstream
provides, instead of replicating the install logic.

Ross

[meta-oe][PATCH v3] hwdata: add new recipe

[Dai Caiyun]

Signed-off-by: Dai Caiyun <daicy.fnst@cn.fujitsu.com>
---
 meta-oe/recipes-support/hwdata/hwdata_0.288.bb | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 meta-oe/recipes-support/hwdata/hwdata_0.288.bb

diff --git a/meta-oe/recipes-support/hwdata/hwdata_0.288.bb b/meta-oe/recipes-support/hwdata/hwdata_0.288.bb
new file mode 100644
index 0000000..67199e9
--- /dev/null
+++ b/meta-oe/recipes-support/hwdata/hwdata_0.288.bb
@@ -0,0 +1,21 @@
+DESCRIPTION = "Hardware identification and configuration data"
+HOMEPAGE = "http://git.fedorahosted.org/git/hwdata.git"
+SECTION = "System/Base"
+
+LICENSE = "GPL-2.0+"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=1556547711e8246992b999edd9445a57"
+SRC_URI = "https://git.fedorahosted.org/cgit/${BPN}.git/snapshot/${BP}.tar.gz"
+
+SRC_URI[md5sum] = "f3fa1c5edb66ce5b376d95e772b2d303"
+SRC_URI[sha256sum] = "56fc26275b102e538fcfcf9c1093a09f476a1ea8d4e0c733d3c578442923693d"
+
+do_configure() {
+    ${S}/configure --datadir=${datadir} --libdir=${libdir}
+}
+
+do_install() {
+    oe_runmake install DESTDIR=${D}
+}
+
+FILES_${PN} = "${libdir}/* \
+               ${datadir}/* "
-- 
1.9.1

Re: [meta-oe][PATCH v3] hwdata: add new recipe

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1678 bytes --]


> On Apr 26, 2016, at 1:43 AM, Dai Caiyun <daicy.fnst@cn.fujitsu.com> wrote:
> 
> Signed-off-by: Dai Caiyun <daicy.fnst@cn.fujitsu.com>
> ---
> meta-oe/recipes-support/hwdata/hwdata_0.288.bb | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> create mode 100644 meta-oe/recipes-support/hwdata/hwdata_0.288.bb
> 
> diff --git a/meta-oe/recipes-support/hwdata/hwdata_0.288.bb b/meta-oe/recipes-support/hwdata/hwdata_0.288.bb
> new file mode 100644
> index 0000000..67199e9
> --- /dev/null
> +++ b/meta-oe/recipes-support/hwdata/hwdata_0.288.bb
> @@ -0,0 +1,21 @@
> +DESCRIPTION = "Hardware identification and configuration data"
> +HOMEPAGE = "http://git.fedorahosted.org/git/hwdata.git"
> +SECTION = "System/Base"
> +
> +LICENSE = "GPL-2.0+"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=1556547711e8246992b999edd9445a57"
> +SRC_URI = "https://git.fedorahosted.org/cgit/${BPN}.git/snapshot/${BP}.tar.gz"
> +
> +SRC_URI[md5sum] = "f3fa1c5edb66ce5b376d95e772b2d303"
> +SRC_URI[sha256sum] = "56fc26275b102e538fcfcf9c1093a09f476a1ea8d4e0c733d3c578442923693d"
> +
> +do_configure() {
> +    ${S}/configure --datadir=${datadir} --libdir=${libdir}
> +}

is it using autotools ? if so then inherit autotools might be a good options
and remove the do_ functions here.

> +
> +do_install() {
> +    oe_runmake install DESTDIR=${D}
> +}
> +
> +FILES_${PN} = "${libdir}/* \
> +               ${datadir}/* "
> --
> 1.9.1
> 
> 
> 
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [meta-oe][PATCH v3] hwdata: add new recipe

[Paul Eggleton]

On Tue, 26 Apr 2016 09:50:54 Khem Raj wrote:
> > On Apr 26, 2016, at 1:43 AM, Dai Caiyun <daicy.fnst@cn.fujitsu.com> wrote:
> > 
> > Signed-off-by: Dai Caiyun <daicy.fnst@cn.fujitsu.com>
> > ---
> > meta-oe/recipes-support/hwdata/hwdata_0.288.bb | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> > create mode 100644 meta-oe/recipes-support/hwdata/hwdata_0.288.bb
> > 
> > diff --git a/meta-oe/recipes-support/hwdata/hwdata_0.288.bb
> > b/meta-oe/recipes-support/hwdata/hwdata_0.288.bb new file mode 100644
> > index 0000000..67199e9
> > --- /dev/null
> > +++ b/meta-oe/recipes-support/hwdata/hwdata_0.288.bb
> > @@ -0,0 +1,21 @@
> > +DESCRIPTION = "Hardware identification and configuration data"
> > +HOMEPAGE = "http://git.fedorahosted.org/git/hwdata.git"
> > +SECTION = "System/Base"
> > +
> > +LICENSE = "GPL-2.0+"
> > +LIC_FILES_CHKSUM = "file://LICENSE;md5=1556547711e8246992b999edd9445a57"
> > +SRC_URI =
> > "https://git.fedorahosted.org/cgit/${BPN}.git/snapshot/${BP}.tar.gz" +
> > +SRC_URI[md5sum] = "f3fa1c5edb66ce5b376d95e772b2d303"
> > +SRC_URI[sha256sum] =
> > "56fc26275b102e538fcfcf9c1093a09f476a1ea8d4e0c733d3c578442923693d" +
> > +do_configure() {
> > +    ${S}/configure --datadir=${datadir} --libdir=${libdir}
> > +}
> 
> is it using autotools ? if so then inherit autotools might be a good options
> and remove the do_ functions here.

We established earlier in the thread that it's not using autotools:

  https://git.fedorahosted.org/cgit/hwdata.git/tree/configure

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [meta-oe][PATCH v3] hwdata: add new recipe

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1754 bytes --]


> On Apr 26, 2016, at 2:20 PM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:
> 
> On Tue, 26 Apr 2016 09:50:54 Khem Raj wrote:
>>> On Apr 26, 2016, at 1:43 AM, Dai Caiyun <daicy.fnst@cn.fujitsu.com> wrote:
>>> 
>>> Signed-off-by: Dai Caiyun <daicy.fnst@cn.fujitsu.com>
>>> ---
>>> meta-oe/recipes-support/hwdata/hwdata_0.288.bb | 21 +++++++++++++++++++++
>>> 1 file changed, 21 insertions(+)
>>> create mode 100644 meta-oe/recipes-support/hwdata/hwdata_0.288.bb
>>> 
>>> diff --git a/meta-oe/recipes-support/hwdata/hwdata_0.288.bb
>>> b/meta-oe/recipes-support/hwdata/hwdata_0.288.bb new file mode 100644
>>> index 0000000..67199e9
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-support/hwdata/hwdata_0.288.bb
>>> @@ -0,0 +1,21 @@
>>> +DESCRIPTION = "Hardware identification and configuration data"
>>> +HOMEPAGE = "http://git.fedorahosted.org/git/hwdata.git"
>>> +SECTION = "System/Base"
>>> +
>>> +LICENSE = "GPL-2.0+"
>>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=1556547711e8246992b999edd9445a57"
>>> +SRC_URI =
>>> "https://git.fedorahosted.org/cgit/${BPN}.git/snapshot/${BP}.tar.gz" +
>>> +SRC_URI[md5sum] = "f3fa1c5edb66ce5b376d95e772b2d303"
>>> +SRC_URI[sha256sum] =
>>> "56fc26275b102e538fcfcf9c1093a09f476a1ea8d4e0c733d3c578442923693d" +
>>> +do_configure() {
>>> +    ${S}/configure --datadir=${datadir} --libdir=${libdir}
>>> +}
>> 
>> is it using autotools ? if so then inherit autotools might be a good options
>> and remove the do_ functions here.
> 
> We established earlier in the thread that it's not using autotools:
> 
>  https://git.fedorahosted.org/cgit/hwdata.git/tree/configure

ah thanks

> 
> Cheers,
> Paul
> 
> --
> 
> Paul Eggleton
> Intel Open Source Technology Centre


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]