All of lore.kernel.org
 help / color / mirror / Atom feed
From: qiuxishi@huawei.com (Xishi Qiu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: mm: make pfn always valid with flat memory
Date: Mon, 11 Apr 2016 19:08:38 +0800	[thread overview]
Message-ID: <570B85B6.8000805@huawei.com> (raw)
In-Reply-To: <1459844572-53069-2-git-send-email-puck.chen@hisilicon.com>

On 2016/4/5 16:22, Chen Feng wrote:

> Make the pfn always valid when using flat memory.
> If the reserved memory is not align to memblock-size,
> there will be holes in zone.
> 
> This patch makes the memory in buddy always in the
> array of mem-map.
> 
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> Signed-off-by: Fu Jun <oliver.fu@hisilicon.com>
> ---
>  arch/arm64/mm/init.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index ea989d8..0e1d5b7 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -306,7 +306,8 @@ static void __init free_unused_memmap(void)

How about let free_unused_memmap() support for CONFIG_SPARSEMEM_VMEMMAP?

Thanks,
Xishi Qiu

>  	struct memblock_region *reg;
>  
>  	for_each_memblock(memory, reg) {
> -		start = __phys_to_pfn(reg->base);
> +		start = round_down(__phys_to_pfn(reg->base),
> +				   MAX_ORDER_NR_PAGES);
>  
>  #ifdef CONFIG_SPARSEMEM
>  		/*
> @@ -327,8 +328,8 @@ static void __init free_unused_memmap(void)
>  		 * memmap entries are valid from the bank end aligned to
>  		 * MAX_ORDER_NR_PAGES.
>  		 */
> -		prev_end = ALIGN(__phys_to_pfn(reg->base + reg->size),
> -				 MAX_ORDER_NR_PAGES);
> +		prev_end = round_up(__phys_to_pfn(reg->base + reg->size),
> +				    MAX_ORDER_NR_PAGES);
>  	}
>  
>  #ifdef CONFIG_SPARSEMEM

WARNING: multiple messages have this Message-ID (diff)
From: Xishi Qiu <qiuxishi@huawei.com>
To: Chen Feng <puck.chen@hisilicon.com>
Cc: catalin.marinas@arm.com, will.deacon@arm.com,
	ard.biesheuvel@linaro.org, mark.rutland@arm.com,
	akpm@linux-foundation.org, robin.murphy@arm.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, mhocko@suse.com,
	kirill.shutemov@linux.intel.com, rientjes@google.com,
	linux-mm@kvack.org, dan.zhao@hisilicon.com,
	puck.chen@foxmail.com, suzhuangluan@hisilicon.com,
	linuxarm@huawei.com, saberlily.xia@hisilicon.com,
	oliver.fu@hisilicon.com, yudongbin@hislicon.com
Subject: Re: [PATCH 2/2] arm64: mm: make pfn always valid with flat memory
Date: Mon, 11 Apr 2016 19:08:38 +0800	[thread overview]
Message-ID: <570B85B6.8000805@huawei.com> (raw)
In-Reply-To: <1459844572-53069-2-git-send-email-puck.chen@hisilicon.com>

On 2016/4/5 16:22, Chen Feng wrote:

> Make the pfn always valid when using flat memory.
> If the reserved memory is not align to memblock-size,
> there will be holes in zone.
> 
> This patch makes the memory in buddy always in the
> array of mem-map.
> 
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> Signed-off-by: Fu Jun <oliver.fu@hisilicon.com>
> ---
>  arch/arm64/mm/init.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index ea989d8..0e1d5b7 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -306,7 +306,8 @@ static void __init free_unused_memmap(void)

How about let free_unused_memmap() support for CONFIG_SPARSEMEM_VMEMMAP?

Thanks,
Xishi Qiu

>  	struct memblock_region *reg;
>  
>  	for_each_memblock(memory, reg) {
> -		start = __phys_to_pfn(reg->base);
> +		start = round_down(__phys_to_pfn(reg->base),
> +				   MAX_ORDER_NR_PAGES);
>  
>  #ifdef CONFIG_SPARSEMEM
>  		/*
> @@ -327,8 +328,8 @@ static void __init free_unused_memmap(void)
>  		 * memmap entries are valid from the bank end aligned to
>  		 * MAX_ORDER_NR_PAGES.
>  		 */
> -		prev_end = ALIGN(__phys_to_pfn(reg->base + reg->size),
> -				 MAX_ORDER_NR_PAGES);
> +		prev_end = round_up(__phys_to_pfn(reg->base + reg->size),
> +				    MAX_ORDER_NR_PAGES);
>  	}
>  
>  #ifdef CONFIG_SPARSEMEM



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Xishi Qiu <qiuxishi@huawei.com>
To: Chen Feng <puck.chen@hisilicon.com>
Cc: <catalin.marinas@arm.com>, <will.deacon@arm.com>,
	<ard.biesheuvel@linaro.org>, <mark.rutland@arm.com>,
	<akpm@linux-foundation.org>, <robin.murphy@arm.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <mhocko@suse.com>,
	<kirill.shutemov@linux.intel.com>, <rientjes@google.com>,
	<linux-mm@kvack.org>, <dan.zhao@hisilicon.com>,
	<puck.chen@foxmail.com>, <suzhuangluan@hisilicon.com>,
	<linuxarm@huawei.com>, <saberlily.xia@hisilicon.com>,
	<oliver.fu@hisilicon.com>, <yudongbin@hislicon.com>
Subject: Re: [PATCH 2/2] arm64: mm: make pfn always valid with flat memory
Date: Mon, 11 Apr 2016 19:08:38 +0800	[thread overview]
Message-ID: <570B85B6.8000805@huawei.com> (raw)
In-Reply-To: <1459844572-53069-2-git-send-email-puck.chen@hisilicon.com>

On 2016/4/5 16:22, Chen Feng wrote:

> Make the pfn always valid when using flat memory.
> If the reserved memory is not align to memblock-size,
> there will be holes in zone.
> 
> This patch makes the memory in buddy always in the
> array of mem-map.
> 
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> Signed-off-by: Fu Jun <oliver.fu@hisilicon.com>
> ---
>  arch/arm64/mm/init.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index ea989d8..0e1d5b7 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -306,7 +306,8 @@ static void __init free_unused_memmap(void)

How about let free_unused_memmap() support for CONFIG_SPARSEMEM_VMEMMAP?

Thanks,
Xishi Qiu

>  	struct memblock_region *reg;
>  
>  	for_each_memblock(memory, reg) {
> -		start = __phys_to_pfn(reg->base);
> +		start = round_down(__phys_to_pfn(reg->base),
> +				   MAX_ORDER_NR_PAGES);
>  
>  #ifdef CONFIG_SPARSEMEM
>  		/*
> @@ -327,8 +328,8 @@ static void __init free_unused_memmap(void)
>  		 * memmap entries are valid from the bank end aligned to
>  		 * MAX_ORDER_NR_PAGES.
>  		 */
> -		prev_end = ALIGN(__phys_to_pfn(reg->base + reg->size),
> -				 MAX_ORDER_NR_PAGES);
> +		prev_end = round_up(__phys_to_pfn(reg->base + reg->size),
> +				    MAX_ORDER_NR_PAGES);
>  	}
>  
>  #ifdef CONFIG_SPARSEMEM

  parent reply	other threads:[~2016-04-11 11:08 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05  8:22 [PATCH 1/2] arm64: mem-model: add flatmem model for arm64 Chen Feng
2016-04-05  8:22 ` Chen Feng
2016-04-05  8:22 ` Chen Feng
2016-04-05  8:22 ` [PATCH 2/2] arm64: mm: make pfn always valid with flat memory Chen Feng
2016-04-05  8:22   ` Chen Feng
2016-04-05  8:22   ` Chen Feng
2016-04-07  7:39   ` Chen Feng
2016-04-07  7:39     ` Chen Feng
2016-04-07  7:39     ` Chen Feng
2016-04-11 11:08   ` Xishi Qiu [this message]
2016-04-11 11:08     ` Xishi Qiu
2016-04-11 11:08     ` Xishi Qiu
2016-04-12 15:00     ` Catalin Marinas
2016-04-12 15:00       ` Catalin Marinas
2016-04-12 15:00       ` Catalin Marinas
2016-04-07  7:38 ` [PATCH 1/2] arm64: mem-model: add flatmem model for arm64 Chen Feng
2016-04-07  7:38   ` Chen Feng
2016-04-07  7:38   ` Chen Feng
2016-04-07 14:21 ` Will Deacon
2016-04-07 14:21   ` Will Deacon
2016-04-07 14:21   ` Will Deacon
2016-04-11  2:49   ` Chen Feng
2016-04-11  2:49     ` Chen Feng
2016-04-11  2:49     ` Chen Feng
2016-04-11  7:35     ` Ard Biesheuvel
2016-04-11  7:35       ` Ard Biesheuvel
2016-04-11  7:35       ` Ard Biesheuvel
2016-04-11  7:55       ` Chen Feng
2016-04-11  7:55         ` Chen Feng
2016-04-11  7:55         ` Chen Feng
2016-04-11  8:00         ` Ard Biesheuvel
2016-04-11  8:00           ` Ard Biesheuvel
2016-04-11  8:00           ` Ard Biesheuvel
2016-04-11  9:59           ` Chen Feng
2016-04-11  9:59             ` Chen Feng
2016-04-11  9:59             ` Chen Feng
2016-04-11 10:31             ` Ard Biesheuvel
2016-04-11 10:31               ` Ard Biesheuvel
2016-04-11 10:31               ` Ard Biesheuvel
2016-04-11 10:40               ` Will Deacon
2016-04-11 10:40                 ` Will Deacon
2016-04-11 10:40                 ` Will Deacon
2016-04-11 10:57                 ` Chen Feng
2016-04-11 10:57                   ` Chen Feng
2016-04-11 10:57                   ` Chen Feng
2016-04-11 18:11                   ` Laura Abbott
2016-04-11 18:11                     ` Laura Abbott
2016-04-11 18:11                     ` Laura Abbott
2016-04-12 14:44                 ` Catalin Marinas
2016-04-12 14:44                   ` Catalin Marinas
2016-04-12 14:44                   ` Catalin Marinas
2016-04-12 14:59               ` Catalin Marinas
2016-04-12 14:59                 ` Catalin Marinas
2016-04-12 14:59                 ` Catalin Marinas
2016-04-20  3:18                 ` Chen Feng
2016-04-20  3:18                   ` Chen Feng
2016-04-20  3:18                   ` Chen Feng
2016-04-20  9:32                   ` Catalin Marinas
2016-04-20  9:32                     ` Catalin Marinas
2016-04-20  9:32                     ` Catalin Marinas
2016-04-11 10:48             ` Chen Feng
2016-04-11 10:48               ` Chen Feng
2016-04-11 10:48               ` Chen Feng
2016-04-11 11:02               ` Ard Biesheuvel
2016-04-11 11:02                 ` Ard Biesheuvel
2016-04-11 11:02                 ` Ard Biesheuvel
2016-04-12 14:03     ` Jungseok Lee
2016-04-12 14:03       ` Jungseok Lee
2016-04-12 14:03       ` Jungseok Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570B85B6.8000805@huawei.com \
    --to=qiuxishi@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.