From: David Daney <ddaney@caviumnetworks.com>
To: Jayachandran C <jchandra@broadcom.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Tomasz Nowicki <tn@semihalf.com>,
rafael@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Hanjun Guo <hanjun.guo@linaro.org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
okaya@codeaurora.org, jiang.liu@linux.intel.com,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
robert.richter@caviumnetworks.com,
Marcin Wojtas <mw@semihalf.com>,
Liviu.Dudau@arm.com, wangyijing@huawei.com,
Suravee.Suthikulpanit@amd.com, msalter@redhat.com,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linaro-acpi@lists.linaro.org, Jon Masters <jcm@redhat.com>
Subject: Re: [PATCH v2 3/4] PCI: generic, thunder: update to use generic ECAM API
Date: Mon, 11 Apr 2016 17:34:34 -0700 [thread overview]
Message-ID: <570C429A.6090006@caviumnetworks.com> (raw)
In-Reply-To: <1460414707-19153-4-git-send-email-jchandra@broadcom.com>
On 04/11/2016 03:45 PM, Jayachandran C wrote:
> Use functions provided by drivers/pci/ecam.h for mapping the config
> space in drivers/pci/host/pci-host-common.c, and update its users to
> use 'struct pci_config_window' and 'struct pci_generic_ecam_ops'
>
> The changes are mostly to use 'struct pci_config_window' in place of
> 'struct gen_pci'. Some of the fields of gen_pci were only used
> temporarily and can be eliminated by using local variables or function
> arguments, these are not carried over to struct pci_config_window.
>
> pci-thunder-ecam.c and pci-thunder-pem.c are the only users of the
> pci_host_common_probe function and the gen_pci structure, these have
> been updated to use the new API as well.
>
> The patch does not introduce any functional changes other than a very
> minor one: with the new code, on 64-bit platforms, we do just a single
> ioremap for the whole config space.
>
> Signed-off-by: Jayachandran C <jchandra@broadcom.com>
Tested-by: David Daney <david.daney@cavium.com>
However, ...
> ---
> drivers/pci/ecam.h | 5 ++
> drivers/pci/host/Kconfig | 1 +
> drivers/pci/host/pci-host-common.c | 121 ++++++++++++++++--------------------
> drivers/pci/host/pci-host-common.h | 47 --------------
> drivers/pci/host/pci-host-generic.c | 50 +++------------
> drivers/pci/host/pci-thunder-ecam.c | 37 +++--------
> drivers/pci/host/pci-thunder-pem.c | 53 +++++-----------
... The patch conflicts with a bug-fix patch I just sent to
pci-thunder-pem.c, so there will be a race to see who gets in first.
Also, I don't know if it would make sense to split out the pci-thunder-*
changes to a separate patch.
> 7 files changed, 93 insertions(+), 221 deletions(-)
> delete mode 100644 drivers/pci/host/pci-host-common.h
>
[...]
WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com>
To: Jayachandran C <jchandra@broadcom.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Tomasz Nowicki <tn@semihalf.com>, <rafael@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Hanjun Guo <hanjun.guo@linaro.org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
<okaya@codeaurora.org>, <jiang.liu@linux.intel.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
<robert.richter@caviumnetworks.com>,
Marcin Wojtas <mw@semihalf.com>, <Liviu.Dudau@arm.com>,
<wangyijing@huawei.com>, <Suravee.Suthikulpanit@amd.com>,
<msalter@redhat.com>, <linux-pci@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linaro-acpi@lists.linaro.org>, Jon Masters <jcm@redhat.com>
Subject: Re: [PATCH v2 3/4] PCI: generic, thunder: update to use generic ECAM API
Date: Mon, 11 Apr 2016 17:34:34 -0700 [thread overview]
Message-ID: <570C429A.6090006@caviumnetworks.com> (raw)
In-Reply-To: <1460414707-19153-4-git-send-email-jchandra@broadcom.com>
On 04/11/2016 03:45 PM, Jayachandran C wrote:
> Use functions provided by drivers/pci/ecam.h for mapping the config
> space in drivers/pci/host/pci-host-common.c, and update its users to
> use 'struct pci_config_window' and 'struct pci_generic_ecam_ops'
>
> The changes are mostly to use 'struct pci_config_window' in place of
> 'struct gen_pci'. Some of the fields of gen_pci were only used
> temporarily and can be eliminated by using local variables or function
> arguments, these are not carried over to struct pci_config_window.
>
> pci-thunder-ecam.c and pci-thunder-pem.c are the only users of the
> pci_host_common_probe function and the gen_pci structure, these have
> been updated to use the new API as well.
>
> The patch does not introduce any functional changes other than a very
> minor one: with the new code, on 64-bit platforms, we do just a single
> ioremap for the whole config space.
>
> Signed-off-by: Jayachandran C <jchandra@broadcom.com>
Tested-by: David Daney <david.daney@cavium.com>
However, ...
> ---
> drivers/pci/ecam.h | 5 ++
> drivers/pci/host/Kconfig | 1 +
> drivers/pci/host/pci-host-common.c | 121 ++++++++++++++++--------------------
> drivers/pci/host/pci-host-common.h | 47 --------------
> drivers/pci/host/pci-host-generic.c | 50 +++------------
> drivers/pci/host/pci-thunder-ecam.c | 37 +++--------
> drivers/pci/host/pci-thunder-pem.c | 53 +++++-----------
... The patch conflicts with a bug-fix patch I just sent to
pci-thunder-pem.c, so there will be a race to see who gets in first.
Also, I don't know if it would make sense to split out the pci-thunder-*
changes to a separate patch.
> 7 files changed, 93 insertions(+), 221 deletions(-)
> delete mode 100644 drivers/pci/host/pci-host-common.h
>
[...]
WARNING: multiple messages have this Message-ID (diff)
From: ddaney@caviumnetworks.com (David Daney)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] PCI: generic, thunder: update to use generic ECAM API
Date: Mon, 11 Apr 2016 17:34:34 -0700 [thread overview]
Message-ID: <570C429A.6090006@caviumnetworks.com> (raw)
In-Reply-To: <1460414707-19153-4-git-send-email-jchandra@broadcom.com>
On 04/11/2016 03:45 PM, Jayachandran C wrote:
> Use functions provided by drivers/pci/ecam.h for mapping the config
> space in drivers/pci/host/pci-host-common.c, and update its users to
> use 'struct pci_config_window' and 'struct pci_generic_ecam_ops'
>
> The changes are mostly to use 'struct pci_config_window' in place of
> 'struct gen_pci'. Some of the fields of gen_pci were only used
> temporarily and can be eliminated by using local variables or function
> arguments, these are not carried over to struct pci_config_window.
>
> pci-thunder-ecam.c and pci-thunder-pem.c are the only users of the
> pci_host_common_probe function and the gen_pci structure, these have
> been updated to use the new API as well.
>
> The patch does not introduce any functional changes other than a very
> minor one: with the new code, on 64-bit platforms, we do just a single
> ioremap for the whole config space.
>
> Signed-off-by: Jayachandran C <jchandra@broadcom.com>
Tested-by: David Daney <david.daney@cavium.com>
However, ...
> ---
> drivers/pci/ecam.h | 5 ++
> drivers/pci/host/Kconfig | 1 +
> drivers/pci/host/pci-host-common.c | 121 ++++++++++++++++--------------------
> drivers/pci/host/pci-host-common.h | 47 --------------
> drivers/pci/host/pci-host-generic.c | 50 +++------------
> drivers/pci/host/pci-thunder-ecam.c | 37 +++--------
> drivers/pci/host/pci-thunder-pem.c | 53 +++++-----------
... The patch conflicts with a bug-fix patch I just sent to
pci-thunder-pem.c, so there will be a race to see who gets in first.
Also, I don't know if it would make sense to split out the pci-thunder-*
changes to a separate patch.
> 7 files changed, 93 insertions(+), 221 deletions(-)
> delete mode 100644 drivers/pci/host/pci-host-common.h
>
[...]
next prev parent reply other threads:[~2016-04-12 0:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 22:45 [PATCH v2 0/4] ACPI based PCI host driver with generic ECAM Jayachandran C
2016-04-11 22:45 ` Jayachandran C
2016-04-11 22:45 ` [PATCH v2 1/4] arm64: Prepare to use generic ACPI PCI implementation Jayachandran C
2016-04-11 22:45 ` Jayachandran C
2016-04-11 22:45 ` [PATCH v2 2/4] PCI: Provide common functions for ECAM mapping Jayachandran C
2016-04-11 22:45 ` Jayachandran C
2016-04-12 0:24 ` David Daney
2016-04-12 0:24 ` David Daney
2016-04-12 0:24 ` David Daney
2016-04-12 4:26 ` Jon Masters
2016-04-12 4:26 ` Jon Masters
2016-04-12 16:44 ` Lorenzo Pieralisi
2016-04-12 16:44 ` Lorenzo Pieralisi
2016-04-14 5:55 ` Jon Masters
2016-04-14 5:55 ` Jon Masters
2016-04-14 5:55 ` Jon Masters
2016-04-14 10:05 ` Lorenzo Pieralisi
2016-04-14 10:05 ` Lorenzo Pieralisi
2016-04-14 15:40 ` Jayachandran C
2016-04-14 15:40 ` Jayachandran C
2016-04-11 22:45 ` [PATCH v2 3/4] PCI: generic, thunder: update to use generic ECAM API Jayachandran C
2016-04-11 22:45 ` Jayachandran C
2016-04-12 0:34 ` David Daney [this message]
2016-04-12 0:34 ` David Daney
2016-04-12 0:34 ` David Daney
2016-04-14 14:15 ` Jayachandran C
2016-04-14 14:15 ` Jayachandran C
2016-04-11 22:45 ` [PATCH v2 4/4] ACPI: PCI: Add generic PCI host controller Jayachandran C
2016-04-11 22:45 ` Jayachandran C
2016-04-12 1:38 ` kbuild test robot
2016-04-12 1:38 ` kbuild test robot
2016-04-12 1:38 ` kbuild test robot
2016-04-14 15:53 ` Sinan Kaya
2016-04-14 15:53 ` Sinan Kaya
2016-04-14 15:58 ` Sinan Kaya
2016-04-14 15:58 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570C429A.6090006@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=Liviu.Dudau@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=hanjun.guo@linaro.org \
--cc=helgaas@kernel.org \
--cc=jchandra@broadcom.com \
--cc=jcm@redhat.com \
--cc=jiang.liu@linux.intel.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=msalter@redhat.com \
--cc=mw@semihalf.com \
--cc=okaya@codeaurora.org \
--cc=rafael@kernel.org \
--cc=robert.richter@caviumnetworks.com \
--cc=tn@semihalf.com \
--cc=wangyijing@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.