From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Yuyang Du <yuyang.du@intel.com>,
peterz@infradead.org, mingo@kernel.org,
linux-kernel@vger.kernel.org
Cc: bsegall@google.com, pjt@google.com, morten.rasmussen@arm.com,
vincent.guittot@linaro.org, juri.lelli@arm.com
Subject: Re: [PATCH 2/4] sched/fair: Drop out incomplete current period when sched averages accrue
Date: Tue, 12 Apr 2016 13:02:58 +0100 [thread overview]
Message-ID: <570CE3F2.5000806@arm.com> (raw)
In-Reply-To: <1460327765-18024-3-git-send-email-yuyang.du@intel.com>
On 10/04/16 23:36, Yuyang Du wrote:
[...]
> @@ -2704,11 +2694,14 @@ static __always_inline int
> __update_load_avg(u64 now, int cpu, struct sched_avg *sa,
> unsigned long weight, int running, struct cfs_rq *cfs_rq)
> {
> - u64 delta, scaled_delta, periods;
> - u32 contrib;
> - unsigned int delta_w, scaled_delta_w, decayed = 0;
> + u64 delta;
> + u32 contrib, periods;
> unsigned long scale_freq, scale_cpu;
>
> + /*
> + * now rolls down to a period boundary
> + */
> + now = now && (u64)(~0xFFFFF);
This forces now to be 1.
s/&&/&
next prev parent reply other threads:[~2016-04-12 12:03 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-10 22:36 [PATCH 0/4] Optimize sched avg computation and implement flat util hierarchy Yuyang Du
2016-04-10 22:36 ` [PATCH 1/4] sched/fair: Optimize sum computation with a lookup table Yuyang Du
2016-04-11 9:08 ` Vincent Guittot
2016-04-11 10:41 ` Juri Lelli
2016-04-11 19:12 ` Yuyang Du
2016-04-12 10:14 ` Juri Lelli
2016-04-12 18:07 ` Yuyang Du
2016-04-13 9:11 ` Juri Lelli
2016-04-11 16:59 ` Dietmar Eggemann
2016-04-11 19:17 ` Yuyang Du
2016-04-12 14:19 ` Peter Zijlstra
2016-04-12 18:12 ` Yuyang Du
2016-04-11 23:21 ` Joe Perches
2016-04-12 12:02 ` Juri Lelli
2016-04-11 23:07 ` Joe Perches
2016-04-10 22:36 ` [PATCH 2/4] sched/fair: Drop out incomplete current period when sched averages accrue Yuyang Du
2016-04-11 9:08 ` Vincent Guittot
2016-04-11 19:41 ` Yuyang Du
2016-04-12 11:56 ` Vincent Guittot
2016-04-12 21:09 ` Yuyang Du
2016-04-13 11:11 ` Vincent Guittot
2016-04-12 12:02 ` Dietmar Eggemann [this message]
2016-04-12 20:14 ` Yuyang Du
2016-04-13 4:04 ` Joe Perches
2016-04-13 8:40 ` Morten Rasmussen
2016-04-13 15:13 ` Dietmar Eggemann
2016-04-13 15:28 ` Vincent Guittot
2016-04-13 16:20 ` Vincent Guittot
2016-04-13 18:44 ` Yuyang Du
2016-04-14 12:52 ` Dietmar Eggemann
2016-04-14 20:05 ` Yuyang Du
2016-04-18 17:59 ` Yuyang Du
2016-04-10 22:36 ` [PATCH 3/4] sched/fair: Modify accumulated sums for load/util averages Yuyang Du
2016-04-11 17:14 ` Dietmar Eggemann
2016-04-10 22:36 ` [PATCH 4/4] sched/fair: Implement flat hierarchical structure for util_avg Yuyang Du
2016-04-11 12:29 ` Vincent Guittot
2016-04-11 20:37 ` Yuyang Du
2016-04-13 11:27 ` Vincent Guittot
2016-04-13 18:20 ` Yuyang Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570CE3F2.5000806@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=bsegall@google.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=vincent.guittot@linaro.org \
--cc=yuyang.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.