From: Tadeusz Struk <tadeusz.struk-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org,
smueller-T9tCv8IpfcWELgA04lAiVw@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
keyrings-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org
Subject: Re: [PATCH v4 6/7] crypto: KEYS - add generic handlers to symmetric key type
Date: Tue, 12 Apr 2016 15:20:05 -0700 [thread overview]
Message-ID: <570D7495.7060801@intel.com> (raw)
In-Reply-To: <16339.1460499046-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
On 04/12/2016 03:10 PM, David Howells wrote:
>> +/**
>> > + * asymmetric_key_verify_signature - invoke verify signature operation on a key
>> > + * of the asymmetric subtype
>> > + * @key: key from the system keyring
>> > + * @sig: signature to verify
>> > + *
>> > + * return: 0 on success or errno on failure
>> > + */
>> > +int asymmetric_key_verify_signature(const struct key *key,
>> > + const struct public_key_signature *sig)
> This is duplicating what's in signature.c in the same directory.
Right, should I remove it? Is the asymmetric_type.c good place to put all the operation
handlers into?
Thanks,
--
TS
WARNING: multiple messages have this Message-ID (diff)
From: Tadeusz Struk <tadeusz.struk@intel.com>
To: David Howells <dhowells@redhat.com>
Cc: herbert@gondor.apana.org.au, smueller@chronox.de,
linux-api@vger.kernel.org, marcel@holtmann.org,
linux-kernel@vger.kernel.org, keyrings@vger.kernel.org,
linux-crypto@vger.kernel.org, dwmw2@infradead.org,
davem@davemloft.net
Subject: Re: [PATCH v4 6/7] crypto: KEYS - add generic handlers to symmetric key type
Date: Tue, 12 Apr 2016 15:20:05 -0700 [thread overview]
Message-ID: <570D7495.7060801@intel.com> (raw)
In-Reply-To: <16339.1460499046@warthog.procyon.org.uk>
On 04/12/2016 03:10 PM, David Howells wrote:
>> +/**
>> > + * asymmetric_key_verify_signature - invoke verify signature operation on a key
>> > + * of the asymmetric subtype
>> > + * @key: key from the system keyring
>> > + * @sig: signature to verify
>> > + *
>> > + * return: 0 on success or errno on failure
>> > + */
>> > +int asymmetric_key_verify_signature(const struct key *key,
>> > + const struct public_key_signature *sig)
> This is duplicating what's in signature.c in the same directory.
Right, should I remove it? Is the asymmetric_type.c good place to put all the operation
handlers into?
Thanks,
--
TS
next prev parent reply other threads:[~2016-04-12 22:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 1:37 [PATCH v4 0/7] crypto: algif - add akcipher Tadeusz Struk
2016-04-01 1:37 ` [PATCH v4 1/7] crypto: AF_ALG -- add sign/verify API Tadeusz Struk
2016-04-01 1:37 ` [PATCH v4 2/7] crypto: AF_ALG -- add setpubkey setsockopt call Tadeusz Struk
2016-04-01 1:38 ` [PATCH v4 3/7] crypto: AF_ALG -- add asymmetric cipher interface Tadeusz Struk
2016-04-01 1:38 ` [PATCH v4 4/7] crypto: algif_akcipher - enable compilation Tadeusz Struk
2016-04-01 1:38 ` [PATCH v4 5/7] crypto: algif_akcipher - add ops_nokey Tadeusz Struk
2016-04-01 1:38 ` [PATCH v4 6/7] crypto: KEYS - add generic handlers to symmetric key type Tadeusz Struk
2016-04-12 22:10 ` David Howells
[not found] ` <16339.1460499046-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2016-04-12 22:20 ` Tadeusz Struk [this message]
2016-04-12 22:20 ` Tadeusz Struk
2016-04-01 1:38 ` [PATCH v4 7/7] crypto: AF_ALG - add support for key_id Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570D7495.7060801@intel.com \
--to=tadeusz.struk-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org \
--cc=keyrings-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \
--cc=smueller-T9tCv8IpfcWELgA04lAiVw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.