All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tero Kristo <t-kristo@ti.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
	Michael Turquette <mturquette@baylibre.com>
Cc: <nsekhar@ti.com>, <linux-omap@vger.kernel.org>,
	<linux-clk@vger.kernel.org>, Stephen Boyd <sboyd@codeaurora.org>,
	Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] clk: ti: dra7: fix kernel boot with arg 'clocksource=gp_timer'
Date: Wed, 13 Apr 2016 15:50:40 +0300	[thread overview]
Message-ID: <570E40A0.1040107@ti.com> (raw)
In-Reply-To: <1449767025-2438-1-git-send-email-grygorii.strashko@ti.com>

On 12/10/2015 07:03 PM, Grygorii Strashko wrote:
> The OMAP Platform code provides possibility to select GP Timer as
> default clocksource instead of counter_32K by using bootcmd parameter
> 'clocksource', but the system will crash during early boot when this
> option is used on dra7 or omap5 platforms, because it will hit BUG()
> statement:
>
>   omap2_gptimer_clocksource_init
>    ->BUG_ON(res);
>
> This happens because clk_dev alias "sys_clkin_ck" is not registered.
> Hence, fix it by adding missing "sys_clkin_ck" clk_dev aliases
> definitions for omap5 and dra7.
>
> Cc: Tero Kristo <t-kristo@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>

Seems this was lost on the mailing lists. Stephen, want to pick this up 
also? You were going to pick some other TI clock patches also for 4.7.

Acked-by: Tero Kristo <t-kristo@ti.com>

> ---
>   drivers/clk/ti/clk-54xx.c | 1 +
>   drivers/clk/ti/clk-7xx.c  | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/drivers/clk/ti/clk-54xx.c b/drivers/clk/ti/clk-54xx.c
> index 59ce2fa..294bc03 100644
> --- a/drivers/clk/ti/clk-54xx.c
> +++ b/drivers/clk/ti/clk-54xx.c
> @@ -210,6 +210,7 @@ static struct ti_dt_clk omap54xx_clks[] = {
>   	DT_CLK("usbhs_omap", "usbtll_fck", "dummy_ck"),
>   	DT_CLK("omap_wdt", "ick", "dummy_ck"),
>   	DT_CLK(NULL, "timer_32k_ck", "sys_32k_ck"),
> +	DT_CLK(NULL, "sys_clkin_ck", "sys_clkin"),
>   	DT_CLK("4ae18000.timer", "timer_sys_ck", "sys_clkin"),
>   	DT_CLK("48032000.timer", "timer_sys_ck", "sys_clkin"),
>   	DT_CLK("48034000.timer", "timer_sys_ck", "sys_clkin"),
> diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
> index a911d7d..87a87b5 100644
> --- a/drivers/clk/ti/clk-7xx.c
> +++ b/drivers/clk/ti/clk-7xx.c
> @@ -289,6 +289,7 @@ static struct ti_dt_clk dra7xx_clks[] = {
>   	DT_CLK("usbhs_omap", "usbtll_fck", "dummy_ck"),
>   	DT_CLK("omap_wdt", "ick", "dummy_ck"),
>   	DT_CLK(NULL, "timer_32k_ck", "sys_32k_ck"),
> +	DT_CLK(NULL, "sys_clkin_ck", "timer_sys_clk_div"),
>   	DT_CLK("4ae18000.timer", "timer_sys_ck", "timer_sys_clk_div"),
>   	DT_CLK("48032000.timer", "timer_sys_ck", "timer_sys_clk_div"),
>   	DT_CLK("48034000.timer", "timer_sys_ck", "timer_sys_clk_div"),
>

WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
	Michael Turquette <mturquette@baylibre.com>
Cc: nsekhar@ti.com, linux-omap@vger.kernel.org,
	linux-clk@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
	Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] clk: ti: dra7: fix kernel boot with arg 'clocksource=gp_timer'
Date: Wed, 13 Apr 2016 15:50:40 +0300	[thread overview]
Message-ID: <570E40A0.1040107@ti.com> (raw)
In-Reply-To: <1449767025-2438-1-git-send-email-grygorii.strashko@ti.com>

On 12/10/2015 07:03 PM, Grygorii Strashko wrote:
> The OMAP Platform code provides possibility to select GP Timer as
> default clocksource instead of counter_32K by using bootcmd parameter
> 'clocksource', but the system will crash during early boot when this
> option is used on dra7 or omap5 platforms, because it will hit BUG()
> statement:
>
>   omap2_gptimer_clocksource_init
>    ->BUG_ON(res);
>
> This happens because clk_dev alias "sys_clkin_ck" is not registered.
> Hence, fix it by adding missing "sys_clkin_ck" clk_dev aliases
> definitions for omap5 and dra7.
>
> Cc: Tero Kristo <t-kristo@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>

Seems this was lost on the mailing lists. Stephen, want to pick this up 
also? You were going to pick some other TI clock patches also for 4.7.

Acked-by: Tero Kristo <t-kristo@ti.com>

> ---
>   drivers/clk/ti/clk-54xx.c | 1 +
>   drivers/clk/ti/clk-7xx.c  | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/drivers/clk/ti/clk-54xx.c b/drivers/clk/ti/clk-54xx.c
> index 59ce2fa..294bc03 100644
> --- a/drivers/clk/ti/clk-54xx.c
> +++ b/drivers/clk/ti/clk-54xx.c
> @@ -210,6 +210,7 @@ static struct ti_dt_clk omap54xx_clks[] = {
>   	DT_CLK("usbhs_omap", "usbtll_fck", "dummy_ck"),
>   	DT_CLK("omap_wdt", "ick", "dummy_ck"),
>   	DT_CLK(NULL, "timer_32k_ck", "sys_32k_ck"),
> +	DT_CLK(NULL, "sys_clkin_ck", "sys_clkin"),
>   	DT_CLK("4ae18000.timer", "timer_sys_ck", "sys_clkin"),
>   	DT_CLK("48032000.timer", "timer_sys_ck", "sys_clkin"),
>   	DT_CLK("48034000.timer", "timer_sys_ck", "sys_clkin"),
> diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
> index a911d7d..87a87b5 100644
> --- a/drivers/clk/ti/clk-7xx.c
> +++ b/drivers/clk/ti/clk-7xx.c
> @@ -289,6 +289,7 @@ static struct ti_dt_clk dra7xx_clks[] = {
>   	DT_CLK("usbhs_omap", "usbtll_fck", "dummy_ck"),
>   	DT_CLK("omap_wdt", "ick", "dummy_ck"),
>   	DT_CLK(NULL, "timer_32k_ck", "sys_32k_ck"),
> +	DT_CLK(NULL, "sys_clkin_ck", "timer_sys_clk_div"),
>   	DT_CLK("4ae18000.timer", "timer_sys_ck", "timer_sys_clk_div"),
>   	DT_CLK("48032000.timer", "timer_sys_ck", "timer_sys_clk_div"),
>   	DT_CLK("48034000.timer", "timer_sys_ck", "timer_sys_clk_div"),
>


  reply	other threads:[~2016-04-13 12:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-10 17:03 [PATCH] clk: ti: dra7: fix kernel boot with arg 'clocksource=gp_timer' Grygorii Strashko
2015-12-10 17:03 ` Grygorii Strashko
2016-04-13 12:50 ` Tero Kristo [this message]
2016-04-13 12:50   ` Tero Kristo
2016-04-16  0:30 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570E40A0.1040107@ti.com \
    --to=t-kristo@ti.com \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=nsekhar@ti.com \
    --cc=sboyd@codeaurora.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.