* [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
@ 2016-03-29 10:03 ` Suzuki K Poulose
0 siblings, 0 replies; 20+ messages in thread
From: Suzuki K Poulose @ 2016-03-29 10:03 UTC (permalink / raw)
To: linux-arm-kernel
Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
added support for ARCH_SUNXI on arm64, but failed to select
GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
and causes build failures like :
UPD include/generated/compile.h
CC init/version.o
LD init/built-in.o
drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to `irq_setup_alt_chip'
drivers/built-in.o: In function `irq_domain_add_linear':
include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to `irq_alloc_domain_generic_chips'
drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to `irq_get_domain_generic_chip'
drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to `irq_gc_mask_set_bit'
drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to `irq_gc_ack_set_bit'
drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
Cc: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
arch/arm64/Kconfig.platforms | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index efa77c1..521b1ec 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -2,6 +2,7 @@ menu "Platform selection"
config ARCH_SUNXI
bool "Allwinner sunxi 64-bit SoC Family"
+ select GENERIC_IRQ_CHIP
help
This enables support for Allwinner sunxi based SoCs like the A64.
--
1.7.9.5
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
@ 2016-03-29 10:03 ` Suzuki K Poulose
0 siblings, 0 replies; 20+ messages in thread
From: Suzuki K Poulose @ 2016-03-29 10:03 UTC (permalink / raw)
To: linux-arm-kernel, arm
Cc: andre.przywara, olof, arnd, linux-kernel, Suzuki K Poulose
Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
added support for ARCH_SUNXI on arm64, but failed to select
GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
and causes build failures like :
UPD include/generated/compile.h
CC init/version.o
LD init/built-in.o
drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to `irq_setup_alt_chip'
drivers/built-in.o: In function `irq_domain_add_linear':
include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to `irq_alloc_domain_generic_chips'
drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to `irq_get_domain_generic_chip'
drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to `irq_gc_mask_set_bit'
drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to `irq_gc_ack_set_bit'
drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
Cc: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
arch/arm64/Kconfig.platforms | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index efa77c1..521b1ec 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -2,6 +2,7 @@ menu "Platform selection"
config ARCH_SUNXI
bool "Allwinner sunxi 64-bit SoC Family"
+ select GENERIC_IRQ_CHIP
help
This enables support for Allwinner sunxi based SoCs like the A64.
--
1.7.9.5
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
2016-03-29 10:03 ` Suzuki K Poulose
@ 2016-04-06 9:05 ` Andre Przywara
-1 siblings, 0 replies; 20+ messages in thread
From: Andre Przywara @ 2016-04-06 9:05 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 29/03/16 11:03, Suzuki K Poulose wrote:
> Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
> added support for ARCH_SUNXI on arm64, but failed to select
> GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
> and causes build failures like :
Thanks for the catch! GENERIC_IRQ_CHIP somehow gets selected by
defconfig, so I didn't see the issue.
Currently we don't need the irq-sunxi-nmi driver, but we may in the
future and it depends on CONFIG_ARCH_SUNXI only, so I guess this patch
is the easiest solution (rather than creating a separate config symbol
for it, which may be an option for later).
So...
>
> UPD include/generated/compile.h
> CC init/version.o
> LD init/built-in.o
> drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
> drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to `irq_setup_alt_chip'
> drivers/built-in.o: In function `irq_domain_add_linear':
> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
> drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
> drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to `irq_alloc_domain_generic_chips'
> drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to `irq_get_domain_generic_chip'
> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
> drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to `irq_gc_mask_set_bit'
> drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to `irq_gc_ack_set_bit'
> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
>
> Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
> Cc: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Acked-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre.
> ---
> arch/arm64/Kconfig.platforms | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index efa77c1..521b1ec 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -2,6 +2,7 @@ menu "Platform selection"
>
> config ARCH_SUNXI
> bool "Allwinner sunxi 64-bit SoC Family"
> + select GENERIC_IRQ_CHIP
> help
> This enables support for Allwinner sunxi based SoCs like the A64.
>
>
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
@ 2016-04-06 9:05 ` Andre Przywara
0 siblings, 0 replies; 20+ messages in thread
From: Andre Przywara @ 2016-04-06 9:05 UTC (permalink / raw)
To: Suzuki K Poulose, linux-arm-kernel, arm; +Cc: olof, arnd, linux-kernel
Hi,
On 29/03/16 11:03, Suzuki K Poulose wrote:
> Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
> added support for ARCH_SUNXI on arm64, but failed to select
> GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
> and causes build failures like :
Thanks for the catch! GENERIC_IRQ_CHIP somehow gets selected by
defconfig, so I didn't see the issue.
Currently we don't need the irq-sunxi-nmi driver, but we may in the
future and it depends on CONFIG_ARCH_SUNXI only, so I guess this patch
is the easiest solution (rather than creating a separate config symbol
for it, which may be an option for later).
So...
>
> UPD include/generated/compile.h
> CC init/version.o
> LD init/built-in.o
> drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
> drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to `irq_setup_alt_chip'
> drivers/built-in.o: In function `irq_domain_add_linear':
> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
> drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
> drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to `irq_alloc_domain_generic_chips'
> drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to `irq_get_domain_generic_chip'
> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
> drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to `irq_gc_mask_set_bit'
> drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to `irq_gc_ack_set_bit'
> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
>
> Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
> Cc: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Acked-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre.
> ---
> arch/arm64/Kconfig.platforms | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index efa77c1..521b1ec 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -2,6 +2,7 @@ menu "Platform selection"
>
> config ARCH_SUNXI
> bool "Allwinner sunxi 64-bit SoC Family"
> + select GENERIC_IRQ_CHIP
> help
> This enables support for Allwinner sunxi based SoCs like the A64.
>
>
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
2016-04-06 9:05 ` Andre Przywara
@ 2016-04-07 14:18 ` Suzuki K Poulose
-1 siblings, 0 replies; 20+ messages in thread
From: Suzuki K Poulose @ 2016-04-07 14:18 UTC (permalink / raw)
To: linux-arm-kernel
On 06/04/16 10:05, Andre Przywara wrote:
> Hi,
>
> On 29/03/16 11:03, Suzuki K Poulose wrote:
>> Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
>> added support for ARCH_SUNXI on arm64, but failed to select
>> GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
>> and causes build failures like :
>
> Thanks for the catch! GENERIC_IRQ_CHIP somehow gets selected by
> defconfig, so I didn't see the issue.
>
> Currently we don't need the irq-sunxi-nmi driver, but we may in the
> future and it depends on CONFIG_ARCH_SUNXI only, so I guess this patch
> is the easiest solution (rather than creating a separate config symbol
> for it, which may be an option for later).
...
>> Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
>> Cc: Andre Przywara <andre.przywara@arm.com>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>
> Acked-by: Andre Przywara <andre.przywara@arm.com>
Olof, Arnd,
Please could you pick this for rc3 ?
Thanks
Suzuki
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
@ 2016-04-07 14:18 ` Suzuki K Poulose
0 siblings, 0 replies; 20+ messages in thread
From: Suzuki K Poulose @ 2016-04-07 14:18 UTC (permalink / raw)
To: arm, olof, arnd; +Cc: Andre Przywara, linux-arm-kernel, linux-kernel
On 06/04/16 10:05, Andre Przywara wrote:
> Hi,
>
> On 29/03/16 11:03, Suzuki K Poulose wrote:
>> Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
>> added support for ARCH_SUNXI on arm64, but failed to select
>> GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
>> and causes build failures like :
>
> Thanks for the catch! GENERIC_IRQ_CHIP somehow gets selected by
> defconfig, so I didn't see the issue.
>
> Currently we don't need the irq-sunxi-nmi driver, but we may in the
> future and it depends on CONFIG_ARCH_SUNXI only, so I guess this patch
> is the easiest solution (rather than creating a separate config symbol
> for it, which may be an option for later).
...
>> Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
>> Cc: Andre Przywara <andre.przywara@arm.com>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>
> Acked-by: Andre Przywara <andre.przywara@arm.com>
Olof, Arnd,
Please could you pick this for rc3 ?
Thanks
Suzuki
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
2016-03-29 10:03 ` Suzuki K Poulose
@ 2016-04-12 19:11 ` Olof Johansson
-1 siblings, 0 replies; 20+ messages in thread
From: Olof Johansson @ 2016-04-12 19:11 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 29, 2016 at 11:03:06AM +0100, Suzuki K Poulose wrote:
> Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
> added support for ARCH_SUNXI on arm64, but failed to select
> GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
> and causes build failures like :
>
> UPD include/generated/compile.h
> CC init/version.o
> LD init/built-in.o
> drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
> drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to `irq_setup_alt_chip'
> drivers/built-in.o: In function `irq_domain_add_linear':
> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
> drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
> drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to `irq_alloc_domain_generic_chips'
> drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to `irq_get_domain_generic_chip'
> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
> drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to `irq_gc_mask_set_bit'
> drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to `irq_gc_ack_set_bit'
> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
>
> Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
> Cc: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
It'd be nice to have a silent Kconfig entry that selects from ARCH_SUNXI that
sets this dependency, instead of having it from the architecture code. This
pushes down the dependency to the right level.
Can you respin with it like that instead?
-Olof
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
@ 2016-04-12 19:11 ` Olof Johansson
0 siblings, 0 replies; 20+ messages in thread
From: Olof Johansson @ 2016-04-12 19:11 UTC (permalink / raw)
To: Suzuki K Poulose
Cc: linux-arm-kernel, arm, andre.przywara, arnd, linux-kernel
On Tue, Mar 29, 2016 at 11:03:06AM +0100, Suzuki K Poulose wrote:
> Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
> added support for ARCH_SUNXI on arm64, but failed to select
> GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
> and causes build failures like :
>
> UPD include/generated/compile.h
> CC init/version.o
> LD init/built-in.o
> drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
> drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to `irq_setup_alt_chip'
> drivers/built-in.o: In function `irq_domain_add_linear':
> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
> drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
> drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to `irq_alloc_domain_generic_chips'
> drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to `irq_get_domain_generic_chip'
> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
> drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to `irq_gc_mask_set_bit'
> drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to `irq_gc_ack_set_bit'
> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
>
> Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
> Cc: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
It'd be nice to have a silent Kconfig entry that selects from ARCH_SUNXI that
sets this dependency, instead of having it from the architecture code. This
pushes down the dependency to the right level.
Can you respin with it like that instead?
-Olof
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
2016-04-12 19:11 ` Olof Johansson
@ 2016-04-13 9:05 ` Suzuki K Poulose
-1 siblings, 0 replies; 20+ messages in thread
From: Suzuki K Poulose @ 2016-04-13 9:05 UTC (permalink / raw)
To: linux-arm-kernel
On 12/04/16 20:11, Olof Johansson wrote:
> On Tue, Mar 29, 2016 at 11:03:06AM +0100, Suzuki K Poulose wrote:
>> Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
>> added support for ARCH_SUNXI on arm64, but failed to select
>> GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
>> and causes build failures like :
>>
>> UPD include/generated/compile.h
>> CC init/version.o
>> LD init/built-in.o
>> drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
>> drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to `irq_setup_alt_chip'
>> drivers/built-in.o: In function `irq_domain_add_linear':
>> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
>> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
>> drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
>> drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to `irq_alloc_domain_generic_chips'
>> drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to `irq_get_domain_generic_chip'
>> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
>> drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to `irq_gc_mask_set_bit'
>> drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to `irq_gc_ack_set_bit'
>> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
>>
>> Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
>> Cc: Andre Przywara <andre.przywara@arm.com>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>
> It'd be nice to have a silent Kconfig entry that selects from ARCH_SUNXI that
> sets this dependency, instead of having it from the architecture code. This
> pushes down the dependency to the right level.
Do you mean something like :
config ARCH_SUNXI
...
select SUNXI_PLATFORM
And have
config SUNXI_PLATFORM
select SUNXI_DEPENDENCY_1
select SUNXI_DEPENDENCY_2
where SUNXI_PLATFORM drives the dependencies for both ARM and ARM64 ?
If so, where would you like SUNXI_PLATFORM to reside ? drivers/platform ?
Also, AFAIK, the arm64 port doesn't have the full support for the required
bits for SUNXI yet, which could be handled in the common place with ( && !ARM64).
Andre, please feel free to correct my assessment above.
Thanks
Suzuki
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
@ 2016-04-13 9:05 ` Suzuki K Poulose
0 siblings, 0 replies; 20+ messages in thread
From: Suzuki K Poulose @ 2016-04-13 9:05 UTC (permalink / raw)
To: Olof Johansson, andre.przywara; +Cc: linux-arm-kernel, arm, arnd, linux-kernel
On 12/04/16 20:11, Olof Johansson wrote:
> On Tue, Mar 29, 2016 at 11:03:06AM +0100, Suzuki K Poulose wrote:
>> Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
>> added support for ARCH_SUNXI on arm64, but failed to select
>> GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
>> and causes build failures like :
>>
>> UPD include/generated/compile.h
>> CC init/version.o
>> LD init/built-in.o
>> drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
>> drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to `irq_setup_alt_chip'
>> drivers/built-in.o: In function `irq_domain_add_linear':
>> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
>> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
>> drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
>> drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to `irq_alloc_domain_generic_chips'
>> drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to `irq_get_domain_generic_chip'
>> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
>> drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to `irq_gc_mask_set_bit'
>> drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to `irq_gc_ack_set_bit'
>> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
>>
>> Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
>> Cc: Andre Przywara <andre.przywara@arm.com>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>
> It'd be nice to have a silent Kconfig entry that selects from ARCH_SUNXI that
> sets this dependency, instead of having it from the architecture code. This
> pushes down the dependency to the right level.
Do you mean something like :
config ARCH_SUNXI
...
select SUNXI_PLATFORM
And have
config SUNXI_PLATFORM
select SUNXI_DEPENDENCY_1
select SUNXI_DEPENDENCY_2
where SUNXI_PLATFORM drives the dependencies for both ARM and ARM64 ?
If so, where would you like SUNXI_PLATFORM to reside ? drivers/platform ?
Also, AFAIK, the arm64 port doesn't have the full support for the required
bits for SUNXI yet, which could be handled in the common place with ( && !ARM64).
Andre, please feel free to correct my assessment above.
Thanks
Suzuki
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
2016-04-13 9:05 ` Suzuki K Poulose
@ 2016-04-13 13:17 ` Rob Herring
-1 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2016-04-13 13:17 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Apr 13, 2016 at 4:05 AM, Suzuki K Poulose
<Suzuki.Poulose@arm.com> wrote:
> On 12/04/16 20:11, Olof Johansson wrote:
>>
>> On Tue, Mar 29, 2016 at 11:03:06AM +0100, Suzuki K Poulose wrote:
>>>
>>> Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
>>> added support for ARCH_SUNXI on arm64, but failed to select
>>> GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
>>> and causes build failures like :
>>>
>>> UPD include/generated/compile.h
>>> CC init/version.o
>>> LD init/built-in.o
>>> drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
>>> drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to
>>> `irq_setup_alt_chip'
>>> drivers/built-in.o: In function `irq_domain_add_linear':
>>> include/linux/irqdomain.h:253: undefined reference to
>>> `irq_generic_chip_ops'
>>> include/linux/irqdomain.h:253: undefined reference to
>>> `irq_generic_chip_ops'
>>> drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
>>> drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to
>>> `irq_alloc_domain_generic_chips'
>>> drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to
>>> `irq_get_domain_generic_chip'
>>> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to
>>> `irq_gc_mask_clr_bit'
>>> drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to
>>> `irq_gc_mask_set_bit'
>>> drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to
>>> `irq_gc_ack_set_bit'
>>> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to
>>> `irq_gc_mask_clr_bit'
>>>
>>> Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config
>>> option")
>>> Cc: Andre Przywara <andre.przywara@arm.com>
>>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>>
>>
>> It'd be nice to have a silent Kconfig entry that selects from ARCH_SUNXI
>> that
>> sets this dependency, instead of having it from the architecture code.
>> This
>> pushes down the dependency to the right level.
>
>
> Do you mean something like :
> config ARCH_SUNXI
> ...
> select SUNXI_PLATFORM
>
> And have
>
> config SUNXI_PLATFORM
> select SUNXI_DEPENDENCY_1
> select SUNXI_DEPENDENCY_2
>
> where SUNXI_PLATFORM drives the dependencies for both ARM and ARM64 ?
No, I believe what Olof is saying is make the kconfig symbol for the
irqchip (irq-sunxi-nmi) select it. If there is not a kconfig symbol
already for it because you just use ARCH_SUNXI directly, then add it.
Rob
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
@ 2016-04-13 13:17 ` Rob Herring
0 siblings, 0 replies; 20+ messages in thread
From: Rob Herring @ 2016-04-13 13:17 UTC (permalink / raw)
To: Suzuki K Poulose
Cc: Olof Johansson, Andre Przywara, arm@kernel.org, Arnd Bergmann,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On Wed, Apr 13, 2016 at 4:05 AM, Suzuki K Poulose
<Suzuki.Poulose@arm.com> wrote:
> On 12/04/16 20:11, Olof Johansson wrote:
>>
>> On Tue, Mar 29, 2016 at 11:03:06AM +0100, Suzuki K Poulose wrote:
>>>
>>> Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
>>> added support for ARCH_SUNXI on arm64, but failed to select
>>> GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
>>> and causes build failures like :
>>>
>>> UPD include/generated/compile.h
>>> CC init/version.o
>>> LD init/built-in.o
>>> drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
>>> drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to
>>> `irq_setup_alt_chip'
>>> drivers/built-in.o: In function `irq_domain_add_linear':
>>> include/linux/irqdomain.h:253: undefined reference to
>>> `irq_generic_chip_ops'
>>> include/linux/irqdomain.h:253: undefined reference to
>>> `irq_generic_chip_ops'
>>> drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
>>> drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to
>>> `irq_alloc_domain_generic_chips'
>>> drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to
>>> `irq_get_domain_generic_chip'
>>> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to
>>> `irq_gc_mask_clr_bit'
>>> drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to
>>> `irq_gc_mask_set_bit'
>>> drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to
>>> `irq_gc_ack_set_bit'
>>> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to
>>> `irq_gc_mask_clr_bit'
>>>
>>> Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config
>>> option")
>>> Cc: Andre Przywara <andre.przywara@arm.com>
>>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>>
>>
>> It'd be nice to have a silent Kconfig entry that selects from ARCH_SUNXI
>> that
>> sets this dependency, instead of having it from the architecture code.
>> This
>> pushes down the dependency to the right level.
>
>
> Do you mean something like :
> config ARCH_SUNXI
> ...
> select SUNXI_PLATFORM
>
> And have
>
> config SUNXI_PLATFORM
> select SUNXI_DEPENDENCY_1
> select SUNXI_DEPENDENCY_2
>
> where SUNXI_PLATFORM drives the dependencies for both ARM and ARM64 ?
No, I believe what Olof is saying is make the kconfig symbol for the
irqchip (irq-sunxi-nmi) select it. If there is not a kconfig symbol
already for it because you just use ARCH_SUNXI directly, then add it.
Rob
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
2016-04-13 13:17 ` Rob Herring
@ 2016-04-13 13:20 ` Suzuki K Poulose
-1 siblings, 0 replies; 20+ messages in thread
From: Suzuki K Poulose @ 2016-04-13 13:20 UTC (permalink / raw)
To: linux-arm-kernel
On 13/04/16 14:17, Rob Herring wrote:
> On Wed, Apr 13, 2016 at 4:05 AM, Suzuki K Poulose
> <Suzuki.Poulose@arm.com> wrote:
>> On 12/04/16 20:11, Olof Johansson wrote:
>>>
>>> On Tue, Mar 29, 2016 at 11:03:06AM +0100, Suzuki K Poulose wrote:
>> Do you mean something like :
>> config ARCH_SUNXI
>> ...
>> select SUNXI_PLATFORM
>>
>> And have
>>
>> config SUNXI_PLATFORM
>> select SUNXI_DEPENDENCY_1
>> select SUNXI_DEPENDENCY_2
>>
>> where SUNXI_PLATFORM drives the dependencies for both ARM and ARM64 ?
>
> No, I believe what Olof is saying is make the kconfig symbol for the
> irqchip (irq-sunxi-nmi) select it. If there is not a kconfig symbol
> already for it because you just use ARCH_SUNXI directly, then add it.
Ok, makes sense. Thanks, will respin it.
Suzuki
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
@ 2016-04-13 13:20 ` Suzuki K Poulose
0 siblings, 0 replies; 20+ messages in thread
From: Suzuki K Poulose @ 2016-04-13 13:20 UTC (permalink / raw)
To: Rob Herring
Cc: Olof Johansson, Andre Przywara, arm@kernel.org, Arnd Bergmann,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On 13/04/16 14:17, Rob Herring wrote:
> On Wed, Apr 13, 2016 at 4:05 AM, Suzuki K Poulose
> <Suzuki.Poulose@arm.com> wrote:
>> On 12/04/16 20:11, Olof Johansson wrote:
>>>
>>> On Tue, Mar 29, 2016 at 11:03:06AM +0100, Suzuki K Poulose wrote:
>> Do you mean something like :
>> config ARCH_SUNXI
>> ...
>> select SUNXI_PLATFORM
>>
>> And have
>>
>> config SUNXI_PLATFORM
>> select SUNXI_DEPENDENCY_1
>> select SUNXI_DEPENDENCY_2
>>
>> where SUNXI_PLATFORM drives the dependencies for both ARM and ARM64 ?
>
> No, I believe what Olof is saying is make the kconfig symbol for the
> irqchip (irq-sunxi-nmi) select it. If there is not a kconfig symbol
> already for it because you just use ARCH_SUNXI directly, then add it.
Ok, makes sense. Thanks, will respin it.
Suzuki
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
@ 2016-05-09 22:37 ` Andre Przywara
0 siblings, 0 replies; 20+ messages in thread
From: Andre Przywara @ 2016-05-09 22:37 UTC (permalink / raw)
To: linux-arm-kernel
From: Suzuki K Poulose <suzuki.poulose@arm.com>
Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
added support for ARCH_SUNXI on arm64, but failed to select
GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
and causes build failures like :
UPD include/generated/compile.h
CC init/version.o
LD init/built-in.o
drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to `irq_setup_alt_chip'
drivers/built-in.o: In function `irq_domain_add_linear':
include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to `irq_alloc_domain_generic_chips'
drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to `irq_get_domain_generic_chip'
drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to `irq_gc_mask_set_bit'
drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to `irq_gc_ack_set_bit'
drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
Cc: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
Hi Olof, Arnd,
as agreed upon in that other mail, can you take this patch for 4.6?
Cheers,
Andre.
arch/arm64/Kconfig.platforms | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index efa77c1..521b1ec 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -2,6 +2,7 @@ menu "Platform selection"
config ARCH_SUNXI
bool "Allwinner sunxi 64-bit SoC Family"
+ select GENERIC_IRQ_CHIP
help
This enables support for Allwinner sunxi based SoCs like the A64.
--
2.7.4
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
@ 2016-05-09 22:37 ` Andre Przywara
0 siblings, 0 replies; 20+ messages in thread
From: Andre Przywara @ 2016-05-09 22:37 UTC (permalink / raw)
To: arm; +Cc: maxime.ripard, linux-arm-kernel, linux-kernel, olof, arnd
From: Suzuki K Poulose <suzuki.poulose@arm.com>
Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
added support for ARCH_SUNXI on arm64, but failed to select
GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
and causes build failures like :
UPD include/generated/compile.h
CC init/version.o
LD init/built-in.o
drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to `irq_setup_alt_chip'
drivers/built-in.o: In function `irq_domain_add_linear':
include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to `irq_alloc_domain_generic_chips'
drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to `irq_get_domain_generic_chip'
drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to `irq_gc_mask_set_bit'
drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to `irq_gc_ack_set_bit'
drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
Cc: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
Hi Olof, Arnd,
as agreed upon in that other mail, can you take this patch for 4.6?
Cheers,
Andre.
arch/arm64/Kconfig.platforms | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index efa77c1..521b1ec 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -2,6 +2,7 @@ menu "Platform selection"
config ARCH_SUNXI
bool "Allwinner sunxi 64-bit SoC Family"
+ select GENERIC_IRQ_CHIP
help
This enables support for Allwinner sunxi based SoCs like the A64.
--
2.7.4
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
2016-05-09 22:37 ` Andre Przywara
@ 2016-05-10 19:10 ` Maxime Ripard
-1 siblings, 0 replies; 20+ messages in thread
From: Maxime Ripard @ 2016-05-10 19:10 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, May 09, 2016 at 11:37:35PM +0100, Andre Przywara wrote:
> From: Suzuki K Poulose <suzuki.poulose@arm.com>
>
> Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
> added support for ARCH_SUNXI on arm64, but failed to select
> GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
> and causes build failures like :
>
> UPD include/generated/compile.h
> CC init/version.o
> LD init/built-in.o
> drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
> drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to `irq_setup_alt_chip'
> drivers/built-in.o: In function `irq_domain_add_linear':
> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
> drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
> drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to `irq_alloc_domain_generic_chips'
> drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to `irq_get_domain_generic_chip'
> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
> drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to `irq_gc_mask_set_bit'
> drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to `irq_gc_ack_set_bit'
> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
>
> Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
> Cc: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160510/90df44ad/attachment.sig>
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
@ 2016-05-10 19:10 ` Maxime Ripard
0 siblings, 0 replies; 20+ messages in thread
From: Maxime Ripard @ 2016-05-10 19:10 UTC (permalink / raw)
To: Andre Przywara; +Cc: arm, linux-arm-kernel, linux-kernel, olof, arnd
[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]
On Mon, May 09, 2016 at 11:37:35PM +0100, Andre Przywara wrote:
> From: Suzuki K Poulose <suzuki.poulose@arm.com>
>
> Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"),
> added support for ARCH_SUNXI on arm64, but failed to select
> GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c
> and causes build failures like :
>
> UPD include/generated/compile.h
> CC init/version.o
> LD init/built-in.o
> drivers/built-in.o: In function `sunxi_sc_nmi_set_type':
> drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to `irq_setup_alt_chip'
> drivers/built-in.o: In function `irq_domain_add_linear':
> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
> include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops'
> drivers/built-in.o: In function `sunxi_sc_nmi_irq_init':
> drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to `irq_alloc_domain_generic_chips'
> drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to `irq_get_domain_generic_chip'
> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
> drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to `irq_gc_mask_set_bit'
> drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to `irq_gc_ack_set_bit'
> drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit'
>
> Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
> Cc: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread* [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
2016-05-10 19:10 ` Maxime Ripard
@ 2016-05-10 19:44 ` Arnd Bergmann
-1 siblings, 0 replies; 20+ messages in thread
From: Arnd Bergmann @ 2016-05-10 19:44 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 10 May 2016 21:10:45 Maxime Ripard wrote:
> > Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
> > Cc: Andre Przywara <andre.przywara@arm.com>
> > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
Applied to fixes, thanks!
Arnd
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip
@ 2016-05-10 19:44 ` Arnd Bergmann
0 siblings, 0 replies; 20+ messages in thread
From: Arnd Bergmann @ 2016-05-10 19:44 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Maxime Ripard, Andre Przywara, olof, arm, linux-kernel
On Tuesday 10 May 2016 21:10:45 Maxime Ripard wrote:
> > Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option")
> > Cc: Andre Przywara <andre.przywara@arm.com>
> > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
Applied to fixes, thanks!
Arnd
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2016-05-10 19:45 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-29 10:03 [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip Suzuki K Poulose
2016-03-29 10:03 ` Suzuki K Poulose
2016-04-06 9:05 ` Andre Przywara
2016-04-06 9:05 ` Andre Przywara
2016-04-07 14:18 ` Suzuki K Poulose
2016-04-07 14:18 ` Suzuki K Poulose
2016-04-12 19:11 ` Olof Johansson
2016-04-12 19:11 ` Olof Johansson
2016-04-13 9:05 ` Suzuki K Poulose
2016-04-13 9:05 ` Suzuki K Poulose
2016-04-13 13:17 ` Rob Herring
2016-04-13 13:17 ` Rob Herring
2016-04-13 13:20 ` Suzuki K Poulose
2016-04-13 13:20 ` Suzuki K Poulose
-- strict thread matches above, loose matches on Subject: below --
2016-05-09 22:37 Andre Przywara
2016-05-09 22:37 ` Andre Przywara
2016-05-10 19:10 ` Maxime Ripard
2016-05-10 19:10 ` Maxime Ripard
2016-05-10 19:44 ` Arnd Bergmann
2016-05-10 19:44 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.