* [PATCH] device-tree: nexus7-flo: Remove power gpio key entry and use pmic8xxx-pwrkey @ 2016-04-13 17:16 John Stultz 2016-04-13 17:24 ` Sudeep Holla 0 siblings, 1 reply; 4+ messages in thread From: John Stultz @ 2016-04-13 17:16 UTC (permalink / raw) To: lkml Cc: John Stultz, Rob Herring, Arnd Bergmann, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Andy Gross, Vinay Simha BN, Bjorn Andersson, Stephen Boyd, linux-arm-msm, devicetree Since the pmic8xxx-pwrkey driver is already supported in the qcom-apq8064.dtsi, and the pmic8xxx-pwrkey supports logic to configure proper device shutdown when ps_hold goes low, it is better to use that driver then a generic gpio button. Thus this patch remove the gpio power key entry here, so we don't get double input events from having two drivers enabled. The one gotcha with the pmic8xxx-pwrkey is it has a fairly long debounce delay, which we shorten here to make the button behave as expected. Cc: Rob Herring <robh+dt@kernel.org> Cc: Arnd Bergmann <arnd.bergmann@linaro.org> Cc: Pawel Moll <pawel.moll@arm.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> Cc: Kumar Gala <galak@codeaurora.org> Cc: Andy Gross <agross@codeaurora.org> Cc: Vinay Simha BN <simhavcs@gmail.com> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Stephen Boyd <stephen.boyd@linaro.org> Cc: linux-arm-msm@vger.kernel.org Cc: devicetree@vger.kernel.org Signed-off-by: John Stultz <john.stultz@linaro.org> --- arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts index c535b3f..7ac1c65 100644 --- a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts +++ b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts @@ -29,12 +29,6 @@ gpio-keys { compatible = "gpio-keys"; - power { - label = "Power"; - gpios = <&tlmm_pinmux 26 GPIO_ACTIVE_LOW>; - linux,code = <KEY_POWER>; - gpio-key,wakeup; - }; volume_up { label = "Volume Up"; gpios = <&pm8921_gpio 4 GPIO_ACTIVE_HIGH>; @@ -190,6 +184,15 @@ }; }; + /* override default debounce for power-key */ + qcom,ssbi@500000 { + pmic@0 { + pwrkey@1c { + debounce = <1>; + }; + }; + }; + gsbi@16200000 { status = "okay"; qcom,mode = <GSBI_PROT_I2C>; -- 1.9.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] device-tree: nexus7-flo: Remove power gpio key entry and use pmic8xxx-pwrkey 2016-04-13 17:16 [PATCH] device-tree: nexus7-flo: Remove power gpio key entry and use pmic8xxx-pwrkey John Stultz @ 2016-04-13 17:24 ` Sudeep Holla [not found] ` <570E80CA.3080100-5wv7dgnIgG8@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Sudeep Holla @ 2016-04-13 17:24 UTC (permalink / raw) To: John Stultz, lkml Cc: Sudeep Holla, Rob Herring, Arnd Bergmann, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Andy Gross, Vinay Simha BN, Bjorn Andersson, Stephen Boyd, linux-arm-msm, devicetree On 13/04/16 18:16, John Stultz wrote: > Since the pmic8xxx-pwrkey driver is already supported in the > qcom-apq8064.dtsi, and the pmic8xxx-pwrkey supports logic to > configure proper device shutdown when ps_hold goes low, it is > better to use that driver then a generic gpio button. > > Thus this patch remove the gpio power key entry here, so we > don't get double input events from having two drivers enabled. > > The one gotcha with the pmic8xxx-pwrkey is it has a fairly > long debounce delay, which we shorten here to make the button > behave as expected. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Arnd Bergmann <arnd.bergmann@linaro.org> > Cc: Pawel Moll <pawel.moll@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> > Cc: Kumar Gala <galak@codeaurora.org> > Cc: Andy Gross <agross@codeaurora.org> > Cc: Vinay Simha BN <simhavcs@gmail.com> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Stephen Boyd <stephen.boyd@linaro.org> > Cc: linux-arm-msm@vger.kernel.org > Cc: devicetree@vger.kernel.org > Signed-off-by: John Stultz <john.stultz@linaro.org> > --- > arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts > index c535b3f..7ac1c65 100644 > --- a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts > +++ b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts > @@ -29,12 +29,6 @@ > > gpio-keys { > compatible = "gpio-keys"; > - power { > - label = "Power"; > - gpios = <&tlmm_pinmux 26 GPIO_ACTIVE_LOW>; > - linux,code = <KEY_POWER>; > - gpio-key,wakeup; You are dropping wakeup with this change. Is that intentional ? If not, while you are at this, replace it with "wakeup-source" which is standard binding. If yes, then it solves the problem :). I had a patch to replace it, but was waiting to check if any new files in linux-next before posting. For now, this is the only legacy entry. -- Regards, Sudeep ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <570E80CA.3080100-5wv7dgnIgG8@public.gmane.org>]
* Re: [PATCH] device-tree: nexus7-flo: Remove power gpio key entry and use pmic8xxx-pwrkey 2016-04-13 17:24 ` Sudeep Holla @ 2016-04-13 17:34 ` John Stultz 0 siblings, 0 replies; 4+ messages in thread From: John Stultz @ 2016-04-13 17:34 UTC (permalink / raw) To: Sudeep Holla Cc: lkml, Rob Herring, Arnd Bergmann, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Andy Gross, Vinay Simha BN, Bjorn Andersson, Stephen Boyd, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA On Wed, Apr 13, 2016 at 10:24 AM, Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org> wrote: > > > On 13/04/16 18:16, John Stultz wrote: >> >> Since the pmic8xxx-pwrkey driver is already supported in the >> qcom-apq8064.dtsi, and the pmic8xxx-pwrkey supports logic to >> configure proper device shutdown when ps_hold goes low, it is >> better to use that driver then a generic gpio button. >> >> Thus this patch remove the gpio power key entry here, so we >> don't get double input events from having two drivers enabled. >> >> The one gotcha with the pmic8xxx-pwrkey is it has a fairly >> long debounce delay, which we shorten here to make the button >> behave as expected. >> >> Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> >> Cc: Arnd Bergmann <arnd.bergmann-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> >> Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> >> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> >> Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> >> Cc: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> >> Cc: Andy Gross <agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> >> Cc: Vinay Simha BN <simhavcs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> Cc: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> >> Cc: Stephen Boyd <stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> >> Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> Signed-off-by: John Stultz <john.stultz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> >> --- >> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 15 +++++++++------ >> 1 file changed, 9 insertions(+), 6 deletions(-) >> >> diff --git a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts >> b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts >> index c535b3f..7ac1c65 100644 >> --- a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts >> +++ b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts >> @@ -29,12 +29,6 @@ >> >> gpio-keys { >> compatible = "gpio-keys"; >> - power { >> - label = "Power"; >> - gpios = <&tlmm_pinmux 26 GPIO_ACTIVE_LOW>; >> - linux,code = <KEY_POWER>; >> - gpio-key,wakeup; > > > You are dropping wakeup with this change. Is that intentional ? > > If not, while you are at this, replace it with "wakeup-source" > which is standard binding. Thanks for catching this. Its not intentional, but I don't have suspend/resume working yet on the n7 so I've never really tested it. I'll add wakeup-source to the pwrkey entry for the next version. thanks -john -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] device-tree: nexus7-flo: Remove power gpio key entry and use pmic8xxx-pwrkey @ 2016-04-13 17:34 ` John Stultz 0 siblings, 0 replies; 4+ messages in thread From: John Stultz @ 2016-04-13 17:34 UTC (permalink / raw) To: Sudeep Holla Cc: lkml, Rob Herring, Arnd Bergmann, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Andy Gross, Vinay Simha BN, Bjorn Andersson, Stephen Boyd, linux-arm-msm@vger.kernel.org, devicetree On Wed, Apr 13, 2016 at 10:24 AM, Sudeep Holla <sudeep.holla@arm.com> wrote: > > > On 13/04/16 18:16, John Stultz wrote: >> >> Since the pmic8xxx-pwrkey driver is already supported in the >> qcom-apq8064.dtsi, and the pmic8xxx-pwrkey supports logic to >> configure proper device shutdown when ps_hold goes low, it is >> better to use that driver then a generic gpio button. >> >> Thus this patch remove the gpio power key entry here, so we >> don't get double input events from having two drivers enabled. >> >> The one gotcha with the pmic8xxx-pwrkey is it has a fairly >> long debounce delay, which we shorten here to make the button >> behave as expected. >> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Arnd Bergmann <arnd.bergmann@linaro.org> >> Cc: Pawel Moll <pawel.moll@arm.com> >> Cc: Mark Rutland <mark.rutland@arm.com> >> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> >> Cc: Kumar Gala <galak@codeaurora.org> >> Cc: Andy Gross <agross@codeaurora.org> >> Cc: Vinay Simha BN <simhavcs@gmail.com> >> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> >> Cc: Stephen Boyd <stephen.boyd@linaro.org> >> Cc: linux-arm-msm@vger.kernel.org >> Cc: devicetree@vger.kernel.org >> Signed-off-by: John Stultz <john.stultz@linaro.org> >> --- >> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 15 +++++++++------ >> 1 file changed, 9 insertions(+), 6 deletions(-) >> >> diff --git a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts >> b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts >> index c535b3f..7ac1c65 100644 >> --- a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts >> +++ b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts >> @@ -29,12 +29,6 @@ >> >> gpio-keys { >> compatible = "gpio-keys"; >> - power { >> - label = "Power"; >> - gpios = <&tlmm_pinmux 26 GPIO_ACTIVE_LOW>; >> - linux,code = <KEY_POWER>; >> - gpio-key,wakeup; > > > You are dropping wakeup with this change. Is that intentional ? > > If not, while you are at this, replace it with "wakeup-source" > which is standard binding. Thanks for catching this. Its not intentional, but I don't have suspend/resume working yet on the n7 so I've never really tested it. I'll add wakeup-source to the pwrkey entry for the next version. thanks -john ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-13 17:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-13 17:16 [PATCH] device-tree: nexus7-flo: Remove power gpio key entry and use pmic8xxx-pwrkey John Stultz
2016-04-13 17:24 ` Sudeep Holla
[not found] ` <570E80CA.3080100-5wv7dgnIgG8@public.gmane.org>
2016-04-13 17:34 ` John Stultz
2016-04-13 17:34 ` John Stultz
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.