All of lore.kernel.org
 help / color / mirror / Atom feed
From: yang.shi@linaro.org (Shi, Yang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Kconfig: make SCHED_MC and SCHED_SMT depend on SMP
Date: Thu, 14 Apr 2016 09:33:07 -0700	[thread overview]
Message-ID: <570FC643.3090805@linaro.org> (raw)
In-Reply-To: <20160414084727.GA23207@arm.com>

On 4/14/2016 1:47 AM, Will Deacon wrote:
> On Wed, Apr 13, 2016 at 05:54:12PM -0700, Yang Shi wrote:
>> SCHED_MC and SCHED_SMT are pointless when SMP is disabled.
>> Although SMP is rarely disabled for ARM64, it looks more consistent to have
>> such depend in Kconfig.
>
> You can't disable CONFIG_SMP for arm64 -- we select it unconditionally
> in the kconfig.

Thanks Will. I didn't realize ARM64 has SMP selected unconditionally, it 
looks the patch is pointless.

A follow-up question, I know ARM64 has no UP implementation now, it 
sounds make sense to have SMP select unconditionally, however, it might 
be more flexible to have SMP like x86 and other architectures. And, it 
may also help to find more bugs when !SMP.

Thanks,
Yang

>
> Will
>

WARNING: multiple messages have this Message-ID (diff)
From: "Shi, Yang" <yang.shi@linaro.org>
To: Will Deacon <will.deacon@arm.com>
Cc: catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] arm64: Kconfig: make SCHED_MC and SCHED_SMT depend on SMP
Date: Thu, 14 Apr 2016 09:33:07 -0700	[thread overview]
Message-ID: <570FC643.3090805@linaro.org> (raw)
In-Reply-To: <20160414084727.GA23207@arm.com>

On 4/14/2016 1:47 AM, Will Deacon wrote:
> On Wed, Apr 13, 2016 at 05:54:12PM -0700, Yang Shi wrote:
>> SCHED_MC and SCHED_SMT are pointless when SMP is disabled.
>> Although SMP is rarely disabled for ARM64, it looks more consistent to have
>> such depend in Kconfig.
>
> You can't disable CONFIG_SMP for arm64 -- we select it unconditionally
> in the kconfig.

Thanks Will. I didn't realize ARM64 has SMP selected unconditionally, it 
looks the patch is pointless.

A follow-up question, I know ARM64 has no UP implementation now, it 
sounds make sense to have SMP select unconditionally, however, it might 
be more flexible to have SMP like x86 and other architectures. And, it 
may also help to find more bugs when !SMP.

Thanks,
Yang

>
> Will
>

  reply	other threads:[~2016-04-14 16:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-14  0:54 [PATCH] arm64: Kconfig: make SCHED_MC and SCHED_SMT depend on SMP Yang Shi
2016-04-14  0:54 ` Yang Shi
2016-04-14  8:47 ` Will Deacon
2016-04-14  8:47   ` Will Deacon
2016-04-14 16:33   ` Shi, Yang [this message]
2016-04-14 16:33     ` Shi, Yang
2016-04-14 16:35     ` Will Deacon
2016-04-14 16:35       ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570FC643.3090805@linaro.org \
    --to=yang.shi@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.