* [PATCH] e2image: don't leak progress info to stdout
@ 2016-04-15 3:20 Eric Sandeen
2016-04-15 15:11 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2016-04-15 3:20 UTC (permalink / raw)
To: linux-ext4@vger.kernel.org; +Cc: Alex Markley
Commit c8ee0d60 fixed most of these, but missed this one.
# e2image -r -p <device> - > imagefile
leads to a corrupted image due to the "Scanning inodes..."
printf going to stdout.
Reported-by: Alex Markley <alex@malexmedia.net>
Addresses-Red-Hat-Bugzilla: #1327329
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
diff --git a/misc/e2image.c b/misc/e2image.c
index e9b4ae2..690ad2c 100644
--- a/misc/e2image.c
+++ b/misc/e2image.c
@@ -1285,7 +1285,7 @@ static void write_raw_image_file(ext2_filsys fs, int fd, int type, int flags)
mark_table_blocks(fs);
if (show_progress)
- printf("%s", _("Scanning inodes...\n"));
+ fprintf(stderr, "%s", _("Scanning inodes...\n"));
retval = ext2fs_open_inode_scan(fs, 0, &scan);
if (retval) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-15 15:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-15 3:20 [PATCH] e2image: don't leak progress info to stdout Eric Sandeen
2016-04-15 15:11 ` Theodore Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.