[meta-fsl-arm][PATCH] imx-kobs: Fix compile error

[meta-fsl-arm][PATCH] imx-kobs: Fix compile error

[Gary Thomas]

Recent compiler updates now require <stdint.h> to use 'uintX_t' types.

Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
 recipes-bsp/imx-kobs/imx-kobs/fix-compile.patch | 15 +++++++++++++++
 recipes-bsp/imx-kobs/imx-kobs_5.3.bb            |  4 +++-
 2 files changed, 18 insertions(+), 1 deletion(-)
 create mode 100644 recipes-bsp/imx-kobs/imx-kobs/fix-compile.patch

diff --git a/recipes-bsp/imx-kobs/imx-kobs/fix-compile.patch b/recipes-bsp/imx-kobs/imx-kobs/fix-compile.patch
new file mode 100644
index 0000000..ca2d675
--- /dev/null
+++ b/recipes-bsp/imx-kobs/imx-kobs/fix-compile.patch
@@ -0,0 +1,15 @@
+This patch fixes a build error with recent compilers (<stdint.h> must
+be explicitly included to get uintX_t types)
+
+Index: imx-kobs-5.3/src/BootControlBlocks.h
+===================================================================
+--- imx-kobs-5.3.orig/src/BootControlBlocks.h
++++ imx-kobs-5.3/src/BootControlBlocks.h
+@@ -54,6 +54,7 @@
+ //! This structure holds the timing for the NAND.  This data is used by
+ //! rom_nand_hal_GpmiSetNandTiming to setup the GPMI hardware registers.
+ 
++#include <stdint.h>
+ typedef struct _NAND_Timing {
+ 	uint8_t m_u8DataSetup;
+ 	uint8_t m_u8DataHold;
diff --git a/recipes-bsp/imx-kobs/imx-kobs_5.3.bb b/recipes-bsp/imx-kobs/imx-kobs_5.3.bb
index ccc4a24..d641cbf 100644
--- a/recipes-bsp/imx-kobs/imx-kobs_5.3.bb
+++ b/recipes-bsp/imx-kobs/imx-kobs_5.3.bb
@@ -5,7 +5,9 @@ SECTION = "base"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=393a5ca445f6965873eca0259a17f833"
 
-SRC_URI = "${FSL_MIRROR}/imx-kobs-${PV}.tar.gz"
+SRC_URI = "${FSL_MIRROR}/imx-kobs-${PV}.tar.gz \
+           file://fix-compile.patch \
+"
 
 SRC_URI[md5sum] = "a2a9e1c3445d14c961577492313a41fb"
 SRC_URI[sha256sum] = "45f729fc2b49556f1ca9df778f52bf5cc749cfe53664c8206daab29991c5f6c1"
-- 
2.5.0

Re: [meta-fsl-arm][PATCH] imx-kobs: Fix compile error

[Gary Bisson]

[-- Attachment #1: Type: text/plain, Size: 636 bytes --]

Gary, All,

On Fri, Apr 15, 2016 at 4:43 AM, Gary Thomas <gary@mlbassoc.com> wrote:

> Recent compiler updates now require <stdint.h> to use 'uintX_t' types.
>

As a FYI, I've made a patch for that in Buildroot:
https://github.com/buildroot/buildroot/blob/master/package/freescale-imx/imx-kobs/0002-Fix-build-for-recent-toolchains.patch

This issue only appears with kernel headers >= 4.4 since mtd-user.h isn't
including stdint.h any more.

Also, for those using musl, another patch is needed:
https://github.com/buildroot/buildroot/blob/master/package/freescale-imx/imx-kobs/0001-Fix-musl-build.patch

Regards,
Gary

[-- Attachment #2: Type: text/html, Size: 1387 bytes --]

Re: [meta-fsl-arm][PATCH] imx-kobs: Fix compile error

[Otavio Salvador]

On Fri, Apr 15, 2016 at 5:43 AM, Gary Bisson
<gary.bisson@boundarydevices.com> wrote:
> Gary, All,
>
> On Fri, Apr 15, 2016 at 4:43 AM, Gary Thomas <gary@mlbassoc.com> wrote:
>>
>> Recent compiler updates now require <stdint.h> to use 'uintX_t' types.
>
>
> As a FYI, I've made a patch for that in Buildroot:
> https://github.com/buildroot/buildroot/blob/master/package/freescale-imx/imx-kobs/0002-Fix-build-for-recent-toolchains.patch
>
> This issue only appears with kernel headers >= 4.4 since mtd-user.h isn't
> including stdint.h any more.
>
> Also, for those using musl, another patch is needed:
> https://github.com/buildroot/buildroot/blob/master/package/freescale-imx/imx-kobs/0001-Fix-musl-build.patch

Great so please rework the commit log to inform about the Kernel
headers >= 4.4, GCC and please prepare another patch to support musl.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm][PATCH] imx-kobs: Fix compile error

[Gary Thomas]

On 2016-04-15 12:37, Otavio Salvador wrote:
> On Fri, Apr 15, 2016 at 5:43 AM, Gary Bisson
> <gary.bisson@boundarydevices.com> wrote:
>> Gary, All,
>>
>> On Fri, Apr 15, 2016 at 4:43 AM, Gary Thomas <gary@mlbassoc.com> wrote:
>>>
>>> Recent compiler updates now require <stdint.h> to use 'uintX_t' types.
>>
>>
>> As a FYI, I've made a patch for that in Buildroot:
>> https://github.com/buildroot/buildroot/blob/master/package/freescale-imx/imx-kobs/0002-Fix-build-for-recent-toolchains.patch
>>
>> This issue only appears with kernel headers >= 4.4 since mtd-user.h isn't
>> including stdint.h any more.
>>
>> Also, for those using musl, another patch is needed:
>> https://github.com/buildroot/buildroot/blob/master/package/freescale-imx/imx-kobs/0001-Fix-musl-build.patch
>
> Great so please rework the commit log to inform about the Kernel
> headers >= 4.4, GCC and please prepare another patch to support musl.
>

New patch sent.  Note that the recipe & version have been updated [today?]

Also, someone else need to respond to the musl change - I'm not qualified
nor do I have time to work on that.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [meta-fsl-arm][PATCH] imx-kobs: Fix compile error

[Otavio Salvador]

On Thu, Apr 14, 2016 at 11:43 PM, Gary Thomas <gary@mlbassoc.com> wrote:
> Recent compiler updates now require <stdint.h> to use 'uintX_t' types.
>
> Signed-off-by: Gary Thomas <gary@mlbassoc.com>

I think it could be reworked to, in short log, cite GCC 5.

imx-kobs: Fix compile error with GCC 5

This patch fixes a build error with recent compilers (<stdint.h> must
be explicitly included to get uintX_t types)

Signed-off-by:...

> ---
>  recipes-bsp/imx-kobs/imx-kobs/fix-compile.patch | 15 +++++++++++++++
>  recipes-bsp/imx-kobs/imx-kobs_5.3.bb            |  4 +++-
>  2 files changed, 18 insertions(+), 1 deletion(-)
>  create mode 100644 recipes-bsp/imx-kobs/imx-kobs/fix-compile.patch
>
> diff --git a/recipes-bsp/imx-kobs/imx-kobs/fix-compile.patch b/recipes-bsp/imx-kobs/imx-kobs/fix-compile.patch
> new file mode 100644
> index 0000000..ca2d675
> --- /dev/null
> +++ b/recipes-bsp/imx-kobs/imx-kobs/fix-compile.patch
> @@ -0,0 +1,15 @@
> +This patch fixes a build error with recent compilers (<stdint.h> must
> +be explicitly included to get uintX_t types)
> +

Upstream-Status: Pending

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750