All of lore.kernel.org
 help / color / mirror / Atom feed
From: david@lechnology.com (David Lechner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: DTS: da850: add node for spi0
Date: Fri, 15 Apr 2016 11:17:55 -0500	[thread overview]
Message-ID: <57111433.6080402@lechnology.com> (raw)
In-Reply-To: <5710C176.3040304@ti.com>

On 04/15/2016 05:24 AM, Sekhar Nori wrote:

>
> This made me notice that num-cs is populated wrongly for spi1. It
> actually has 8 chip selects. This is fine though.

I might as well fix it since I have to make changes anyway. Don't 
remember how I came up with 6.

>
> Also, it will be nice to add pinctrl entries for spi0 like it is done
> for spi1. You will need those anyway for using the interface.

I omitted this on purpose. For my use case, I am using the SPI as 
write-only, so not using the SOMI pin, which is actually muxed as a GPIO 
for something else. So having a pinctl like spi1 is of no use to me. I 
figured if someone needs it, they can add it, otherwise it just is 
wasted space to me.
>
> I prefer DT updates are patches of their own and not combined with code
> updates like this. Can you please split this up?

Ack.

WARNING: multiple messages have this Message-ID (diff)
From: David Lechner <david@lechnology.com>
To: Sekhar Nori <nsekhar@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>,
	Kevin Hilman <khilman@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: DTS: da850: add node for spi0
Date: Fri, 15 Apr 2016 11:17:55 -0500	[thread overview]
Message-ID: <57111433.6080402@lechnology.com> (raw)
In-Reply-To: <5710C176.3040304@ti.com>

On 04/15/2016 05:24 AM, Sekhar Nori wrote:

>
> This made me notice that num-cs is populated wrongly for spi1. It
> actually has 8 chip selects. This is fine though.

I might as well fix it since I have to make changes anyway. Don't 
remember how I came up with 6.

>
> Also, it will be nice to add pinctrl entries for spi0 like it is done
> for spi1. You will need those anyway for using the interface.

I omitted this on purpose. For my use case, I am using the SPI as 
write-only, so not using the SOMI pin, which is actually muxed as a GPIO 
for something else. So having a pinctl like spi1 is of no use to me. I 
figured if someone needs it, they can add it, otherwise it just is 
wasted space to me.
>
> I prefer DT updates are patches of their own and not combined with code
> updates like this. Can you please split this up?

Ack.

  reply	other threads:[~2016-04-15 16:17 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13 22:30 [PATCH 0/3] More small davinci device tree fixes David Lechner
2016-04-13 22:30 ` David Lechner
2016-04-13 22:30 ` [PATCH 1/3] ARM: DTS: da850: add node for spi0 David Lechner
2016-04-13 22:30   ` David Lechner
2016-04-15 10:24   ` Sekhar Nori
2016-04-15 10:24     ` Sekhar Nori
2016-04-15 10:24     ` Sekhar Nori
2016-04-15 16:17     ` David Lechner [this message]
2016-04-15 16:17       ` David Lechner
2016-04-15 20:16       ` Valdis.Kletnieks at vt.edu
2016-04-15 20:16         ` Valdis.Kletnieks
2016-04-15 20:16         ` Valdis.Kletnieks-PjAqaU27lzQ
2016-04-15 21:20         ` David Lechner
2016-04-15 21:20           ` David Lechner
2016-04-15 21:20           ` David Lechner
2016-04-18  5:55       ` Sekhar Nori
2016-04-18  5:55         ` Sekhar Nori
2016-04-18  5:55         ` Sekhar Nori
2016-04-13 22:30 ` [PATCH 2/3] ARM: DTS: da850: disable mdio and eth0 by default David Lechner
2016-04-13 22:30   ` David Lechner
2016-04-13 22:30   ` David Lechner
2016-04-15 10:25   ` Sekhar Nori
2016-04-15 10:25     ` Sekhar Nori
2016-04-15 10:25     ` Sekhar Nori
2016-04-13 22:30 ` [PATCH 3/3] ARM: DTS: da850: There are 101 interrupts David Lechner
2016-04-13 22:30   ` David Lechner
2016-04-15 10:26   ` Sekhar Nori
2016-04-15 10:26     ` Sekhar Nori
2016-04-15 10:26     ` Sekhar Nori
2016-04-14 22:20 ` [PATCH 0/3] More small davinci device tree fixes Kevin Hilman
2016-04-14 22:20   ` Kevin Hilman
2016-04-14 22:20   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57111433.6080402@lechnology.com \
    --to=david@lechnology.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.