From: Jonathan Cameron <jic23@kernel.org>
To: Slawomir Stepien <sst@poczta.fm>,
lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de,
pmeerw@pmeerw.net
Cc: linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iio: frequency: ad9523: use unsigned int rather then bare unsigned
Date: Sun, 17 Apr 2016 09:31:32 +0000 [thread overview]
Message-ID: <571357F4.8060401@kernel.org> (raw)
In-Reply-To: <20160414154024.GA16253@x220.localdomain>
On 14/04/16 16:40, Slawomir Stepien wrote:
> This fix checkpatch warnings:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
Applied to the togreg branch of iio.git
Thanks,
Jonathan
> ---
> drivers/iio/frequency/ad9523.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c
> index 44a30f2..99eba52 100644
> --- a/drivers/iio/frequency/ad9523.c
> +++ b/drivers/iio/frequency/ad9523.c
> @@ -284,7 +284,7 @@ struct ad9523_state {
> } data[2] ____cacheline_aligned;
> };
>
> -static int ad9523_read(struct iio_dev *indio_dev, unsigned addr)
> +static int ad9523_read(struct iio_dev *indio_dev, unsigned int addr)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> int ret;
> @@ -318,7 +318,8 @@ static int ad9523_read(struct iio_dev *indio_dev, unsigned addr)
> return ret;
> };
>
> -static int ad9523_write(struct iio_dev *indio_dev, unsigned addr, unsigned val)
> +static int ad9523_write(struct iio_dev *indio_dev,
> + unsigned int addr, unsigned int val)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> int ret;
> @@ -351,11 +352,11 @@ static int ad9523_io_update(struct iio_dev *indio_dev)
> }
>
> static int ad9523_vco_out_map(struct iio_dev *indio_dev,
> - unsigned ch, unsigned out)
> + unsigned int ch, unsigned int out)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> int ret;
> - unsigned mask;
> + unsigned int mask;
>
> switch (ch) {
> case 0 ... 3:
> @@ -405,7 +406,7 @@ static int ad9523_vco_out_map(struct iio_dev *indio_dev,
> }
>
> static int ad9523_set_clock_provider(struct iio_dev *indio_dev,
> - unsigned ch, unsigned long freq)
> + unsigned int ch, unsigned long freq)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> long tmp1, tmp2;
> @@ -619,7 +620,7 @@ static int ad9523_read_raw(struct iio_dev *indio_dev,
> long m)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> - unsigned code;
> + unsigned int code;
> int ret;
>
> mutex_lock(&indio_dev->mlock);
> @@ -655,7 +656,7 @@ static int ad9523_write_raw(struct iio_dev *indio_dev,
> long mask)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> - unsigned reg;
> + unsigned int reg;
> int ret, tmp, code;
>
> mutex_lock(&indio_dev->mlock);
> @@ -709,8 +710,8 @@ out:
> }
>
> static int ad9523_reg_access(struct iio_dev *indio_dev,
> - unsigned reg, unsigned writeval,
> - unsigned *readval)
> + unsigned int reg, unsigned int writeval,
> + unsigned int *readval)
> {
> int ret;
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Slawomir Stepien <sst@poczta.fm>,
lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de,
pmeerw@pmeerw.net
Cc: linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iio: frequency: ad9523: use unsigned int rather then bare unsigned
Date: Sun, 17 Apr 2016 10:31:32 +0100 [thread overview]
Message-ID: <571357F4.8060401@kernel.org> (raw)
In-Reply-To: <20160414154024.GA16253@x220.localdomain>
On 14/04/16 16:40, Slawomir Stepien wrote:
> This fix checkpatch warnings:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
Applied to the togreg branch of iio.git
Thanks,
Jonathan
> ---
> drivers/iio/frequency/ad9523.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c
> index 44a30f2..99eba52 100644
> --- a/drivers/iio/frequency/ad9523.c
> +++ b/drivers/iio/frequency/ad9523.c
> @@ -284,7 +284,7 @@ struct ad9523_state {
> } data[2] ____cacheline_aligned;
> };
>
> -static int ad9523_read(struct iio_dev *indio_dev, unsigned addr)
> +static int ad9523_read(struct iio_dev *indio_dev, unsigned int addr)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> int ret;
> @@ -318,7 +318,8 @@ static int ad9523_read(struct iio_dev *indio_dev, unsigned addr)
> return ret;
> };
>
> -static int ad9523_write(struct iio_dev *indio_dev, unsigned addr, unsigned val)
> +static int ad9523_write(struct iio_dev *indio_dev,
> + unsigned int addr, unsigned int val)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> int ret;
> @@ -351,11 +352,11 @@ static int ad9523_io_update(struct iio_dev *indio_dev)
> }
>
> static int ad9523_vco_out_map(struct iio_dev *indio_dev,
> - unsigned ch, unsigned out)
> + unsigned int ch, unsigned int out)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> int ret;
> - unsigned mask;
> + unsigned int mask;
>
> switch (ch) {
> case 0 ... 3:
> @@ -405,7 +406,7 @@ static int ad9523_vco_out_map(struct iio_dev *indio_dev,
> }
>
> static int ad9523_set_clock_provider(struct iio_dev *indio_dev,
> - unsigned ch, unsigned long freq)
> + unsigned int ch, unsigned long freq)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> long tmp1, tmp2;
> @@ -619,7 +620,7 @@ static int ad9523_read_raw(struct iio_dev *indio_dev,
> long m)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> - unsigned code;
> + unsigned int code;
> int ret;
>
> mutex_lock(&indio_dev->mlock);
> @@ -655,7 +656,7 @@ static int ad9523_write_raw(struct iio_dev *indio_dev,
> long mask)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> - unsigned reg;
> + unsigned int reg;
> int ret, tmp, code;
>
> mutex_lock(&indio_dev->mlock);
> @@ -709,8 +710,8 @@ out:
> }
>
> static int ad9523_reg_access(struct iio_dev *indio_dev,
> - unsigned reg, unsigned writeval,
> - unsigned *readval)
> + unsigned int reg, unsigned int writeval,
> + unsigned int *readval)
> {
> int ret;
>
>
next prev parent reply other threads:[~2016-04-17 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 15:40 [PATCH] iio: frequency: ad9523: use unsigned int rather then bare unsigned Slawomir Stepien
2016-04-14 15:40 ` Slawomir Stepien
2016-04-17 9:31 ` Jonathan Cameron [this message]
2016-04-17 9:31 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571357F4.8060401@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=sst@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.