All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willem Jan Withagen <wjw@digiware.nl>
To: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Some testprograms are no longer runable from CLI???
Date: Sun, 17 Apr 2016 21:52:29 +0200	[thread overview]
Message-ID: <5713E97D.20609@digiware.nl> (raw)

As far as Ik can tell this is due to:
https://github.com/ceph/ceph/commit/1c8cd003600953ee1f469fc91be1b0cc4b4f7fa7

Author: Ali Maredia <amaredia@redhat.com>
Date:   Wed Jan 13 14:40:22 2016 -0500

     cmake: erasure-code tests passing

     Replaced relative paths in test-erausure-eio.sh
     test-erasure-code.sh, and replaced .libs in
     erasure_code unittests with CEPH_VAR environment
     variables set in cmake.

     Signed-off-by: Ali Maredia <amaredia@redhat.com>

=============

Lots of scripts now contain the header:
source $CEPH_ROOT/qa/workunits/ceph-helpers.sh

Which was uptill this commit not required to be set.

As far as I can tell other "required" Shell varaibles might be:

../cmake/modules/AddCephTest.cmake:    CEPH_ROOT=${CMAKE_SOURCE_DIR}
../cmake/modules/AddCephTest.cmake: 
CEPH_BIN=${CMAKE_RUNTIME_OUTPUT_DIRECTORY}
../cmake/modules/AddCephTest.cmake: 
CEPH_LIB=${CMAKE_LIBRARY_OUTPUT_DIRECTORY}
../cmake/modules/AddCephTest.cmake:    CEPH_BUILD_DIR=${CMAKE_BINARY_DIR}

It would be nice that if these variables are not set, it is still 
possible to
run the tests from the commandline due to setting defaults to values 
that it had
before these Cmake changes were introducded.

Something like
====
C_ROOT=${CEPH_ROOT:-.}
source $CEPH_ROOT/qa/workunits/ceph-helpers.sh
====
would help quite a bit, and keep things backwards compatible.

Thanx,
--WjW



             reply	other threads:[~2016-04-17 21:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-17 19:52 Willem Jan Withagen [this message]
2016-04-18 18:48 ` Some testprograms are no longer runable from CLI??? Gregory Farnum
2016-04-18 21:58   ` Ali Maredia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5713E97D.20609@digiware.nl \
    --to=wjw@digiware.nl \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.