Some testprograms are no longer runable from CLI???

Some testprograms are no longer runable from CLI???

[Willem Jan Withagen]

As far as Ik can tell this is due to:
https://github.com/ceph/ceph/commit/1c8cd003600953ee1f469fc91be1b0cc4b4f7fa7

Author: Ali Maredia <amaredia@redhat.com>
Date:   Wed Jan 13 14:40:22 2016 -0500

     cmake: erasure-code tests passing

     Replaced relative paths in test-erausure-eio.sh
     test-erasure-code.sh, and replaced .libs in
     erasure_code unittests with CEPH_VAR environment
     variables set in cmake.

     Signed-off-by: Ali Maredia <amaredia@redhat.com>

=============

Lots of scripts now contain the header:
source $CEPH_ROOT/qa/workunits/ceph-helpers.sh

Which was uptill this commit not required to be set.

As far as I can tell other "required" Shell varaibles might be:

../cmake/modules/AddCephTest.cmake:    CEPH_ROOT=${CMAKE_SOURCE_DIR}
../cmake/modules/AddCephTest.cmake: 
CEPH_BIN=${CMAKE_RUNTIME_OUTPUT_DIRECTORY}
../cmake/modules/AddCephTest.cmake: 
CEPH_LIB=${CMAKE_LIBRARY_OUTPUT_DIRECTORY}
../cmake/modules/AddCephTest.cmake:    CEPH_BUILD_DIR=${CMAKE_BINARY_DIR}

It would be nice that if these variables are not set, it is still 
possible to
run the tests from the commandline due to setting defaults to values 
that it had
before these Cmake changes were introducded.

Something like
====
C_ROOT=${CEPH_ROOT:-.}
source $CEPH_ROOT/qa/workunits/ceph-helpers.sh
====
would help quite a bit, and keep things backwards compatible.

Thanx,
--WjW

Re: Some testprograms are no longer runable from CLI???

[Gregory Farnum]

On Sun, Apr 17, 2016 at 12:52 PM, Willem Jan Withagen <wjw@digiware.nl> wrote:
> As far as Ik can tell this is due to:
> https://github.com/ceph/ceph/commit/1c8cd003600953ee1f469fc91be1b0cc4b4f7fa7
>
> Author: Ali Maredia <amaredia@redhat.com>
> Date:   Wed Jan 13 14:40:22 2016 -0500
>
>     cmake: erasure-code tests passing
>
>     Replaced relative paths in test-erausure-eio.sh
>     test-erasure-code.sh, and replaced .libs in
>     erasure_code unittests with CEPH_VAR environment
>     variables set in cmake.
>
>     Signed-off-by: Ali Maredia <amaredia@redhat.com>
>
> =============
>
> Lots of scripts now contain the header:
> source $CEPH_ROOT/qa/workunits/ceph-helpers.sh
>
> Which was uptill this commit not required to be set.
>
> As far as I can tell other "required" Shell varaibles might be:
>
> ../cmake/modules/AddCephTest.cmake:    CEPH_ROOT=${CMAKE_SOURCE_DIR}
> ../cmake/modules/AddCephTest.cmake:
> CEPH_BIN=${CMAKE_RUNTIME_OUTPUT_DIRECTORY}
> ../cmake/modules/AddCephTest.cmake:
> CEPH_LIB=${CMAKE_LIBRARY_OUTPUT_DIRECTORY}
> ../cmake/modules/AddCephTest.cmake:    CEPH_BUILD_DIR=${CMAKE_BINARY_DIR}
>
> It would be nice that if these variables are not set, it is still possible
> to
> run the tests from the commandline due to setting defaults to values that it
> had
> before these Cmake changes were introducded.
>
> Something like
> ====
> C_ROOT=${CEPH_ROOT:-.}
> source $CEPH_ROOT/qa/workunits/ceph-helpers.sh
> ====
> would help quite a bit, and keep things backwards compatible.

Yes please, test binaries should be runnable on their own without
going through "make check" or whatever!
-Greg

>
> Thanx,
> --WjW
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Some testprograms are no longer runable from CLI???

[Ali Maredia]

I'm working on a fix for this, please see the email I just sent to ceph-devel for more information.

-Ali

----- Original Message -----
From: "Gregory Farnum" <gfarnum@redhat.com>
To: "Willem Jan Withagen" <wjw@digiware.nl>, "Ali Maredia" <amaredia@redhat.com>
Cc: "Ceph Development" <ceph-devel@vger.kernel.org>
Sent: Monday, April 18, 2016 2:48:32 PM
Subject: Re: Some testprograms are no longer runable from CLI???

On Sun, Apr 17, 2016 at 12:52 PM, Willem Jan Withagen <wjw@digiware.nl> wrote:
> As far as Ik can tell this is due to:
> https://github.com/ceph/ceph/commit/1c8cd003600953ee1f469fc91be1b0cc4b4f7fa7
>
> Author: Ali Maredia <amaredia@redhat.com>
> Date:   Wed Jan 13 14:40:22 2016 -0500
>
>     cmake: erasure-code tests passing
>
>     Replaced relative paths in test-erausure-eio.sh
>     test-erasure-code.sh, and replaced .libs in
>     erasure_code unittests with CEPH_VAR environment
>     variables set in cmake.
>
>     Signed-off-by: Ali Maredia <amaredia@redhat.com>
>
> =============
>
> Lots of scripts now contain the header:
> source $CEPH_ROOT/qa/workunits/ceph-helpers.sh
>
> Which was uptill this commit not required to be set.
>
> As far as I can tell other "required" Shell varaibles might be:
>
> ../cmake/modules/AddCephTest.cmake:    CEPH_ROOT=${CMAKE_SOURCE_DIR}
> ../cmake/modules/AddCephTest.cmake:
> CEPH_BIN=${CMAKE_RUNTIME_OUTPUT_DIRECTORY}
> ../cmake/modules/AddCephTest.cmake:
> CEPH_LIB=${CMAKE_LIBRARY_OUTPUT_DIRECTORY}
> ../cmake/modules/AddCephTest.cmake:    CEPH_BUILD_DIR=${CMAKE_BINARY_DIR}
>
> It would be nice that if these variables are not set, it is still possible
> to
> run the tests from the commandline due to setting defaults to values that it
> had
> before these Cmake changes were introducded.
>
> Something like
> ====
> C_ROOT=${CEPH_ROOT:-.}
> source $CEPH_ROOT/qa/workunits/ceph-helpers.sh
> ====
> would help quite a bit, and keep things backwards compatible.

Yes please, test binaries should be runnable on their own without
going through "make check" or whatever!
-Greg

>
> Thanx,
> --WjW
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html