From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: davinci: da850: use clk->set_parent for async3
Date: Mon, 18 Apr 2016 10:25:48 +0530 [thread overview]
Message-ID: <571468D4.3090805@ti.com> (raw)
In-Reply-To: <5712930F.7000902@lechnology.com>
On Sunday 17 April 2016 01:01 AM, David Lechner wrote:
>> +static int da850_async3_set_parent(struct clk *clk, struct clk *parent)
>> +{
>> + u32 val;
>> +
>> + val = readl(DA8XX_SYSCFG0_VIRT(DA8XX_CFGCHIP3_REG));
>> +
>> + /* Set the USB 1.1 PHY clock mux based on the parent clock. */
>
> I seem to have regressed here since the last revision, this is supposed
> to read:
>
> /* Set the async3 clock domain mux based on the parent clock. */
>
> Although now that I am looking at it again, it doesn't really add
> anything useful and could be omitted altogether.
Agree the comment is redundant. No need resend just for this though. I
can drop it when applying.
Thanks,
Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: David Lechner <david@lechnology.com>
Cc: Kevin Hilman <khilman@kernel.org>,
Russell King <linux@arm.linux.org.uk>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ARM: davinci: da850: use clk->set_parent for async3
Date: Mon, 18 Apr 2016 10:25:48 +0530 [thread overview]
Message-ID: <571468D4.3090805@ti.com> (raw)
In-Reply-To: <5712930F.7000902@lechnology.com>
On Sunday 17 April 2016 01:01 AM, David Lechner wrote:
>> +static int da850_async3_set_parent(struct clk *clk, struct clk *parent)
>> +{
>> + u32 val;
>> +
>> + val = readl(DA8XX_SYSCFG0_VIRT(DA8XX_CFGCHIP3_REG));
>> +
>> + /* Set the USB 1.1 PHY clock mux based on the parent clock. */
>
> I seem to have regressed here since the last revision, this is supposed
> to read:
>
> /* Set the async3 clock domain mux based on the parent clock. */
>
> Although now that I am looking at it again, it doesn't really add
> anything useful and could be omitted altogether.
Agree the comment is redundant. No need resend just for this though. I
can drop it when applying.
Thanks,
Sekhar
next prev parent reply other threads:[~2016-04-18 4:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 19:13 [PATCH 0/2] da8xx clocks (was part of "da8xx USB clocks") David Lechner
2016-04-14 19:13 ` David Lechner
2016-04-14 19:13 ` [PATCH 1/2] ARM: davinci: Move clock init after ioremap David Lechner
2016-04-14 19:13 ` David Lechner
2016-04-14 19:13 ` [PATCH 2/2] ARM: davinci: da850: use clk->set_parent for async3 David Lechner
2016-04-14 19:13 ` David Lechner
2016-04-16 19:31 ` David Lechner
2016-04-16 19:31 ` David Lechner
2016-04-18 4:55 ` Sekhar Nori [this message]
2016-04-18 4:55 ` Sekhar Nori
2016-04-14 19:26 ` [PATCH 0/2] da8xx clocks (was part of "da8xx USB clocks") David Lechner
2016-04-14 19:26 ` David Lechner
2016-04-15 6:36 ` Sekhar Nori
2016-04-15 6:36 ` Sekhar Nori
2016-04-15 10:09 ` Sekhar Nori
2016-04-15 10:09 ` Sekhar Nori
2016-04-15 16:21 ` David Lechner
2016-04-15 16:21 ` David Lechner
2016-04-27 13:39 ` Sekhar Nori
2016-04-27 13:39 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571468D4.3090805@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.