From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>, linus.walleij@linaro.org
Cc: gnurou@gmail.com, thierry.reding@gmail.com,
linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver
Date: Mon, 18 Apr 2016 10:29:53 -0600 [thread overview]
Message-ID: <57150B81.6040104@wwwdotorg.org> (raw)
In-Reply-To: <1460969178-20914-2-git-send-email-ldewangan@nvidia.com>
On 04/18/2016 02:46 AM, Laxman Dewangan wrote:
> Remove the file static device handle variable as this is just
> required for prints. The required handle can be stored in
> tegra_gpio_chip and hence it become redundancy.
This seems fine as far as it goes, but if it's worth doing this, please
move all the globals into the GPIO chip rather than just one of the 7
globals.
next prev parent reply other threads:[~2016-04-18 16:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 8:46 [PATCH 1/3] gpio: tegra: Don't open code of_device_get_match_data() Laxman Dewangan
2016-04-18 8:46 ` Laxman Dewangan
2016-04-18 8:46 ` [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver Laxman Dewangan
2016-04-18 8:46 ` Laxman Dewangan
2016-04-18 16:29 ` Stephen Warren [this message]
[not found] ` <57150B81.6040104-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-04-18 17:00 ` Laxman Dewangan
2016-04-18 17:00 ` Laxman Dewangan
2016-04-19 15:58 ` Stephen Warren
2016-04-20 1:16 ` Alexandre Courbot
2016-04-18 8:46 ` [PATCH 3/3] gpio: tegra: Add support for gpio debounce Laxman Dewangan
2016-04-18 8:46 ` Laxman Dewangan
[not found] ` <1460969178-20914-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-18 16:38 ` Stephen Warren
2016-04-18 16:38 ` Stephen Warren
2016-04-18 17:06 ` Laxman Dewangan
2016-04-18 17:06 ` Laxman Dewangan
2016-04-19 16:01 ` Stephen Warren
2016-04-18 16:29 ` [PATCH 1/3] gpio: tegra: Don't open code of_device_get_match_data() Stephen Warren
[not found] ` <1460969178-20914-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-20 0:56 ` Alexandre Courbot
2016-04-20 0:56 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57150B81.6040104@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=gnurou@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.