From: tthayer@opensource.altera.com (Thor Thayer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.
Date: Mon, 18 Apr 2016 15:25:56 -0500 [thread overview]
Message-ID: <571542D4.1030409@opensource.altera.com> (raw)
In-Reply-To: <20160418200637.GB2057@cz.tnic>
On 04/18/2016 03:06 PM, Borislav Petkov wrote:
> On Mon, Apr 18, 2016 at 10:02:27PM +0200, Borislav Petkov wrote:
>>> the number of uncorrectable errors is useful from a system point of
>>> view.
>
> I forgot: so altr_edac_a10_ecc_irq() panics on uncorrectable errors. Do we want
> to do that even for UEs coming from the network...?
>
> Seems a bit overboard to me...
>
Yes, as currently submitted, it is overboard and I'll fix this in the
next patch submission. In the uncorrectable error case, I plan to just
count the error. I'll add a constant flag in the Ethernet module's
edac_device_prv_data to determine if the panic should be bypassed.
WARNING: multiple messages have this Message-ID (diff)
From: Thor Thayer <tthayer@opensource.altera.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
Rob Herring <robh@kernel.org>,
dougthompson@xmission.com, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, linux@arm.linux.org.uk,
dinguyen@opensource.altera.com, grant.likely@linaro.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, tthayer.linux@gmail.com
Subject: Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.
Date: Mon, 18 Apr 2016 15:25:56 -0500 [thread overview]
Message-ID: <571542D4.1030409@opensource.altera.com> (raw)
In-Reply-To: <20160418200637.GB2057@cz.tnic>
On 04/18/2016 03:06 PM, Borislav Petkov wrote:
> On Mon, Apr 18, 2016 at 10:02:27PM +0200, Borislav Petkov wrote:
>>> the number of uncorrectable errors is useful from a system point of
>>> view.
>
> I forgot: so altr_edac_a10_ecc_irq() panics on uncorrectable errors. Do we want
> to do that even for UEs coming from the network...?
>
> Seems a bit overboard to me...
>
Yes, as currently submitted, it is overboard and I'll fix this in the
next patch submission. In the uncorrectable error case, I plan to just
count the error. I'll add a constant flag in the Ethernet module's
edac_device_prv_data to determine if the panic should be bypassed.
WARNING: multiple messages have this Message-ID (diff)
From: Thor Thayer <tthayer@opensource.altera.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
Rob Herring <robh@kernel.org>, <dougthompson@xmission.com>,
<pawel.moll@arm.com>, <mark.rutland@arm.com>,
<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
<linux@arm.linux.org.uk>, <dinguyen@opensource.altera.com>,
<grant.likely@linaro.org>, <devicetree@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linux-edac@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <tthayer.linux@gmail.com>
Subject: Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.
Date: Mon, 18 Apr 2016 15:25:56 -0500 [thread overview]
Message-ID: <571542D4.1030409@opensource.altera.com> (raw)
In-Reply-To: <20160418200637.GB2057@cz.tnic>
On 04/18/2016 03:06 PM, Borislav Petkov wrote:
> On Mon, Apr 18, 2016 at 10:02:27PM +0200, Borislav Petkov wrote:
>>> the number of uncorrectable errors is useful from a system point of
>>> view.
>
> I forgot: so altr_edac_a10_ecc_irq() panics on uncorrectable errors. Do we want
> to do that even for UEs coming from the network...?
>
> Seems a bit overboard to me...
>
Yes, as currently submitted, it is overboard and I'll fix this in the
next patch submission. In the uncorrectable error case, I plan to just
count the error. I'll add a constant flag in the Ethernet module's
edac_device_prv_data to determine if the panic should be bypassed.
next prev parent reply other threads:[~2016-04-18 20:25 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 22:12 [PATCH] Add EDAC peripheral init functions & Ethernet EDAC tthayer at opensource.altera.com
2016-04-12 22:12 ` tthayer
2016-04-12 22:12 ` tthayer
2016-04-12 22:12 ` [PATCH 1/6] EDAC, altera: Check parent status for Arria10 EDAC block tthayer at opensource.altera.com
2016-04-12 22:12 ` tthayer
2016-04-12 22:12 ` tthayer
2016-04-12 22:12 ` [PATCH 2/6] EDAC, altera: Move IRQ function declaration tthayer at opensource.altera.com
2016-04-12 22:12 ` tthayer
2016-04-12 22:12 ` tthayer
2016-04-12 22:12 ` [PATCH 3/6] EDAC, altera: Add Arria10 ECC memory init functions tthayer at opensource.altera.com
2016-04-12 22:12 ` tthayer
2016-04-12 22:12 ` tthayer
2016-04-12 22:12 ` [PATCH 4/6] Documentation: dt: socfpga: Add Arria10 Ethernet binding tthayer at opensource.altera.com
2016-04-12 22:12 ` tthayer
2016-04-12 22:12 ` tthayer
2016-04-12 22:13 ` [PATCH 5/6] EDAC, altera: Add Arria10 Ethernet EDAC support tthayer at opensource.altera.com
2016-04-12 22:13 ` tthayer
2016-04-12 22:13 ` tthayer
2016-04-12 22:13 ` [PATCH 6/6] ARM: dts: Add Arria10 Ethernet EDAC devicetree entry tthayer at opensource.altera.com
2016-04-12 22:13 ` tthayer
2016-04-12 22:13 ` tthayer
2016-04-14 14:35 ` [PATCH] Add EDAC peripheral init functions & Ethernet EDAC Rob Herring
2016-04-14 14:35 ` Rob Herring
2016-04-15 9:40 ` Mauro Carvalho Chehab
2016-04-15 9:40 ` Mauro Carvalho Chehab
2016-04-15 9:40 ` Mauro Carvalho Chehab
2016-04-15 15:27 ` Thor Thayer
2016-04-15 15:27 ` Thor Thayer
2016-04-15 15:27 ` Thor Thayer
2016-04-15 21:46 ` Borislav Petkov
2016-04-15 21:46 ` Borislav Petkov
2016-04-18 14:27 ` Thor Thayer
2016-04-18 14:27 ` Thor Thayer
2016-04-18 14:27 ` Thor Thayer
2016-04-18 20:02 ` Borislav Petkov
2016-04-18 20:02 ` Borislav Petkov
2016-04-18 20:06 ` Borislav Petkov
2016-04-18 20:06 ` Borislav Petkov
2016-04-18 20:25 ` Thor Thayer [this message]
2016-04-18 20:25 ` Thor Thayer
2016-04-18 20:25 ` Thor Thayer
2016-04-18 20:15 ` Thor Thayer
2016-04-18 20:15 ` Thor Thayer
2016-04-18 20:15 ` Thor Thayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571542D4.1030409@opensource.altera.com \
--to=tthayer@opensource.altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.