From: Suzuki.Poulose@arm.com (Suzuki K Poulose)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 08/15] coresight: tmc: getting the right read_count on tmc_open()
Date: Tue, 19 Apr 2016 14:07:08 +0100 [thread overview]
Message-ID: <57162D7C.7040003@arm.com> (raw)
In-Reply-To: <1460483692-25061-9-git-send-email-mathieu.poirier@linaro.org>
On 12/04/16 18:54, Mathieu Poirier wrote:
> In function tmc_open(), if tmc_read_prepare() fails variable
> drvdata->read_count is not decremented, causing unwanted
> access to drvdata->buf and very likely, a crash dump.
>
> By moving the incrementation to a place where we know things
> are stable this kind of situation is avoided.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Suzuki K Poulose <Suzuki.Poulose@arm.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 08/15] coresight: tmc: getting the right read_count on tmc_open()
Date: Tue, 19 Apr 2016 14:07:08 +0100 [thread overview]
Message-ID: <57162D7C.7040003@arm.com> (raw)
In-Reply-To: <1460483692-25061-9-git-send-email-mathieu.poirier@linaro.org>
On 12/04/16 18:54, Mathieu Poirier wrote:
> In function tmc_open(), if tmc_read_prepare() fails variable
> drvdata->read_count is not decremented, causing unwanted
> access to drvdata->buf and very likely, a crash dump.
>
> By moving the incrementation to a place where we know things
> are stable this kind of situation is avoided.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
next prev parent reply other threads:[~2016-04-19 13:07 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 17:54 [PATCH V2 00/15] coresight: tmc: make driver usable by Perf Mathieu Poirier
2016-04-12 17:54 ` Mathieu Poirier
2016-04-12 17:54 ` [PATCH V2 01/15] coresight: tmc: modifying naming convention Mathieu Poirier
2016-04-12 17:54 ` Mathieu Poirier
2016-04-14 17:01 ` Suzuki K Poulose
2016-04-14 17:01 ` Suzuki K Poulose
2016-04-12 17:54 ` [PATCH V2 02/15] coresight: tmc: waiting for TMCReady bit before programming Mathieu Poirier
2016-04-12 17:54 ` Mathieu Poirier
2016-04-14 17:05 ` Suzuki K Poulose
2016-04-14 17:05 ` Suzuki K Poulose
2016-04-12 17:54 ` [PATCH V2 03/15] coresight: tmc: re-implementing tmc_read_prepare/unprepare() functions Mathieu Poirier
2016-04-12 17:54 ` Mathieu Poirier
2016-04-14 17:11 ` Suzuki K Poulose
2016-04-14 17:11 ` Suzuki K Poulose
2016-04-15 15:40 ` Mathieu Poirier
2016-04-15 15:40 ` Mathieu Poirier
2016-04-15 17:41 ` Suzuki K Poulose
2016-04-15 17:41 ` Suzuki K Poulose
2016-04-12 17:54 ` [PATCH V2 04/15] coresight: tmc: introducing new header file Mathieu Poirier
2016-04-12 17:54 ` Mathieu Poirier
2016-04-14 17:33 ` Suzuki K Poulose
2016-04-14 17:33 ` Suzuki K Poulose
2016-04-15 16:03 ` Mathieu Poirier
2016-04-15 16:03 ` Mathieu Poirier
2016-04-15 16:08 ` Suzuki K Poulose
2016-04-15 16:08 ` Suzuki K Poulose
2016-04-15 16:15 ` Mathieu Poirier
2016-04-15 16:15 ` Mathieu Poirier
2016-04-15 16:18 ` Suzuki K Poulose
2016-04-15 16:18 ` Suzuki K Poulose
2016-04-12 17:54 ` [PATCH V2 05/15] coresight: tmc: splitting driver in ETB/ETF and ETR components Mathieu Poirier
2016-04-12 17:54 ` Mathieu Poirier
2016-04-19 12:20 ` Suzuki K Poulose
2016-04-19 12:20 ` Suzuki K Poulose
2016-04-19 15:14 ` Mathieu Poirier
2016-04-19 15:14 ` Mathieu Poirier
2016-04-12 17:54 ` [PATCH V2 06/15] coresight: tmc: making prepare/unprepare functions generic Mathieu Poirier
2016-04-12 17:54 ` Mathieu Poirier
2016-04-19 12:30 ` Suzuki K Poulose
2016-04-19 12:30 ` Suzuki K Poulose
2016-04-19 15:22 ` Mathieu Poirier
2016-04-19 15:22 ` Mathieu Poirier
2016-04-19 15:32 ` Suzuki K Poulose
2016-04-19 15:32 ` Suzuki K Poulose
2016-04-12 17:54 ` [PATCH V2 07/15] coresight: tmc: allocating memory when needed Mathieu Poirier
2016-04-12 17:54 ` Mathieu Poirier
2016-04-19 12:55 ` Suzuki K Poulose
2016-04-19 12:55 ` Suzuki K Poulose
2016-04-19 13:14 ` Suzuki K Poulose
2016-04-19 13:14 ` Suzuki K Poulose
2016-04-19 15:39 ` Mathieu Poirier
2016-04-19 15:39 ` Mathieu Poirier
2016-04-12 17:54 ` [PATCH V2 08/15] coresight: tmc: getting the right read_count on tmc_open() Mathieu Poirier
2016-04-12 17:54 ` Mathieu Poirier
2016-04-19 13:07 ` Suzuki K Poulose [this message]
2016-04-19 13:07 ` Suzuki K Poulose
2016-04-12 17:54 ` [PATCH V2 09/15] coresight: tmc: adding mode of operation for link/sinks Mathieu Poirier
2016-04-12 17:54 ` Mathieu Poirier
2016-04-19 13:19 ` Suzuki K Poulose
2016-04-19 13:19 ` Suzuki K Poulose
2016-04-19 15:45 ` Mathieu Poirier
2016-04-19 15:45 ` Mathieu Poirier
2016-04-19 15:49 ` Suzuki K Poulose
2016-04-19 15:49 ` Suzuki K Poulose
2016-04-12 17:54 ` [PATCH V2 10/15] coresight: tmc: dump system memory content only when needed Mathieu Poirier
2016-04-12 17:54 ` Mathieu Poirier
2016-04-12 17:54 ` [PATCH V2 11/15] coresight: tmc: make sysFS and Perf mode mutually exclusive Mathieu Poirier
2016-04-12 17:54 ` Mathieu Poirier
2016-04-19 13:42 ` Suzuki K Poulose
2016-04-19 13:42 ` Suzuki K Poulose
2016-04-19 16:16 ` Mathieu Poirier
2016-04-19 16:16 ` Mathieu Poirier
2016-04-12 17:54 ` [PATCH V2 12/15] coresight: tmc: keep track of memory width Mathieu Poirier
2016-04-12 17:54 ` Mathieu Poirier
2016-04-14 11:19 ` Suzuki K Poulose
2016-04-14 11:19 ` Suzuki K Poulose
2016-04-15 16:10 ` Mathieu Poirier
2016-04-15 16:10 ` Mathieu Poirier
2016-04-12 17:54 ` [PATCH V2 13/15] coresight: tmc: implementing TMC-ETF AUX space API Mathieu Poirier
2016-04-12 17:54 ` Mathieu Poirier
2016-04-19 16:16 ` Suzuki K Poulose
2016-04-19 16:16 ` Suzuki K Poulose
2016-04-19 16:45 ` Mathieu Poirier
2016-04-19 16:45 ` Mathieu Poirier
2016-04-19 16:50 ` Suzuki K Poulose
2016-04-19 16:50 ` Suzuki K Poulose
2016-04-12 17:54 ` [PATCH V2 14/15] coresight: tmc: implementing TMC-ETR " Mathieu Poirier
2016-04-12 17:54 ` Mathieu Poirier
2016-04-21 16:10 ` Suzuki K Poulose
2016-04-21 16:10 ` Suzuki K Poulose
2016-04-21 22:00 ` Mathieu Poirier
2016-04-21 22:00 ` Mathieu Poirier
2016-04-12 17:54 ` [PATCH V2 15/15] coresight: configuring ETF in FIFO mode when acting as link Mathieu Poirier
2016-04-12 17:54 ` Mathieu Poirier
2016-04-21 12:53 ` Suzuki K Poulose
2016-04-21 12:53 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57162D7C.7040003@arm.com \
--to=suzuki.poulose@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.