From: huawei.libin@huawei.com (Li Bin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 5/9] arm64: Kprobes with single stepping support
Date: Wed, 20 Apr 2016 09:29:28 +0800 [thread overview]
Message-ID: <5716DB78.2010109@huawei.com> (raw)
In-Reply-To: <1457501543-24197-6-git-send-email-dave.long@linaro.org>
Hi David,
on 2016/3/9 13:32, David Long wrote:
> +int __kprobes arch_prepare_kprobe(struct kprobe *p)
> +{
> + unsigned long probe_addr = (unsigned long)p->addr;
Here should verify the addr alignment:
if (probe_addr & 0x3)
return -EINVAL;
Thanks,
Li Bin
> +
> + /* copy instruction */
> + p->opcode = le32_to_cpu(*p->addr);
> +
> + if (in_exception_text(probe_addr))
> + return -EINVAL;
> +
> + /* decode instruction */
> + switch (arm_kprobe_decode_insn(p->addr, &p->ainsn)) {
> + case INSN_REJECTED: /* insn not supported */
> + return -EINVAL;
> +
> + case INSN_GOOD_NO_SLOT: /* insn need simulation */
> + return -EINVAL;
> +
> + case INSN_GOOD: /* instruction uses slot */
> + p->ainsn.insn = get_insn_slot();
> + if (!p->ainsn.insn)
> + return -ENOMEM;
> + break;
> + };
> +
> + /* prepare the instruction */
> + arch_prepare_ss_slot(p);
> +
> + return 0;
> +}
> +
WARNING: multiple messages have this Message-ID (diff)
From: Li Bin <huawei.libin@huawei.com>
To: David Long <dave.long@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com>,
William Cohen <wcohen@redhat.com>,
"Pratyush Anand" <panand@redhat.com>,
Steve Capper <steve.capper@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Marc Zyngier <marc.zyngier@arm.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Petr Mladek" <pmladek@suse.com>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"John Blackwood" <john.blackwood@ccur.com>,
"Feng Kan" <fkan@apm.com>, "Zi Shen Lim" <zlim.lnx@gmail.com>,
"Dave P Martin" <Dave.Martin@arm.com>,
"Yang Shi" <yang.shi@linaro.org>,
"Vladimir Murzin" <Vladimir.Murzin@arm.com>,
"Kees Cook" <keescook@chromium.org>,
"Suzuki K. Poulose" <suzuki.poulose@arm.com>,
"Mark Brown" <broonie@kernel.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Mark Salyzyn" <salyzyn@android.com>,
"James Morse" <james.morse@arm.com>,
"Christoffer Dall" <christoffer.dall@linaro.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Robin Murphy" <Robin.Murphy@arm.com>,
"Jens Wiklander" <jens.wiklander@linaro.org>,
"Balamurugan Shanmugam" <bshanmugam@apm.com>,
"Hanjun Guo" <guohanjun@huawei.com>,
"Ding Tianhong" <dingtianhong@huawei.com>,
wangnan0@huawei.com
Subject: Re: [PATCH v11 5/9] arm64: Kprobes with single stepping support
Date: Wed, 20 Apr 2016 09:29:28 +0800 [thread overview]
Message-ID: <5716DB78.2010109@huawei.com> (raw)
In-Reply-To: <1457501543-24197-6-git-send-email-dave.long@linaro.org>
Hi David,
on 2016/3/9 13:32, David Long wrote:
> +int __kprobes arch_prepare_kprobe(struct kprobe *p)
> +{
> + unsigned long probe_addr = (unsigned long)p->addr;
Here should verify the addr alignment:
if (probe_addr & 0x3)
return -EINVAL;
Thanks,
Li Bin
> +
> + /* copy instruction */
> + p->opcode = le32_to_cpu(*p->addr);
> +
> + if (in_exception_text(probe_addr))
> + return -EINVAL;
> +
> + /* decode instruction */
> + switch (arm_kprobe_decode_insn(p->addr, &p->ainsn)) {
> + case INSN_REJECTED: /* insn not supported */
> + return -EINVAL;
> +
> + case INSN_GOOD_NO_SLOT: /* insn need simulation */
> + return -EINVAL;
> +
> + case INSN_GOOD: /* instruction uses slot */
> + p->ainsn.insn = get_insn_slot();
> + if (!p->ainsn.insn)
> + return -ENOMEM;
> + break;
> + };
> +
> + /* prepare the instruction */
> + arch_prepare_ss_slot(p);
> +
> + return 0;
> +}
> +
next prev parent reply other threads:[~2016-04-20 1:29 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 5:32 [PATCH v11 0/9] arm64: Add kernel probes (kprobes) support David Long
2016-03-09 5:32 ` David Long
2016-03-09 5:32 ` [PATCH v11 1/9] arm64: Add HAVE_REGS_AND_STACK_ACCESS_API feature David Long
2016-03-09 5:32 ` David Long
2016-03-11 18:07 ` James Morse
2016-03-11 18:07 ` James Morse
2016-03-18 13:06 ` David Long
2016-03-18 13:06 ` David Long
2016-03-15 11:04 ` Marc Zyngier
2016-03-15 11:04 ` Marc Zyngier
2016-03-21 7:08 ` David Long
2016-03-21 7:08 ` David Long
2016-03-09 5:32 ` [PATCH v11 2/9] arm64: Add more test functions to insn.c David Long
2016-03-09 5:32 ` David Long
2016-03-09 5:32 ` [PATCH v11 3/9] arm64: add copy_to/from_user to kprobes blacklist David Long
2016-03-09 5:32 ` David Long
2016-03-15 18:47 ` James Morse
2016-03-15 18:47 ` James Morse
2016-03-16 5:43 ` Pratyush Anand
2016-03-16 5:43 ` Pratyush Anand
2016-03-16 10:27 ` James Morse
2016-03-16 10:27 ` James Morse
2016-03-17 7:57 ` Pratyush Anand
2016-03-17 7:57 ` Pratyush Anand
2016-03-18 13:29 ` Pratyush Anand
2016-03-18 13:29 ` Pratyush Anand
2016-03-18 14:02 ` James Morse
2016-03-18 14:02 ` James Morse
2016-03-18 14:43 ` Pratyush Anand
2016-03-18 14:43 ` Pratyush Anand
2016-03-18 18:12 ` James Morse
2016-03-18 18:12 ` James Morse
2016-03-21 5:17 ` Pratyush Anand
2016-03-21 5:17 ` Pratyush Anand
2016-03-21 14:52 ` Will Deacon
2016-03-21 14:52 ` Will Deacon
2016-03-22 16:51 ` Pratyush Anand
2016-03-22 16:51 ` Pratyush Anand
2016-03-17 12:04 ` 平松雅巳 / HIRAMATU，MASAMI
2016-03-17 12:04 ` 平松雅巳 / HIRAMATU，MASAMI
2016-03-09 5:32 ` [PATCH v11 4/9] arm64: add conditional instruction simulation support David Long
2016-03-09 5:32 ` David Long
2016-03-13 12:09 ` Marc Zyngier
2016-03-13 12:09 ` Marc Zyngier
2016-03-14 4:04 ` Pratyush Anand
2016-03-14 4:04 ` Pratyush Anand
2016-03-14 7:38 ` Marc Zyngier
2016-03-14 7:38 ` Marc Zyngier
2016-03-21 8:35 ` David Long
2016-03-21 8:35 ` David Long
2016-03-09 5:32 ` [PATCH v11 5/9] arm64: Kprobes with single stepping support David Long
2016-03-09 5:32 ` David Long
2016-04-20 1:29 ` Li Bin [this message]
2016-04-20 1:29 ` Li Bin
2016-03-09 5:32 ` [PATCH v11 6/9] arm64: kprobes instruction simulation support David Long
2016-03-09 5:32 ` David Long
2016-03-12 3:56 ` Marc Zyngier
2016-03-12 3:56 ` Marc Zyngier
2016-03-21 9:39 ` David Long
2016-03-21 9:39 ` David Long
2016-03-09 5:32 ` [PATCH v11 7/9] arm64: Add trampoline code for kretprobes David Long
2016-03-09 5:32 ` David Long
2016-03-13 13:52 ` Marc Zyngier
2016-03-13 13:52 ` Marc Zyngier
2016-03-21 13:30 ` David Long
2016-03-21 13:30 ` David Long
2016-03-09 5:32 ` [PATCH v11 8/9] arm64: Add kernel return probes support (kretprobes) David Long
2016-03-09 5:32 ` David Long
2016-03-17 12:22 ` 平松雅巳 / HIRAMATU，MASAMI
2016-03-17 12:22 ` 平松雅巳 / HIRAMATU，MASAMI
2016-03-17 12:58 ` 平松雅巳 / HIRAMATU，MASAMI
2016-03-17 12:58 ` 平松雅巳 / HIRAMATU，MASAMI
2016-03-21 13:33 ` David Long
2016-03-21 13:33 ` David Long
2016-03-09 5:32 ` [PATCH v11 9/9] kprobes: Add arm64 case in kprobe example module David Long
2016-03-09 5:32 ` David Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5716DB78.2010109@huawei.com \
--to=huawei.libin@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.