* [kvm-unit-tests PATCH] powerpc: don't fail if QEMU does not support alignment exception
@ 2016-04-19 13:36 ` Laurent Vivier
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2016-04-19 13:36 UTC (permalink / raw)
To: kvm, kvm-ppc; +Cc: drjones, thuth, dgibson, pbonzini, Laurent Vivier
As for lswi, lswx is supposed to cause an alignment exception in
little endian mode, but QEMU does not support it. So in case we do
not get an exception, this is an expected failure and we run the other
tests.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
powerpc/emulator.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/powerpc/emulator.c b/powerpc/emulator.c
index 4dc341f..9720723 100644
--- a/powerpc/emulator.c
+++ b/powerpc/emulator.c
@@ -245,8 +245,16 @@ static void test_lswx(void)
"xer", "r11", "r12", "memory");
#if __BYTE_ORDER__ = __ORDER_LITTLE_ENDIAN__
- report("alignment", alignment);
- return;
+ /*
+ * lswx is supposed to cause an alignment exception in little endian
+ * mode, but QEMU does not support it. So in case we do not get an
+ * exception, this is an expected failure and we run the other tests
+ */
+ report_xfail("alignment", !alignment, alignment);
+ if (alignment) {
+ report_prefix_pop();
+ return;
+ }
#else
report("partial", regs[0] = 0x01020300 && regs[1] = (uint64_t)-1);
#endif
--
2.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [kvm-unit-tests PATCH] powerpc: don't fail if QEMU does not support alignment exception
@ 2016-04-19 13:36 ` Laurent Vivier
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2016-04-19 13:36 UTC (permalink / raw)
To: kvm, kvm-ppc; +Cc: drjones, thuth, dgibson, pbonzini, Laurent Vivier
As for lswi, lswx is supposed to cause an alignment exception in
little endian mode, but QEMU does not support it. So in case we do
not get an exception, this is an expected failure and we run the other
tests.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
powerpc/emulator.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/powerpc/emulator.c b/powerpc/emulator.c
index 4dc341f..9720723 100644
--- a/powerpc/emulator.c
+++ b/powerpc/emulator.c
@@ -245,8 +245,16 @@ static void test_lswx(void)
"xer", "r11", "r12", "memory");
#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
- report("alignment", alignment);
- return;
+ /*
+ * lswx is supposed to cause an alignment exception in little endian
+ * mode, but QEMU does not support it. So in case we do not get an
+ * exception, this is an expected failure and we run the other tests
+ */
+ report_xfail("alignment", !alignment, alignment);
+ if (alignment) {
+ report_prefix_pop();
+ return;
+ }
#else
report("partial", regs[0] == 0x01020300 && regs[1] == (uint64_t)-1);
#endif
--
2.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] powerpc: don't fail if QEMU does not support alignment exception
2016-04-19 13:36 ` Laurent Vivier
@ 2016-04-20 6:52 ` Laurent Vivier
-1 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2016-04-20 6:52 UTC (permalink / raw)
To: kvm, kvm-ppc; +Cc: drjones, thuth, dgibson, pbonzini
On 19/04/2016 15:36, Laurent Vivier wrote:
> As for lswi, lswx is supposed to cause an alignment exception in
> little endian mode, but QEMU does not support it. So in case we do
> not get an exception, this is an expected failure and we run the other
> tests.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> powerpc/emulator.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/powerpc/emulator.c b/powerpc/emulator.c
> index 4dc341f..9720723 100644
> --- a/powerpc/emulator.c
> +++ b/powerpc/emulator.c
> @@ -245,8 +245,16 @@ static void test_lswx(void)
> "xer", "r11", "r12", "memory");
>
> #if __BYTE_ORDER__ = __ORDER_LITTLE_ENDIAN__
> - report("alignment", alignment);
> - return;
> + /*
> + * lswx is supposed to cause an alignment exception in little endian
> + * mode, but QEMU does not support it. So in case we do not get an
> + * exception, this is an expected failure and we run the other tests
> + */
> + report_xfail("alignment", !alignment, alignment);
> + if (alignment) {
> + report_prefix_pop();
> + return;
> + }
> #else
> report("partial", regs[0] = 0x01020300 && regs[1] = (uint64_t)-1);
> #endif
If fact, this is not correct: the report("partial",...) should be out
the #if..#endif body.
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] powerpc: don't fail if QEMU does not support alignment exception
@ 2016-04-20 6:52 ` Laurent Vivier
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2016-04-20 6:52 UTC (permalink / raw)
To: kvm, kvm-ppc; +Cc: drjones, thuth, dgibson, pbonzini
On 19/04/2016 15:36, Laurent Vivier wrote:
> As for lswi, lswx is supposed to cause an alignment exception in
> little endian mode, but QEMU does not support it. So in case we do
> not get an exception, this is an expected failure and we run the other
> tests.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> powerpc/emulator.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/powerpc/emulator.c b/powerpc/emulator.c
> index 4dc341f..9720723 100644
> --- a/powerpc/emulator.c
> +++ b/powerpc/emulator.c
> @@ -245,8 +245,16 @@ static void test_lswx(void)
> "xer", "r11", "r12", "memory");
>
> #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
> - report("alignment", alignment);
> - return;
> + /*
> + * lswx is supposed to cause an alignment exception in little endian
> + * mode, but QEMU does not support it. So in case we do not get an
> + * exception, this is an expected failure and we run the other tests
> + */
> + report_xfail("alignment", !alignment, alignment);
> + if (alignment) {
> + report_prefix_pop();
> + return;
> + }
> #else
> report("partial", regs[0] == 0x01020300 && regs[1] == (uint64_t)-1);
> #endif
If fact, this is not correct: the report("partial",...) should be out
the #if..#endif body.
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-20 6:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-19 13:36 [kvm-unit-tests PATCH] powerpc: don't fail if QEMU does not support alignment exception Laurent Vivier
2016-04-19 13:36 ` Laurent Vivier
2016-04-20 6:52 ` Laurent Vivier
2016-04-20 6:52 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.