* [PATCH 0/2] Protobuf recipes update @ 2016-04-19 15:40 Felipe F. Tonello 2016-04-19 15:40 ` [PATCH 1/2] protobuf: add protobuf-c recipe Felipe F. Tonello 2016-04-19 15:40 ` [PATCH 2/2] protobuf: Split package to main and compiler packages Felipe F. Tonello 0 siblings, 2 replies; 10+ messages in thread From: Felipe F. Tonello @ 2016-04-19 15:40 UTC (permalink / raw) To: openembedded-devel Added protobuf-c recipe which is the protobuf implementation in C. Also split protobuf package into two packages, one for the run-time libraries and other for the compiler. Felipe F. Tonello (2): protobuf: add protobuf-c recipe protobuf: Split package to main and compiler packages .../recipes-devtools/protobuf/protobuf-c_1.2.1.bb | 26 ++++++++++++++++++++++ .../recipes-devtools/protobuf/protobuf_2.6.1.bb | 4 ++++ 2 files changed, 30 insertions(+) create mode 100644 meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb -- 2.8.0 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] protobuf: add protobuf-c recipe 2016-04-19 15:40 [PATCH 0/2] Protobuf recipes update Felipe F. Tonello @ 2016-04-19 15:40 ` Felipe F. Tonello 2016-04-19 19:46 ` Bruce Ashfield 2016-04-19 15:40 ` [PATCH 2/2] protobuf: Split package to main and compiler packages Felipe F. Tonello 1 sibling, 1 reply; 10+ messages in thread From: Felipe F. Tonello @ 2016-04-19 15:40 UTC (permalink / raw) To: openembedded-devel Initial version of recipe. The main package could be split into two to separate the compiler. This also applies to protobuf recipe. Signed-off-by: Felipe F. Tonello <eu@felipetonello.com> --- .../recipes-devtools/protobuf/protobuf-c_1.2.1.bb | 26 ++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb diff --git a/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb b/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb new file mode 100644 index 000000000000..88cdb0bccd8e --- /dev/null +++ b/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb @@ -0,0 +1,26 @@ +SUMMARY = "Protocol Buffers - structured data serialisation mechanism" +DESCRIPTION = "This is protobuf-c, a C implementation of the Google Protocol Buffers data \ +serialization format. It includes libprotobuf-c, a pure C library that \ +implements protobuf encoding and decoding, and protoc-c, a code generator that \ +converts Protocol Buffer .proto files to C descriptor code, based on the \ +original protoc. protobuf-c formerly included an RPC implementation; that code \ +has been split out into the protobuf-c-rpc project." +HOMEPAGE = "https://github.com/protobuf-c/protobuf-c" +SECTION = "console/tools" +LICENSE = "BSD-2-Clause" + +DEPENDS = "protobuf-native protobuf" + +PACKAGE_BEFORE_PN = "${PN}-compiler" + +LIC_FILES_CHKSUM = "file://LICENSE;md5=235c3195a3968524dc1524b4ebea0c0e" +SRC_URI = "https://github.com/protobuf-c/protobuf-c/archive/v${PV}.tar.gz" + +SRC_URI[md5sum] = "b884aeba4283309445a8e3b6e7322dd6" +SRC_URI[sha256sum] = "2d708fb3c024b9e6e86df141faff802194f5db90a4b79e6d4aa6bd61dd983dd6" + +inherit autotools pkgconfig + +FILES_${PN}-compiler = "${bindir}" + +BBCLASSEXTEND = "native nativesdk" -- 2.8.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] protobuf: add protobuf-c recipe 2016-04-19 15:40 ` [PATCH 1/2] protobuf: add protobuf-c recipe Felipe F. Tonello @ 2016-04-19 19:46 ` Bruce Ashfield 2016-04-19 19:55 ` Bruce Ashfield 0 siblings, 1 reply; 10+ messages in thread From: Bruce Ashfield @ 2016-04-19 19:46 UTC (permalink / raw) To: openembedded-devel On Tue, Apr 19, 2016 at 11:40 AM, Felipe F. Tonello <eu@felipetonello.com> wrote: > Initial version of recipe. The main package could be split into two to > separate the compiler. This also applies to protobuf recipe. > > More precisely, this is the initial version outside of meta-virtualization which enea added in 2012 :) It was added as a dependency for criu (hence why it was put in meta-virt). If we move it to meta-oe, we at least owe that other implementation a reference in the commit. Did you check the version we have there for deltas ? There are differences in the recipe, and it would be good to know if you've looked and determined they aren't necessary. Cheers, Bruce > Signed-off-by: Felipe F. Tonello <eu@felipetonello.com> > --- > .../recipes-devtools/protobuf/protobuf-c_1.2.1.bb | 26 > ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb > > diff --git a/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb > b/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb > new file mode 100644 > index 000000000000..88cdb0bccd8e > --- /dev/null > +++ b/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb > @@ -0,0 +1,26 @@ > +SUMMARY = "Protocol Buffers - structured data serialisation mechanism" > +DESCRIPTION = "This is protobuf-c, a C implementation of the Google > Protocol Buffers data \ > +serialization format. It includes libprotobuf-c, a pure C library that \ > +implements protobuf encoding and decoding, and protoc-c, a code generator > that \ > +converts Protocol Buffer .proto files to C descriptor code, based on the \ > +original protoc. protobuf-c formerly included an RPC implementation; that > code \ > +has been split out into the protobuf-c-rpc project." > +HOMEPAGE = "https://github.com/protobuf-c/protobuf-c" > +SECTION = "console/tools" > +LICENSE = "BSD-2-Clause" > + > +DEPENDS = "protobuf-native protobuf" > + > +PACKAGE_BEFORE_PN = "${PN}-compiler" > + > +LIC_FILES_CHKSUM = "file://LICENSE;md5=235c3195a3968524dc1524b4ebea0c0e" > +SRC_URI = "https://github.com/protobuf-c/protobuf-c/archive/v${PV}.tar.gz > " > + > +SRC_URI[md5sum] = "b884aeba4283309445a8e3b6e7322dd6" > +SRC_URI[sha256sum] = > "2d708fb3c024b9e6e86df141faff802194f5db90a4b79e6d4aa6bd61dd983dd6" > + > +inherit autotools pkgconfig > + > +FILES_${PN}-compiler = "${bindir}" > + > +BBCLASSEXTEND = "native nativesdk" > -- > 2.8.0 > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end" ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] protobuf: add protobuf-c recipe 2016-04-19 19:46 ` Bruce Ashfield @ 2016-04-19 19:55 ` Bruce Ashfield 2016-04-20 8:32 ` Felipe Ferreri Tonello 0 siblings, 1 reply; 10+ messages in thread From: Bruce Ashfield @ 2016-04-19 19:55 UTC (permalink / raw) To: openembedded-devel On Tue, Apr 19, 2016 at 3:46 PM, Bruce Ashfield <bruce.ashfield@gmail.com> wrote: > > > On Tue, Apr 19, 2016 at 11:40 AM, Felipe F. Tonello <eu@felipetonello.com> > wrote: > >> Initial version of recipe. The main package could be split into two to >> separate the compiler. This also applies to protobuf recipe. >> >> > More precisely, this is the initial version outside of meta-virtualization > which enea added > in 2012 :) It was added as a dependency for criu (hence why it was put in > meta-virt). > > If we move it to meta-oe, we at least owe that other implementation a > reference in the commit. > > s/if/when/. I'm happy to purge all the protobuf* recipes from meta-virt, since they were only there as support mechanisms (and I wasn't involved in their original merge). But if you can take a look at what's in the meta-virt recipe, I'll do some runtime testing with your variant here, and drop the meta-virt ones when I can confirm criu works. Cheers, Bruce > Did you check the version we have there for deltas ? There are differences > in the recipe, and > it would be good to know if you've looked and determined they aren't > necessary. > > Cheers, > > Bruce > > >> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com> >> --- >> .../recipes-devtools/protobuf/protobuf-c_1.2.1.bb | 26 >> ++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> create mode 100644 meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb >> >> diff --git a/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb >> b/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb >> new file mode 100644 >> index 000000000000..88cdb0bccd8e >> --- /dev/null >> +++ b/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb >> @@ -0,0 +1,26 @@ >> +SUMMARY = "Protocol Buffers - structured data serialisation mechanism" >> +DESCRIPTION = "This is protobuf-c, a C implementation of the Google >> Protocol Buffers data \ >> +serialization format. It includes libprotobuf-c, a pure C library that \ >> +implements protobuf encoding and decoding, and protoc-c, a code >> generator that \ >> +converts Protocol Buffer .proto files to C descriptor code, based on the >> \ >> +original protoc. protobuf-c formerly included an RPC implementation; >> that code \ >> +has been split out into the protobuf-c-rpc project." >> +HOMEPAGE = "https://github.com/protobuf-c/protobuf-c" >> +SECTION = "console/tools" >> +LICENSE = "BSD-2-Clause" >> + >> +DEPENDS = "protobuf-native protobuf" >> + >> +PACKAGE_BEFORE_PN = "${PN}-compiler" >> + >> +LIC_FILES_CHKSUM = "file://LICENSE;md5=235c3195a3968524dc1524b4ebea0c0e" >> +SRC_URI = " >> https://github.com/protobuf-c/protobuf-c/archive/v${PV}.tar.gz" >> + >> +SRC_URI[md5sum] = "b884aeba4283309445a8e3b6e7322dd6" >> +SRC_URI[sha256sum] = >> "2d708fb3c024b9e6e86df141faff802194f5db90a4b79e6d4aa6bd61dd983dd6" >> + >> +inherit autotools pkgconfig >> + >> +FILES_${PN}-compiler = "${bindir}" >> + >> +BBCLASSEXTEND = "native nativesdk" >> -- >> 2.8.0 >> >> -- >> _______________________________________________ >> Openembedded-devel mailing list >> Openembedded-devel@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel >> > > > > -- > "Thou shalt not follow the NULL pointer, for chaos and madness await thee > at its end" > -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end" ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] protobuf: add protobuf-c recipe 2016-04-19 19:55 ` Bruce Ashfield @ 2016-04-20 8:32 ` Felipe Ferreri Tonello 2016-04-20 14:32 ` Bruce Ashfield 0 siblings, 1 reply; 10+ messages in thread From: Felipe Ferreri Tonello @ 2016-04-20 8:32 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 3359 bytes --] Hi Bruce, On 19/04/16 20:55, Bruce Ashfield wrote: > On Tue, Apr 19, 2016 at 3:46 PM, Bruce Ashfield <bruce.ashfield@gmail.com> > wrote: > >> >> >> On Tue, Apr 19, 2016 at 11:40 AM, Felipe F. Tonello <eu@felipetonello.com> >> wrote: >> >>> Initial version of recipe. The main package could be split into two to >>> separate the compiler. This also applies to protobuf recipe. >>> >>> >> More precisely, this is the initial version outside of meta-virtualization >> which enea added >> in 2012 :) It was added as a dependency for criu (hence why it was put in >> meta-virt). >> >> If we move it to meta-oe, we at least owe that other implementation a >> reference in the commit. >> >> > s/if/when/. > > I'm happy to purge all the protobuf* recipes from meta-virt, since they > were only there as > support mechanisms (and I wasn't involved in their original merge). > > But if you can take a look at what's in the meta-virt recipe, I'll do some > runtime testing with your > variant here, and drop the meta-virt ones when I can confirm criu works. > Regular protobuf recipe is already part of meta-oe. That's why I added this one there too. > Cheers, > > Bruce > > >> Did you check the version we have there for deltas ? There are differences >> in the recipe, and >> it would be good to know if you've looked and determined they aren't >> necessary. >> >> Cheers, >> >> Bruce >> >> >>> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com> >>> --- >>> .../recipes-devtools/protobuf/protobuf-c_1.2.1.bb | 26 >>> ++++++++++++++++++++++ >>> 1 file changed, 26 insertions(+) >>> create mode 100644 meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb >>> >>> diff --git a/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb >>> b/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb >>> new file mode 100644 >>> index 000000000000..88cdb0bccd8e >>> --- /dev/null >>> +++ b/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb >>> @@ -0,0 +1,26 @@ >>> +SUMMARY = "Protocol Buffers - structured data serialisation mechanism" >>> +DESCRIPTION = "This is protobuf-c, a C implementation of the Google >>> Protocol Buffers data \ >>> +serialization format. It includes libprotobuf-c, a pure C library that \ >>> +implements protobuf encoding and decoding, and protoc-c, a code >>> generator that \ >>> +converts Protocol Buffer .proto files to C descriptor code, based on the >>> \ >>> +original protoc. protobuf-c formerly included an RPC implementation; >>> that code \ >>> +has been split out into the protobuf-c-rpc project." >>> +HOMEPAGE = "https://github.com/protobuf-c/protobuf-c" >>> +SECTION = "console/tools" >>> +LICENSE = "BSD-2-Clause" >>> + >>> +DEPENDS = "protobuf-native protobuf" >>> + >>> +PACKAGE_BEFORE_PN = "${PN}-compiler" >>> + >>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=235c3195a3968524dc1524b4ebea0c0e" >>> +SRC_URI = " >>> https://github.com/protobuf-c/protobuf-c/archive/v${PV}.tar.gz" >>> + >>> +SRC_URI[md5sum] = "b884aeba4283309445a8e3b6e7322dd6" >>> +SRC_URI[sha256sum] = >>> "2d708fb3c024b9e6e86df141faff802194f5db90a4b79e6d4aa6bd61dd983dd6" >>> + >>> +inherit autotools pkgconfig >>> + >>> +FILES_${PN}-compiler = "${bindir}" >>> + >>> +BBCLASSEXTEND = "native nativesdk" >>> -- >>> 2.8.0 >>> >>> -- Felipe [-- Attachment #2: 0x92698E6A.asc --] [-- Type: application/pgp-keys, Size: 7310 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] protobuf: add protobuf-c recipe 2016-04-20 8:32 ` Felipe Ferreri Tonello @ 2016-04-20 14:32 ` Bruce Ashfield 2016-04-28 8:02 ` Felipe Ferreri Tonello 0 siblings, 1 reply; 10+ messages in thread From: Bruce Ashfield @ 2016-04-20 14:32 UTC (permalink / raw) To: openembedded-devel On Wed, Apr 20, 2016 at 4:32 AM, Felipe Ferreri Tonello < eu@felipetonello.com> wrote: > Hi Bruce, > > On 19/04/16 20:55, Bruce Ashfield wrote: > > On Tue, Apr 19, 2016 at 3:46 PM, Bruce Ashfield < > bruce.ashfield@gmail.com> > > wrote: > > > >> > >> > >> On Tue, Apr 19, 2016 at 11:40 AM, Felipe F. Tonello < > eu@felipetonello.com> > >> wrote: > >> > >>> Initial version of recipe. The main package could be split into two to > >>> separate the compiler. This also applies to protobuf recipe. > >>> > >>> > >> More precisely, this is the initial version outside of > meta-virtualization > >> which enea added > >> in 2012 :) It was added as a dependency for criu (hence why it was put > in > >> meta-virt). > >> > >> If we move it to meta-oe, we at least owe that other implementation a > >> reference in the commit. > >> > >> > > s/if/when/. > > > > I'm happy to purge all the protobuf* recipes from meta-virt, since they > > were only there as > > support mechanisms (and I wasn't involved in their original merge). > > > > But if you can take a look at what's in the meta-virt recipe, I'll do > some > > runtime testing with your > > variant here, and drop the meta-virt ones when I can confirm criu works. > > > > Regular protobuf recipe is already part of meta-oe. That's why I added > this one there too. > Sure. That's obvious from the layer index, as is the existence of the one in meta-virt. Credit, where credit is due. It's not my work, so I'm not asking for any credit, but simply duplicating something that already exists without a nod to the older one isn't ideal. All I was asking was that if you could a link to the meta-virt one in the commit header so that someone not familiar with the layer index can see the two options .. and at the same time I was wondering if you'd seen the meta-virt one and did this one differently for technical reasons. That makes it easier for me to drop recipes as they get cloned around to new (and better) locations. Bruce > > Cheers, > > > > Bruce > > > > > >> Did you check the version we have there for deltas ? There are > differences > >> in the recipe, and > >> it would be good to know if you've looked and determined they aren't > >> necessary. > >> > >> Cheers, > >> > >> Bruce > >> > >> > >>> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com> > >>> --- > >>> .../recipes-devtools/protobuf/protobuf-c_1.2.1.bb | 26 > >>> ++++++++++++++++++++++ > >>> 1 file changed, 26 insertions(+) > >>> create mode 100644 meta-oe/recipes-devtools/protobuf/ > protobuf-c_1.2.1.bb > >>> > >>> diff --git a/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb > >>> b/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb > >>> new file mode 100644 > >>> index 000000000000..88cdb0bccd8e > >>> --- /dev/null > >>> +++ b/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb > >>> @@ -0,0 +1,26 @@ > >>> +SUMMARY = "Protocol Buffers - structured data serialisation mechanism" > >>> +DESCRIPTION = "This is protobuf-c, a C implementation of the Google > >>> Protocol Buffers data \ > >>> +serialization format. It includes libprotobuf-c, a pure C library > that \ > >>> +implements protobuf encoding and decoding, and protoc-c, a code > >>> generator that \ > >>> +converts Protocol Buffer .proto files to C descriptor code, based on > the > >>> \ > >>> +original protoc. protobuf-c formerly included an RPC implementation; > >>> that code \ > >>> +has been split out into the protobuf-c-rpc project." > >>> +HOMEPAGE = "https://github.com/protobuf-c/protobuf-c" > >>> +SECTION = "console/tools" > >>> +LICENSE = "BSD-2-Clause" > >>> + > >>> +DEPENDS = "protobuf-native protobuf" > >>> + > >>> +PACKAGE_BEFORE_PN = "${PN}-compiler" > >>> + > >>> +LIC_FILES_CHKSUM = > "file://LICENSE;md5=235c3195a3968524dc1524b4ebea0c0e" > >>> +SRC_URI = " > >>> https://github.com/protobuf-c/protobuf-c/archive/v${PV}.tar.gz" > >>> + > >>> +SRC_URI[md5sum] = "b884aeba4283309445a8e3b6e7322dd6" > >>> +SRC_URI[sha256sum] = > >>> "2d708fb3c024b9e6e86df141faff802194f5db90a4b79e6d4aa6bd61dd983dd6" > >>> + > >>> +inherit autotools pkgconfig > >>> + > >>> +FILES_${PN}-compiler = "${bindir}" > >>> + > >>> +BBCLASSEXTEND = "native nativesdk" > >>> -- > >>> 2.8.0 > >>> > >>> -- > > Felipe > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end" ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] protobuf: add protobuf-c recipe 2016-04-20 14:32 ` Bruce Ashfield @ 2016-04-28 8:02 ` Felipe Ferreri Tonello 2016-04-28 13:16 ` Bruce Ashfield 0 siblings, 1 reply; 10+ messages in thread From: Felipe Ferreri Tonello @ 2016-04-28 8:02 UTC (permalink / raw) To: openembedded-devel [-- Attachment #1: Type: text/plain, Size: 2340 bytes --] Hi Bruce, On 20/04/16 15:32, Bruce Ashfield wrote: > On Wed, Apr 20, 2016 at 4:32 AM, Felipe Ferreri Tonello < > eu@felipetonello.com> wrote: > >> Hi Bruce, >> >> On 19/04/16 20:55, Bruce Ashfield wrote: >>> On Tue, Apr 19, 2016 at 3:46 PM, Bruce Ashfield < >> bruce.ashfield@gmail.com> >>> wrote: >>> >>>> >>>> >>>> On Tue, Apr 19, 2016 at 11:40 AM, Felipe F. Tonello < >> eu@felipetonello.com> >>>> wrote: >>>> >>>>> Initial version of recipe. The main package could be split into two to >>>>> separate the compiler. This also applies to protobuf recipe. >>>>> >>>>> >>>> More precisely, this is the initial version outside of >> meta-virtualization >>>> which enea added >>>> in 2012 :) It was added as a dependency for criu (hence why it was put >> in >>>> meta-virt). >>>> >>>> If we move it to meta-oe, we at least owe that other implementation a >>>> reference in the commit. >>>> >>>> >>> s/if/when/. >>> >>> I'm happy to purge all the protobuf* recipes from meta-virt, since they >>> were only there as >>> support mechanisms (and I wasn't involved in their original merge). >>> >>> But if you can take a look at what's in the meta-virt recipe, I'll do >> some >>> runtime testing with your >>> variant here, and drop the meta-virt ones when I can confirm criu works. >>> >> >> Regular protobuf recipe is already part of meta-oe. That's why I added >> this one there too. >> > > Sure. That's obvious from the layer index, as is the existence of the one > in meta-virt. I didn 't take it from meta-virt. The original protobuf recipe is in meta-oe. > > Credit, where credit is due. It's not my work, so I'm not asking for any > credit, > but simply duplicating something that already exists without a nod to the > older one > isn't ideal. > > All I was asking was that if you could a link to the meta-virt one in the > commit header > so that someone not familiar with the layer index can see the two options > .. and > at the same time I was wondering if you'd seen the meta-virt one and did > this one > differently for technical reasons. That makes it easier for me to drop > recipes as they > get cloned around to new (and better) locations. I am fine with that. Can you please provide the git hash so I can link it? Thanks in advance, Felipe [-- Attachment #2: 0x92698E6A.asc --] [-- Type: application/pgp-keys, Size: 7310 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] protobuf: add protobuf-c recipe 2016-04-28 8:02 ` Felipe Ferreri Tonello @ 2016-04-28 13:16 ` Bruce Ashfield 0 siblings, 0 replies; 10+ messages in thread From: Bruce Ashfield @ 2016-04-28 13:16 UTC (permalink / raw) To: openembedded-devel On Thu, Apr 28, 2016 at 4:02 AM, Felipe Ferreri Tonello < eu@felipetonello.com> wrote: > Hi Bruce, > > On 20/04/16 15:32, Bruce Ashfield wrote: > > On Wed, Apr 20, 2016 at 4:32 AM, Felipe Ferreri Tonello < > > eu@felipetonello.com> wrote: > > > >> Hi Bruce, > >> > >> On 19/04/16 20:55, Bruce Ashfield wrote: > >>> On Tue, Apr 19, 2016 at 3:46 PM, Bruce Ashfield < > >> bruce.ashfield@gmail.com> > >>> wrote: > >>> > >>>> > >>>> > >>>> On Tue, Apr 19, 2016 at 11:40 AM, Felipe F. Tonello < > >> eu@felipetonello.com> > >>>> wrote: > >>>> > >>>>> Initial version of recipe. The main package could be split into two > to > >>>>> separate the compiler. This also applies to protobuf recipe. > >>>>> > >>>>> > >>>> More precisely, this is the initial version outside of > >> meta-virtualization > >>>> which enea added > >>>> in 2012 :) It was added as a dependency for criu (hence why it was put > >> in > >>>> meta-virt). > >>>> > >>>> If we move it to meta-oe, we at least owe that other implementation a > >>>> reference in the commit. > >>>> > >>>> > >>> s/if/when/. > >>> > >>> I'm happy to purge all the protobuf* recipes from meta-virt, since they > >>> were only there as > >>> support mechanisms (and I wasn't involved in their original merge). > >>> > >>> But if you can take a look at what's in the meta-virt recipe, I'll do > >> some > >>> runtime testing with your > >>> variant here, and drop the meta-virt ones when I can confirm criu > works. > >>> > >> > >> Regular protobuf recipe is already part of meta-oe. That's why I added > >> this one there too. > >> > > > > Sure. That's obvious from the layer index, as is the existence of the one > > in meta-virt. > > I didn 't take it from meta-virt. The original protobuf recipe is in > meta-oe. > Yup, I wasn't implying that you did. Sorry if it came across that way, I was just pointing out the layer index, since it is a good place to check when considering a new recipe. The ones in meta-virt need cleanup (and I'll drop them once this is in meta-oe), but that's something we could have tackled (literally) years ago if the repetition had been picked up. > > > > > Credit, where credit is due. It's not my work, so I'm not asking for any > > credit, > > but simply duplicating something that already exists without a nod to the > > older one > > isn't ideal. > > > > All I was asking was that if you could a link to the meta-virt one in the > > commit header > > so that someone not familiar with the layer index can see the two options > > .. and > > at the same time I was wondering if you'd seen the meta-virt one and did > > this one > > differently for technical reasons. That makes it easier for me to drop > > recipes as they > > get cloned around to new (and better) locations. > > I am fine with that. Can you please provide the git hash so I can link it? > > That's great, just a shout out something like: ---- replaces/obsoletes: commit 0d31f8448412 [Added protobuf-c criu dependency] in meta-virtualization ---- Would be great, then we see the duplication, and why it was ever in meta-virt in the first place. (the full commit log is below) commit 0d31f844841249262fe142c4c03853dd1f647e2d Author: David Nystr?m <david.nystrom@enea.com> Date: Thu Dec 6 10:54:55 2012 +0100 Added protobuf-c criu dependency Signed-off-by: David Nystr?m <david.nystrom@enea.com> Cheers, Bruce > Thanks in advance, > Felipe > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end" ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] protobuf: Split package to main and compiler packages 2016-04-19 15:40 [PATCH 0/2] Protobuf recipes update Felipe F. Tonello 2016-04-19 15:40 ` [PATCH 1/2] protobuf: add protobuf-c recipe Felipe F. Tonello @ 2016-04-19 15:40 ` Felipe F. Tonello 1 sibling, 0 replies; 10+ messages in thread From: Felipe F. Tonello @ 2016-04-19 15:40 UTC (permalink / raw) To: openembedded-devel Protobuf has two main features, a compiler and a library. Run-time applications only need the libraries to run. Signed-off-by: Felipe F. Tonello <eu@felipetonello.com> --- meta-oe/recipes-devtools/protobuf/protobuf_2.6.1.bb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/meta-oe/recipes-devtools/protobuf/protobuf_2.6.1.bb b/meta-oe/recipes-devtools/protobuf/protobuf_2.6.1.bb index 049f9d4e8f18..f52f22aca3e8 100644 --- a/meta-oe/recipes-devtools/protobuf/protobuf_2.6.1.bb +++ b/meta-oe/recipes-devtools/protobuf/protobuf_2.6.1.bb @@ -8,6 +8,8 @@ LICENSE = "BSD-3-Clause" DEPENDS = "zlib" +PACKAGE_BEFORE_PN = "${PN}-compiler" + LIC_FILES_CHKSUM = "file://LICENSE;md5=af6809583bfde9a31595a58bb4a24514" SRCREV = "bba83652e1be610bdb7ee1566ad18346d98b843c" @@ -22,4 +24,6 @@ inherit autotools S = "${WORKDIR}/git" +FILES_${PN}-compiler = "${bindir}" + BBCLASSEXTEND = "native nativesdk" -- 2.8.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 0/2] Protobuf recipes update @ 2016-05-03 15:20 Felipe F. Tonello 2016-05-03 15:20 ` [PATCH 1/2] protobuf: add protobuf-c recipe Felipe F. Tonello 0 siblings, 1 reply; 10+ messages in thread From: Felipe F. Tonello @ 2016-05-03 15:20 UTC (permalink / raw) To: openembedded-devel Added protobuf-c recipe which is the protobuf implementation in C. Also split protobuf package into two packages, one for the run-time libraries and other for the compiler. Felipe F. Tonello (2): protobuf: add protobuf-c recipe protobuf: split package to main and compiler packages .../recipes-devtools/protobuf/protobuf-c_1.2.1.bb | 28 ++++++++++++++++++++++ .../recipes-devtools/protobuf/protobuf_2.6.1.bb | 6 +++++ 2 files changed, 34 insertions(+) create mode 100644 meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb -- 2.8.0 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] protobuf: add protobuf-c recipe 2016-05-03 15:20 [PATCH 0/2] Protobuf recipes update Felipe F. Tonello @ 2016-05-03 15:20 ` Felipe F. Tonello 0 siblings, 0 replies; 10+ messages in thread From: Felipe F. Tonello @ 2016-05-03 15:20 UTC (permalink / raw) To: openembedded-devel replaces/obsoletes: commit 0d31f8448412 [Added protobuf-c criu dependency] in meta-virtualization This version of the recipe also adds a separated package for the compiler. Signed-off-by: Felipe F. Tonello <eu@felipetonello.com> --- .../recipes-devtools/protobuf/protobuf-c_1.2.1.bb | 28 ++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb diff --git a/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb b/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb new file mode 100644 index 000000000000..40fb96cf47bb --- /dev/null +++ b/meta-oe/recipes-devtools/protobuf/protobuf-c_1.2.1.bb @@ -0,0 +1,28 @@ +SUMMARY = "Protocol Buffers - structured data serialisation mechanism" +DESCRIPTION = "This is protobuf-c, a C implementation of the Google Protocol Buffers data \ +serialization format. It includes libprotobuf-c, a pure C library that \ +implements protobuf encoding and decoding, and protoc-c, a code generator that \ +converts Protocol Buffer .proto files to C descriptor code, based on the \ +original protoc. protobuf-c formerly included an RPC implementation; that code \ +has been split out into the protobuf-c-rpc project." +HOMEPAGE = "https://github.com/protobuf-c/protobuf-c" +SECTION = "console/tools" +LICENSE = "BSD-2-Clause" + +DEPENDS = "protobuf-native protobuf" + +PACKAGE_BEFORE_PN = "${PN}-compiler" +RDEPENDS_${PN}-compiler = "protobuf-compiler" +RDEPENDS_${PN}-dev += "${PN}-compiler" + +LIC_FILES_CHKSUM = "file://LICENSE;md5=235c3195a3968524dc1524b4ebea0c0e" +SRC_URI = "https://github.com/protobuf-c/protobuf-c/archive/v${PV}.tar.gz" + +SRC_URI[md5sum] = "b884aeba4283309445a8e3b6e7322dd6" +SRC_URI[sha256sum] = "2d708fb3c024b9e6e86df141faff802194f5db90a4b79e6d4aa6bd61dd983dd6" + +inherit autotools pkgconfig + +FILES_${PN}-compiler = "${bindir}" + +BBCLASSEXTEND = "native nativesdk" -- 2.8.0 ^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-05-03 15:17 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-04-19 15:40 [PATCH 0/2] Protobuf recipes update Felipe F. Tonello 2016-04-19 15:40 ` [PATCH 1/2] protobuf: add protobuf-c recipe Felipe F. Tonello 2016-04-19 19:46 ` Bruce Ashfield 2016-04-19 19:55 ` Bruce Ashfield 2016-04-20 8:32 ` Felipe Ferreri Tonello 2016-04-20 14:32 ` Bruce Ashfield 2016-04-28 8:02 ` Felipe Ferreri Tonello 2016-04-28 13:16 ` Bruce Ashfield 2016-04-19 15:40 ` [PATCH 2/2] protobuf: Split package to main and compiler packages Felipe F. Tonello -- strict thread matches above, loose matches on Subject: below -- 2016-05-03 15:20 [PATCH 0/2] Protobuf recipes update Felipe F. Tonello 2016-05-03 15:20 ` [PATCH 1/2] protobuf: add protobuf-c recipe Felipe F. Tonello
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.