From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
linux-kernel@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org,
Wolfram Sang <wsa@the-dreams.de>, Kukjin Kim <kgene@kernel.org>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] i2c: s3c2410: Check clk_prepare_enable() return value
Date: Wed, 20 Apr 2016 11:02:11 +0200 [thread overview]
Message-ID: <57174593.90307@samsung.com> (raw)
In-Reply-To: <1461096641-19788-2-git-send-email-javier@osg.samsung.com>
On 04/19/2016 10:10 PM, Javier Martinez Canillas wrote:
> The clk_prepare_enable() function can fail so check the return
> value and propagate the error in case of a failure.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/i2c/busses/i2c-s3c2410.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index 4b873fe9a75b..cb40a3af46e7 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -1196,7 +1196,12 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
>
> /* initialise the i2c controller */
>
> - clk_prepare_enable(i2c->clk);
> + ret = clk_prepare_enable(i2c->clk);
> + if (ret) {
> + dev_err(&pdev->dev, "I2C clock enable failed (%d)\n", ret);
Just: "I2C clock enable failed\n"
The probe error code will be printed anyway.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] i2c: s3c2410: Check clk_prepare_enable() return value
Date: Wed, 20 Apr 2016 11:02:11 +0200 [thread overview]
Message-ID: <57174593.90307@samsung.com> (raw)
In-Reply-To: <1461096641-19788-2-git-send-email-javier@osg.samsung.com>
On 04/19/2016 10:10 PM, Javier Martinez Canillas wrote:
> The clk_prepare_enable() function can fail so check the return
> value and propagate the error in case of a failure.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/i2c/busses/i2c-s3c2410.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index 4b873fe9a75b..cb40a3af46e7 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -1196,7 +1196,12 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
>
> /* initialise the i2c controller */
>
> - clk_prepare_enable(i2c->clk);
> + ret = clk_prepare_enable(i2c->clk);
> + if (ret) {
> + dev_err(&pdev->dev, "I2C clock enable failed (%d)\n", ret);
Just: "I2C clock enable failed\n"
The probe error code will be printed anyway.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-04-20 9:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 20:10 [PATCH 1/2] i2c: s3c2410: Print errno code in error logs Javier Martinez Canillas
2016-04-19 20:10 ` Javier Martinez Canillas
2016-04-19 20:10 ` [PATCH 2/2] i2c: s3c2410: Check clk_prepare_enable() return value Javier Martinez Canillas
2016-04-19 20:10 ` Javier Martinez Canillas
2016-04-20 9:02 ` Krzysztof Kozlowski [this message]
2016-04-20 9:02 ` Krzysztof Kozlowski
2016-04-20 9:01 ` [PATCH 1/2] i2c: s3c2410: Print errno code in error logs Krzysztof Kozlowski
2016-04-20 9:01 ` Krzysztof Kozlowski
2016-04-20 13:36 ` Javier Martinez Canillas
2016-04-20 13:36 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57174593.90307@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.