All of lore.kernel.org
 help / color / mirror / Atom feed
From: Allen Pais <allen.pais@oracle.com>
To: Khalid Aziz <khalid.aziz@oracle.com>
Cc: Rob Gardner <rob.gardner@oracle.com>,
	David Miller <davem@davemloft.net>,
	David Aldridge <david.j.aldridge@oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	khalid@gonehiking.org,
	"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
	Nitin Gupta <nitin.m.gupta@oracle.com>
Subject: Re: [PATCH] sparc64: recognize and support Sonoma CPU type
Date: Wed, 20 Apr 2016 15:55:05 +0000	[thread overview]
Message-ID: <5717A63E.9000802@oracle.com> (raw)
In-Reply-To: <CACOOicafDVo6OYWYDCKTJBXGgR-HaAyv6DvrS-ZEG+2mKxTVKw@mail.gmail.com>

> 
> Signed-off-by: Khalid Aziz <khalid.aziz@oracle.com <mailto:khalid.aziz@oracle.com>>
> ---
>  arch/sparc/include/asm/spitfire.h | 1 +
>  arch/sparc/kernel/cpu.c           | 6 ++++++
>  arch/sparc/kernel/cpumap.c        | 1 +
>  arch/sparc/kernel/head_64.S       | 8 ++++++++
>  arch/sparc/kernel/setup_64.c      | 7 ++++++-
>  arch/sparc/mm/init_64.c           | 3 +++
>  6 files changed, 25 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/sparc/include/asm/spitfire.h b/arch/sparc/include/asm/spitfire.h
> index 56f9338..1d8321c 100644
> --- a/arch/sparc/include/asm/spitfire.h
> +++ b/arch/sparc/include/asm/spitfire.h
> @@ -48,6 +48,7 @@
>  #define SUN4V_CHIP_SPARC_M6    0x06
>  #define SUN4V_CHIP_SPARC_M7    0x07
>  #define SUN4V_CHIP_SPARC64X    0x8a
> +#define SUN4V_CHIP_SPARC_SN    0x8b
>  #define SUN4V_CHIP_UNKNOWN     0xff

Looks good to me. Do you think adding these also this patch makes sense or
it could be a separate patch.

        }
-       if (!strcmp(sparc_pmu_type, "sparc-m7")) {
+       if (!strcmp(sparc_pmu_type, "sparc-m7") ||
+           !strcmp(sparc_pmu_type, "sparc-sn")) {
                sparc_pmu = &sparc_m7_pmu;
                return true;

Acked-by: Allen Pais <allen.pais@oracle.com>

- Allen

WARNING: multiple messages have this Message-ID (diff)
From: Allen Pais <allen.pais@oracle.com>
To: Khalid Aziz <khalid.aziz@oracle.com>
Cc: Rob Gardner <rob.gardner@oracle.com>,
	David Miller <davem@davemloft.net>,
	David Aldridge <david.j.aldridge@oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	khalid@gonehiking.org,
	"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
	Nitin Gupta <nitin.m.gupta@oracle.com>
Subject: Re: [PATCH] sparc64: recognize and support Sonoma CPU type
Date: Wed, 20 Apr 2016 21:24:38 +0530	[thread overview]
Message-ID: <5717A63E.9000802@oracle.com> (raw)
In-Reply-To: <CACOOicafDVo6OYWYDCKTJBXGgR-HaAyv6DvrS-ZEG+2mKxTVKw@mail.gmail.com>

> 
> Signed-off-by: Khalid Aziz <khalid.aziz@oracle.com <mailto:khalid.aziz@oracle.com>>
> ---
>  arch/sparc/include/asm/spitfire.h | 1 +
>  arch/sparc/kernel/cpu.c           | 6 ++++++
>  arch/sparc/kernel/cpumap.c        | 1 +
>  arch/sparc/kernel/head_64.S       | 8 ++++++++
>  arch/sparc/kernel/setup_64.c      | 7 ++++++-
>  arch/sparc/mm/init_64.c           | 3 +++
>  6 files changed, 25 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/sparc/include/asm/spitfire.h b/arch/sparc/include/asm/spitfire.h
> index 56f9338..1d8321c 100644
> --- a/arch/sparc/include/asm/spitfire.h
> +++ b/arch/sparc/include/asm/spitfire.h
> @@ -48,6 +48,7 @@
>  #define SUN4V_CHIP_SPARC_M6    0x06
>  #define SUN4V_CHIP_SPARC_M7    0x07
>  #define SUN4V_CHIP_SPARC64X    0x8a
> +#define SUN4V_CHIP_SPARC_SN    0x8b
>  #define SUN4V_CHIP_UNKNOWN     0xff

Looks good to me. Do you think adding these also this patch makes sense or
it could be a separate patch.

        }
-       if (!strcmp(sparc_pmu_type, "sparc-m7")) {
+       if (!strcmp(sparc_pmu_type, "sparc-m7") ||
+           !strcmp(sparc_pmu_type, "sparc-sn")) {
                sparc_pmu = &sparc_m7_pmu;
                return true;

Acked-by: Allen Pais <allen.pais@oracle.com>

- Allen

  parent reply	other threads:[~2016-04-20 15:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-19 17:12 [PATCH] sparc64: recognize and support Sonoma CPU type Khalid Aziz
2016-04-19 17:12 ` Khalid Aziz
     [not found] ` <CACOOicafDVo6OYWYDCKTJBXGgR-HaAyv6DvrS-ZEG+2mKxTVKw@mail.gmail.com>
2016-04-20 15:54   ` Allen Pais [this message]
2016-04-20 15:55     ` Allen Pais
2016-04-20 16:02     ` Khalid Aziz
2016-04-20 16:02       ` Khalid Aziz
2016-04-27 20:39 ` David Miller
2016-04-27 20:39   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5717A63E.9000802@oracle.com \
    --to=allen.pais@oracle.com \
    --cc=davem@davemloft.net \
    --cc=david.j.aldridge@oracle.com \
    --cc=khalid.aziz@oracle.com \
    --cc=khalid@gonehiking.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nitin.m.gupta@oracle.com \
    --cc=rob.gardner@oracle.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.