From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Track the previous pinned context inside the request
Date: Wed, 20 Apr 2016 17:34:19 +0100 [thread overview]
Message-ID: <5717AF8B.7020006@linux.intel.com> (raw)
In-Reply-To: <20160420142228.GD17454@nuc-i3427.alporthouse.com>
On 20/04/16 15:22, Chris Wilson wrote:
> On Wed, Apr 20, 2016 at 03:08:19PM +0100, Tvrtko Ursulin wrote:
>> Otherwise execlists_check_remove_request when accessing
>> head_req->ctx is use after free. And I can demonstrate that easily
>> via gem-close-race. Put a
>> WARN_ON(atomic_read(&head_req->ctx->ref.refcount) == 0); and see. :)
>
> More to the point, could we do a 10s burst of close race for BAT. What's
> the likelihood of that capturing such faults?
> With lockdep/kmemcheck etc enabled?
No idea, but on a lean kernel it takes a lot less than 10s. So maybe
time limited gem-close-race-basic, resend your series and see if it
catches it?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-04-20 16:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 11:40 Premature unpinning Chris Wilson
2016-04-19 11:40 ` [PATCH v2 01/12] drm/i915: Mark the current context as lost on suspend Chris Wilson
2016-04-19 14:12 ` [PATCH v2] " Chris Wilson
2016-04-19 14:20 ` Mika Kuoppala
2016-04-19 11:40 ` [PATCH v2 02/12] drm/i915: L3 cache remapping is part of context switching Chris Wilson
2016-04-19 11:40 ` [PATCH v2 03/12] drm/i915: Consolidate L3 remapping LRI Chris Wilson
2016-04-19 11:40 ` [PATCH v2 04/12] drm/i915: Remove early l3-remap Chris Wilson
2016-04-19 11:40 ` [PATCH v2 05/12] drm/i915: Rearrange switch_context to load the aliasing ppgtt on first use Chris Wilson
2016-04-19 11:40 ` [PATCH v2 06/12] drm/i915: Assign every HW context a unique ID Chris Wilson
2016-04-19 11:40 ` [PATCH v2 07/12] drm/i915: Replace the pinned context address with its " Chris Wilson
2016-04-19 11:40 ` [PATCH v2 08/12] drm/i915: Refactor execlists default context pinning Chris Wilson
2016-04-19 12:25 ` Tvrtko Ursulin
2016-04-20 14:07 ` Mika Kuoppala
2016-04-19 11:40 ` [PATCH v2 09/12] drm/i915: Move context initialisation to first-use Chris Wilson
2016-04-19 11:40 ` [PATCH v2 10/12] drm/i915: Move the magical deferred context allocation into the request Chris Wilson
2016-04-19 12:40 ` kbuild test robot
2016-04-19 11:40 ` [PATCH v2 11/12] drm/i915: Track the previous pinned context inside " Chris Wilson
2016-04-19 11:40 ` [PATCH v2 12/12] drm/i915: Move releasing of the GEM request from free to retire/cancel Chris Wilson
2016-04-19 12:59 ` Update to patches 11 and 12 Chris Wilson
2016-04-19 12:59 ` [PATCH 1/2] drm/i915: Move releasing of the GEM request from free to retire/cancel Chris Wilson
2016-04-20 13:55 ` Tvrtko Ursulin
2016-04-19 12:59 ` [PATCH 2/2] drm/i915: Track the previous pinned context inside the request Chris Wilson
2016-04-20 14:08 ` Tvrtko Ursulin
2016-04-20 14:18 ` Chris Wilson
2016-04-20 14:22 ` Chris Wilson
2016-04-20 16:34 ` Tvrtko Ursulin [this message]
2016-04-20 14:24 ` [RFC 1/2] drm/i915: Store LRC hardware id in " Tvrtko Ursulin
2016-04-20 14:24 ` [RFC 2/2] drm/i915: Stop tracking execlists retired requests Tvrtko Ursulin
2016-04-20 18:15 ` [RFC 1/2] drm/i915: Store LRC hardware id in the request Chris Wilson
2016-04-19 13:24 ` ✗ Fi.CI.BAT: failure for series starting with [v2,01/12] drm/i915: Mark the current context as lost on suspend Patchwork
2016-04-19 14:58 ` ✗ Fi.CI.BAT: failure for series starting with [v2] drm/i915: Mark the current context as lost on suspend (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5717AF8B.7020006@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.