From: sergio.prado@e-labworks.com (Sergio Prado)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: imx6: Add dts for Embest MarS Board
Date: Wed, 20 Apr 2016 16:41:46 -0300 [thread overview]
Message-ID: <5717DB7A.4030406@e-labworks.com> (raw)
In-Reply-To: <CAOMZO5AKdFtCZJSFg5ZJ2j8MBta_s=HSNBaH5a9zoTdkwQ477Q@mail.gmail.com>
Hi Fabio,
On 19-04-2016 08:34, Fabio Estevam wrote:
> On Mon, Apr 11, 2016 at 9:25 PM, Sergio Prado
> <sergio.prado@e-labworks.com> wrote:
>
>> +&fec {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_enet>;
>> + phy-mode = "rgmii";
>> + phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_HIGH>;
>
> Are you sure this is really active high?
>
You are right. Although the ethernet interface did work that way, the
reset pin is active low. I will fix in V3.
Best regards,
Sergio Prado
WARNING: multiple messages have this Message-ID (diff)
From: Sergio Prado <sergio.prado@e-labworks.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: imx6: Add dts for Embest MarS Board
Date: Wed, 20 Apr 2016 16:41:46 -0300 [thread overview]
Message-ID: <5717DB7A.4030406@e-labworks.com> (raw)
In-Reply-To: <CAOMZO5AKdFtCZJSFg5ZJ2j8MBta_s=HSNBaH5a9zoTdkwQ477Q@mail.gmail.com>
Hi Fabio,
On 19-04-2016 08:34, Fabio Estevam wrote:
> On Mon, Apr 11, 2016 at 9:25 PM, Sergio Prado
> <sergio.prado@e-labworks.com> wrote:
>
>> +&fec {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_enet>;
>> + phy-mode = "rgmii";
>> + phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_HIGH>;
>
> Are you sure this is really active high?
>
You are right. Although the ethernet interface did work that way, the
reset pin is active low. I will fix in V3.
Best regards,
Sergio Prado
next prev parent reply other threads:[~2016-04-20 19:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 0:25 [PATCH v2] ARM: dts: imx6: Add dts for Embest MarS Board Sergio Prado
2016-04-12 0:25 ` Sergio Prado
2016-04-12 0:25 ` Sergio Prado
2016-04-12 1:04 ` Fabio Estevam
2016-04-12 1:04 ` Fabio Estevam
2016-04-12 1:04 ` Fabio Estevam
2016-04-13 20:58 ` Sergio Prado
2016-04-13 20:58 ` Sergio Prado
2016-04-13 20:58 ` Sergio Prado
2016-04-19 11:22 ` Fabio Estevam
2016-04-19 11:22 ` Fabio Estevam
2016-04-19 11:22 ` Fabio Estevam
2016-04-12 14:06 ` Vladimir Zapolskiy
2016-04-12 14:06 ` Vladimir Zapolskiy
2016-04-12 14:06 ` Vladimir Zapolskiy
2016-04-13 19:08 ` Sergio Prado
2016-04-19 11:30 ` Fabio Estevam
2016-04-19 11:30 ` Fabio Estevam
2016-04-19 11:30 ` Fabio Estevam
2016-04-19 11:34 ` Fabio Estevam
2016-04-19 11:34 ` Fabio Estevam
2016-04-19 11:34 ` Fabio Estevam
2016-04-20 19:41 ` Sergio Prado [this message]
2016-04-20 19:41 ` Sergio Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5717DB7A.4030406@e-labworks.com \
--to=sergio.prado@e-labworks.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.