From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
linux-kernel@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org,
Wolfram Sang <wsa@the-dreams.de>, Kukjin Kim <kgene@kernel.org>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value
Date: Thu, 21 Apr 2016 09:19:39 +0200 [thread overview]
Message-ID: <57187F0B.3000002@samsung.com> (raw)
In-Reply-To: <1461163076-5959-2-git-send-email-javier@osg.samsung.com>
On 04/20/2016 04:37 PM, Javier Martinez Canillas wrote:
> The clk_prepare_enable() function can fail so check the return
> value and propagate the error in case of a failure.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Changes in v2:
> - Don't print the errno code since that's already printed by the
> core when probe fails. Suggested by Krzysztof Kozlowski.
>
> drivers/i2c/busses/i2c-s3c2410.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested on Trats2 (Exynos4412, samsung,s3c2440-i2c)
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value
Date: Thu, 21 Apr 2016 09:19:39 +0200 [thread overview]
Message-ID: <57187F0B.3000002@samsung.com> (raw)
In-Reply-To: <1461163076-5959-2-git-send-email-javier@osg.samsung.com>
On 04/20/2016 04:37 PM, Javier Martinez Canillas wrote:
> The clk_prepare_enable() function can fail so check the return
> value and propagate the error in case of a failure.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Changes in v2:
> - Don't print the errno code since that's already printed by the
> core when probe fails. Suggested by Krzysztof Kozlowski.
>
> drivers/i2c/busses/i2c-s3c2410.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested on Trats2 (Exynos4412, samsung,s3c2440-i2c)
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-04-21 7:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 14:37 [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs Javier Martinez Canillas
2016-04-20 14:37 ` Javier Martinez Canillas
2016-04-20 14:37 ` [PATCH v2 2/2] i2c: s3c2410: Check clk_prepare_enable() return value Javier Martinez Canillas
2016-04-20 14:37 ` Javier Martinez Canillas
2016-04-21 7:19 ` Krzysztof Kozlowski [this message]
2016-04-21 7:19 ` Krzysztof Kozlowski
2016-04-25 22:20 ` Wolfram Sang
2016-04-25 22:20 ` Wolfram Sang
2016-04-21 7:18 ` [PATCH v2 1/2] i2c: s3c2410: Print errno code in error logs Krzysztof Kozlowski
2016-04-21 7:18 ` Krzysztof Kozlowski
2016-04-25 22:20 ` Wolfram Sang
2016-04-25 22:20 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57187F0B.3000002@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.