From: Matthias Brugger <matthias.bgg@gmail.com>
To: PC Liao <pc.liao@mediatek.com>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"tiwai@suse.de" <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
srv_heupstream <srv_heupstream@mediatek.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Koro Chen (陳思翰)" <koro.chen@mediatek.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver
Date: Thu, 21 Apr 2016 11:22:25 +0200 [thread overview]
Message-ID: <57189BD1.40109@gmail.com> (raw)
In-Reply-To: <1461169664.8479.1.camel@mtksdaap41>
On 20/04/16 18:27, PC Liao wrote:
> Hi Matthias,
>
> On Wed, 2016-04-20 at 21:30 +0800, Matthias Brugger wrote:
>>
>> For compatibility you should change this to something like:
>>
>> dev_warn(card->dev, "Only one dai codec found in DTS, enabled rt5645
>> AD filter\n");
>> rt5645_sel_asrc_clk_src(codec, RT5645_AD_STEREO_FILTER,
>> RT5645_CLK_SEL_I2S1_ASRC);
>> }
>>
>
> I will use this in next version.
> Thanks!
>
I think you forgot to add this to v7 of the patches.
Cheers,
Matthias
WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver
Date: Thu, 21 Apr 2016 11:22:25 +0200 [thread overview]
Message-ID: <57189BD1.40109@gmail.com> (raw)
In-Reply-To: <1461169664.8479.1.camel@mtksdaap41>
On 20/04/16 18:27, PC Liao wrote:
> Hi Matthias,
>
> On Wed, 2016-04-20 at 21:30 +0800, Matthias Brugger wrote:
>>
>> For compatibility you should change this to something like:
>>
>> dev_warn(card->dev, "Only one dai codec found in DTS, enabled rt5645
>> AD filter\n");
>> rt5645_sel_asrc_clk_src(codec, RT5645_AD_STEREO_FILTER,
>> RT5645_CLK_SEL_I2S1_ASRC);
>> }
>>
>
> I will use this in next version.
> Thanks!
>
I think you forgot to add this to v7 of the patches.
Cheers,
Matthias
next prev parent reply other threads:[~2016-04-21 9:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 6:40 [PATCH 0/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver PC Liao
2016-04-20 6:40 ` PC Liao
2016-04-20 6:40 ` PC Liao
2016-04-20 6:40 ` [PATCH 1/2 v6] ASoC: core: export snd_soc_get_dai_name PC Liao
2016-04-20 6:40 ` PC Liao
2016-04-20 6:40 ` PC Liao
2016-04-20 6:40 ` [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver PC Liao
2016-04-20 6:40 ` PC Liao
2016-04-20 6:40 ` PC Liao
2016-04-20 8:29 ` Mark Brown
2016-04-20 8:29 ` Mark Brown
2016-04-20 8:29 ` Mark Brown
2016-04-20 9:39 ` PC Liao
2016-04-20 9:39 ` PC Liao
2016-04-20 16:11 ` Mark Brown
2016-04-20 16:11 ` Mark Brown
2016-04-20 13:30 ` Matthias Brugger
2016-04-20 13:30 ` Matthias Brugger
2016-04-20 16:27 ` PC Liao
2016-04-20 16:27 ` PC Liao
2016-04-20 16:27 ` PC Liao
2016-04-21 9:22 ` Matthias Brugger [this message]
2016-04-21 9:22 ` Matthias Brugger
2016-04-21 9:38 ` PC Liao
2016-04-21 9:38 ` PC Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57189BD1.40109@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=koro.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=pc.liao@mediatek.com \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.