All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Huang, Tao" <huangtao@rock-chips.com>
To: "Doug Anderson" <dianders@chromium.org>,
	"Heiko Stübner" <heiko@sntech.de>
Cc: Jianqun Xu <jay.xu@rock-chips.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	David Riley <davidriley@chromium.org>,
	Julius Werner <jwerner@chromium.org>,
	smbarber@chromium.org,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs
Date: Fri, 22 Apr 2016 12:23:06 +0800	[thread overview]
Message-ID: <5719A72A.4070603@rock-chips.com> (raw)
In-Reply-To: <CAD=FV=X9S4z2WLEJ-KaaCZxfkdO4+-i2hUd3dsYJi5qXEvpVBQ@mail.gmail.com>

Hi, Doug:
On 2016年04月22日 06:38, Doug Anderson wrote:
>
>>> +     i2c1: i2c@ff110000 {
>>> +             compatible = "rockchip,rk3399-i2c";
>> David respun the rk3399 i2c-support on tuesday, so this and the others below
>> are waiting on Wolfram to take a look.
> I think it can work with the rk3288-i2c as a fallback, at least for
> low speed stuff, right?  Should this be:
>
> compatible = "rockchip,rk3399-i2c", "rockchip,rk3288-i2c"
>
> Looks like that was done for rk3368.
No. For RK3399 I2C controller:
The I2C controller uses the APB clock/clk_i2c as the working clock. The
APB clock will determine the I2C bus clock, clk_i2c is the function clk,
up to 200MHz.
Chips such as RK3288/3368 only uses APB clock. So old driver do not work
on RK3399.

Thanks,
Huang, Tao

WARNING: multiple messages have this Message-ID (diff)
From: huangtao@rock-chips.com (Huang, Tao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs
Date: Fri, 22 Apr 2016 12:23:06 +0800	[thread overview]
Message-ID: <5719A72A.4070603@rock-chips.com> (raw)
In-Reply-To: <CAD=FV=X9S4z2WLEJ-KaaCZxfkdO4+-i2hUd3dsYJi5qXEvpVBQ@mail.gmail.com>

Hi, Doug:
On 2016?04?22? 06:38, Doug Anderson wrote:
>
>>> +     i2c1: i2c at ff110000 {
>>> +             compatible = "rockchip,rk3399-i2c";
>> David respun the rk3399 i2c-support on tuesday, so this and the others below
>> are waiting on Wolfram to take a look.
> I think it can work with the rk3288-i2c as a fallback, at least for
> low speed stuff, right?  Should this be:
>
> compatible = "rockchip,rk3399-i2c", "rockchip,rk3288-i2c"
>
> Looks like that was done for rk3368.
No. For RK3399 I2C controller:
The I2C controller uses the APB clock/clk_i2c as the working clock. The
APB clock will determine the I2C bus clock, clk_i2c is the function clk,
up to 200MHz.
Chips such as RK3288/3368 only uses APB clock. So old driver do not work
on RK3399.

Thanks,
Huang, Tao

  parent reply	other threads:[~2016-04-22  4:23 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-20  3:15 [PATCH] ARM64: dts: rockchip: add core dtsi file for rk3399 SoCs Jianqun Xu
2016-04-20  3:15 ` Jianqun Xu
2016-04-20  3:15 ` Jianqun Xu
2016-04-21  3:58 ` [PATCH] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs Jianqun Xu
2016-04-21  3:58   ` Jianqun Xu
2016-04-21 10:19   ` Mark Rutland
2016-04-21 10:19     ` Mark Rutland
2016-04-21 10:47     ` Huang, Tao
2016-04-21 10:47       ` Huang, Tao
     [not found]       ` <5718AFB8.5070004-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-04-21 11:30         ` Marc Zyngier
2016-04-21 11:30           ` Marc Zyngier
2016-04-21 11:30           ` Marc Zyngier
     [not found]           ` <20160421123018.096d4a75-5wv7dgnIgG8@public.gmane.org>
2016-04-21 20:24             ` Heiko Stübner
2016-04-21 20:24               ` Heiko Stübner
2016-04-21 20:24               ` Heiko Stübner
2016-04-21 21:12               ` Marc Zyngier
2016-04-21 21:12                 ` Marc Zyngier
2016-04-21 21:12                 ` Marc Zyngier
2016-04-22  1:50                 ` jay.xu
2016-04-22  1:50                   ` jay.xu
     [not found]                   ` <57198351.2060608-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-04-22  7:44                     ` Marc Zyngier
2016-04-22  7:44                       ` Marc Zyngier
2016-04-22  7:44                       ` Marc Zyngier
2016-04-25  9:48             ` Huang, Tao
2016-04-25  9:48               ` Huang, Tao
2016-04-25  9:48               ` Huang, Tao
     [not found]               ` <571DE803.3010902-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-04-25 10:05                 ` Mark Rutland
2016-04-25 10:05                   ` Mark Rutland
2016-04-25 10:05                   ` Mark Rutland
2016-04-25 10:19                   ` Huang, Tao
2016-04-25 10:19                     ` Huang, Tao
     [not found]                     ` <571DEF30.90604-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-04-25 10:47                       ` Mark Rutland
2016-04-25 10:47                         ` Mark Rutland
2016-04-25 10:47                         ` Mark Rutland
2016-04-25 12:27                         ` Huang, Tao
2016-04-25 12:27                           ` Huang, Tao
2016-04-25 12:27                           ` Huang, Tao
2016-04-25 10:06                 ` Marc Zyngier
2016-04-25 10:06                   ` Marc Zyngier
2016-04-25 10:06                   ` Marc Zyngier
2016-04-25 10:39                   ` Marc Zyngier
2016-04-25 10:39                     ` Marc Zyngier
2016-04-25 10:39                     ` Marc Zyngier
     [not found]                     ` <571DF3CB.3030904-5wv7dgnIgG8@public.gmane.org>
2016-04-25 11:50                       ` Huang, Tao
2016-04-25 11:50                         ` Huang, Tao
2016-04-25 11:50                         ` Huang, Tao
     [not found]                         ` <571E0489.3030401-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-04-25 12:04                           ` Marc Zyngier
2016-04-25 12:04                             ` Marc Zyngier
2016-04-25 12:04                             ` Marc Zyngier
     [not found]   ` <1461211092-26331-1-git-send-email-jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-04-21 21:02     ` Rob Herring
2016-04-21 21:02       ` Rob Herring
2016-04-21 21:02       ` Rob Herring
2016-04-21 22:02     ` Heiko Stübner
2016-04-21 22:02       ` Heiko Stübner
2016-04-21 22:02       ` Heiko Stübner
2016-04-21 22:38       ` Doug Anderson
2016-04-21 22:38         ` Doug Anderson
2016-04-21 22:38         ` Doug Anderson
     [not found]         ` <CAD=FV=X9S4z2WLEJ-KaaCZxfkdO4+-i2hUd3dsYJi5qXEvpVBQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-21 22:49           ` Heiko Stübner
2016-04-21 22:49             ` Heiko Stübner
2016-04-21 22:49             ` Heiko Stübner
2016-04-22  4:23         ` Huang, Tao [this message]
2016-04-22  4:23           ` Huang, Tao
     [not found] ` <1461122150-9042-1-git-send-email-jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-04-21 21:48   ` [PATCH] ARM64: dts: rockchip: add core dtsi file for rk3399 SoCs Brian Norris
2016-04-21 21:48     ` Brian Norris
2016-04-21 21:48     ` Brian Norris
2016-04-21 22:32     ` Heiko Stübner
2016-04-21 22:32       ` Heiko Stübner
2016-04-22  5:21   ` [PATCH v2 0/4] ARM64: dts: rockchip: add support for RK3399 Jianqun Xu
2016-04-22  5:21     ` Jianqun Xu
2016-04-22  5:21     ` Jianqun Xu
2016-04-22  5:25   ` [PATCH v2 1/4] Documentation: rockchip-dw-mshc: add description for rk3399 Jianqun Xu
2016-04-22  5:25     ` Jianqun Xu
2016-04-22  5:25     ` Jianqun Xu
2016-04-22  5:28   ` [PATCH v2 2/4] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs Jianqun Xu
2016-04-22  5:28     ` Jianqun Xu
2016-04-22  5:28     ` Jianqun Xu
2016-04-22  5:31   ` [PATCH 3/4] ARM64: dts: rockchip: add RK3399 evaluation board Jianqun Xu
2016-04-22  5:31     ` Jianqun Xu
2016-04-22  5:31     ` Jianqun Xu
2016-04-22  5:36   ` [PATCH v2 4/4] ARM64: dts: rockchip: add dts file for " Jianqun Xu
2016-04-22  5:36     ` Jianqun Xu
2016-04-22  5:36     ` Jianqun Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5719A72A.4070603@rock-chips.com \
    --to=huangtao@rock-chips.com \
    --cc=catalin.marinas@arm.com \
    --cc=davidriley@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=galak@codeaurora.org \
    --cc=heiko@sntech.de \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jay.xu@rock-chips.com \
    --cc=jwerner@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=smbarber@chromium.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.