[PATCH] webkitgtk: package debug files properly and move -g removal to staging

[PATCH] webkitgtk: package debug files properly and move -g removal to staging

[Sujith Haridasan]

From: Fahad Usman <fahad_usman@mentor.com>

Package debug files properly to get rid of build time warnings.
Remove -g option from the DEBUG_FLAGS.

Signed-off-by: Fahad Usman <fahad_usman@mentor.com>
Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Sujith Haridasan <Sujith_Haridasan@mentor.com>
---
 meta/recipes-sato/webkit/webkitgtk_2.10.7.bb | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/meta/recipes-sato/webkit/webkitgtk_2.10.7.bb b/meta/recipes-sato/webkit/webkitgtk_2.10.7.bb
index 8eb6b9f..49fa0bb 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.10.7.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.10.7.bb
@@ -75,7 +75,13 @@ EXTRA_OECMAKE_append_aarch64 = " -DUSE_LD_GOLD=OFF "
 EXTRA_OECMAKE_append_mips = " -DENABLE_JIT=OFF "
 EXTRA_OECMAKE_append_mips64 = " -DENABLE_JIT=OFF "
 
+# Link fails due to memory exhaustion, so disable debug info to reduce the
+# memory footprint
+DEBUG_FLAGS_remove = "-g"
+
 FILES_${PN} += "${libdir}/webkit2gtk-4.0/injected-bundle/libwebkit2gtkinjectedbundle.so"
+FILES_${PN}-dbg += "${libdir}/webkit2gtk-4.0/injected-bundle/.debug \
+                    ${libdir}/webkitgtk/webkit2gtk-4.0/.debug/*"
 
 # http://errors.yoctoproject.org/Errors/Details/20370/
 ARM_INSTRUCTION_SET = "arm"
-- 
1.9.1

Re: [PATCH] webkitgtk: package debug files properly and move -g removal to staging

[Alexander Kanavin]

On 04/22/2016 03:41 PM, Sujith Haridasan wrote:

> +# Link fails due to memory exhaustion, so disable debug info to reduce the
> +# memory footprint
> +DEBUG_FLAGS_remove = "-g"
> +

Wait a moment, if you do this then the debug package will be totally 
useless, no?

>   FILES_${PN} += "${libdir}/webkit2gtk-4.0/injected-bundle/libwebkit2gtkinjectedbundle.so"
> +FILES_${PN}-dbg += "${libdir}/webkit2gtk-4.0/injected-bundle/.debug \
> +                    ${libdir}/webkitgtk/webkit2gtk-4.0/.debug/*"

What problem does this addition solve specifically?

Alex

Re: [PATCH] webkitgtk: package debug files properly and move -g removal to staging

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

On 22 April 2016 at 13:41, Sujith Haridasan <sujith.h@gmail.com> wrote:

> +FILES_${PN}-dbg += "${libdir}/webkit2gtk-4.0/injected-bundle/.debug \
> +                    ${libdir}/webkitgtk/webkit2gtk-4.0/.debug/*"
>

Debug packages are collected automatically, no need for FILES_PN-dbg
anymore unless you want to package something that isn't .debug/.

Please verify patches against master when submitting!

Ross

[-- Attachment #2: Type: text/html, Size: 954 bytes --]

Re: [PATCH] webkitgtk: package debug files properly and move -g removal to staging

[sujith h]

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]

On Fri, Apr 22, 2016 at 6:28 PM, Burton, Ross <ross.burton@intel.com> wrote:

>
> On 22 April 2016 at 13:41, Sujith Haridasan <sujith.h@gmail.com> wrote:
>
>> +FILES_${PN}-dbg += "${libdir}/webkit2gtk-4.0/injected-bundle/.debug \
>> +                    ${libdir}/webkitgtk/webkit2gtk-4.0/.debug/*"
>>
>
> Debug packages are collected automatically, no need for FILES_PN-dbg
> anymore unless you want to package something that isn't .debug/.
>
> Please verify patches against master when submitting!
>

Apologies for the inconvenience caused. This patch shouldn't have been sent
for review.

>
> Ross
>



-- 
സുജിത് ഹരിദാസന്
Bangalore
<Project>Contributor to KDE project
<Project>Contributor to Yocto project
http://fci.wikia.com/wiki/Anti-DRM-Campaign
<Blog> http://sujithh.info
C-x C-c

[-- Attachment #2: Type: text/html, Size: 2183 bytes --]