* [PATCH] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios @ 2016-04-22 15:10 Geert Uytterhoeven 2016-04-22 18:32 ` Peter Hurley 2016-04-27 8:20 ` Richard Genoud 0 siblings, 2 replies; 5+ messages in thread From: Geert Uytterhoeven @ 2016-04-22 15:10 UTC (permalink / raw) To: Greg Kroah-Hartman, Jiri Slaby Cc: Peter Hurley, Richard Genoud, Arnd Bergmann, linux-serial, linux-kernel, Geert Uytterhoeven The OUT1 and OUT2 pins present on some legacy UARTs are basically GPIOs. It doesn't make much sense to emulate GPIOs using other GPIOs, hence drop support for that. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/tty/serial/serial_mctrl_gpio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c index 02147361eaa94747..821ffa637eb630cb 100644 --- a/drivers/tty/serial/serial_mctrl_gpio.c +++ b/drivers/tty/serial/serial_mctrl_gpio.c @@ -43,8 +43,6 @@ static const struct { { "rng", TIOCM_RNG, false, }, { "rts", TIOCM_RTS, true, }, { "dtr", TIOCM_DTR, true, }, - { "out1", TIOCM_OUT1, true, }, - { "out2", TIOCM_OUT2, true, }, }; void mctrl_gpio_set(struct mctrl_gpios *gpios, unsigned int mctrl) -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios 2016-04-22 15:10 [PATCH] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios Geert Uytterhoeven @ 2016-04-22 18:32 ` Peter Hurley 2016-04-27 8:20 ` Richard Genoud 1 sibling, 0 replies; 5+ messages in thread From: Peter Hurley @ 2016-04-22 18:32 UTC (permalink / raw) To: Geert Uytterhoeven, Greg Kroah-Hartman, Jiri Slaby Cc: Richard Genoud, Arnd Bergmann, linux-serial, linux-kernel On 04/22/2016 08:10 AM, Geert Uytterhoeven wrote: > The OUT1 and OUT2 pins present on some legacy UARTs are basically GPIOs. > It doesn't make much sense to emulate GPIOs using other GPIOs, hence > drop support for that. Thanks Geert. Reviewed-by: Peter Hurley <peter@hurleysoftware.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios 2016-04-22 15:10 [PATCH] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios Geert Uytterhoeven 2016-04-22 18:32 ` Peter Hurley @ 2016-04-27 8:20 ` Richard Genoud 2016-04-28 8:35 ` Geert Uytterhoeven 1 sibling, 1 reply; 5+ messages in thread From: Richard Genoud @ 2016-04-27 8:20 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Greg Kroah-Hartman, Jiri Slaby, Peter Hurley, Arnd Bergmann, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org 2016-04-22 17:10 GMT+02:00 Geert Uytterhoeven <geert+renesas@glider.be>: > The OUT1 and OUT2 pins present on some legacy UARTs are basically GPIOs. > It doesn't make much sense to emulate GPIOs using other GPIOs, hence > drop support for that. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/tty/serial/serial_mctrl_gpio.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c > index 02147361eaa94747..821ffa637eb630cb 100644 > --- a/drivers/tty/serial/serial_mctrl_gpio.c > +++ b/drivers/tty/serial/serial_mctrl_gpio.c > @@ -43,8 +43,6 @@ static const struct { > { "rng", TIOCM_RNG, false, }, > { "rts", TIOCM_RTS, true, }, > { "dtr", TIOCM_DTR, true, }, > - { "out1", TIOCM_OUT1, true, }, > - { "out2", TIOCM_OUT2, true, }, > }; > > void mctrl_gpio_set(struct mctrl_gpios *gpios, unsigned int mctrl) > -- > 1.9.1 > Maybe I missed something, but I think you want to remove UART_GPIO_OUT{1,2} also : diff --git a/drivers/tty/serial/serial_mctrl_gpio.h b/drivers/tty/serial/serial_mctrl_gpio.h index 9716db283290..10632e72b89f 100644 --- a/drivers/tty/serial/serial_mctrl_gpio.h +++ b/drivers/tty/serial/serial_mctrl_gpio.h @@ -32,8 +32,6 @@ enum mctrl_gpio_idx { UART_GPIO_RI = UART_GPIO_RNG, UART_GPIO_RTS, UART_GPIO_DTR, - UART_GPIO_OUT1, - UART_GPIO_OUT2, UART_GPIO_MAX, }; Richard. ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios 2016-04-27 8:20 ` Richard Genoud @ 2016-04-28 8:35 ` Geert Uytterhoeven 0 siblings, 0 replies; 5+ messages in thread From: Geert Uytterhoeven @ 2016-04-28 8:35 UTC (permalink / raw) To: Richard Genoud Cc: Geert Uytterhoeven, Greg Kroah-Hartman, Jiri Slaby, Peter Hurley, Arnd Bergmann, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Hi Richard, On Wed, Apr 27, 2016 at 10:20 AM, Richard Genoud <richard.genoud@gmail.com> wrote: > 2016-04-22 17:10 GMT+02:00 Geert Uytterhoeven <geert+renesas@glider.be>: >> The OUT1 and OUT2 pins present on some legacy UARTs are basically GPIOs. >> It doesn't make much sense to emulate GPIOs using other GPIOs, hence >> drop support for that. >> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >> --- >> drivers/tty/serial/serial_mctrl_gpio.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c >> index 02147361eaa94747..821ffa637eb630cb 100644 >> --- a/drivers/tty/serial/serial_mctrl_gpio.c >> +++ b/drivers/tty/serial/serial_mctrl_gpio.c >> @@ -43,8 +43,6 @@ static const struct { >> { "rng", TIOCM_RNG, false, }, >> { "rts", TIOCM_RTS, true, }, >> { "dtr", TIOCM_DTR, true, }, >> - { "out1", TIOCM_OUT1, true, }, >> - { "out2", TIOCM_OUT2, true, }, >> }; >> >> void mctrl_gpio_set(struct mctrl_gpios *gpios, unsigned int mctrl) >> -- >> 1.9.1 >> > Maybe I missed something, but I think you want to remove > UART_GPIO_OUT{1,2} also : > diff --git a/drivers/tty/serial/serial_mctrl_gpio.h > b/drivers/tty/serial/serial_mctrl_gpio.h > index 9716db283290..10632e72b89f 100644 > --- a/drivers/tty/serial/serial_mctrl_gpio.h > +++ b/drivers/tty/serial/serial_mctrl_gpio.h > @@ -32,8 +32,6 @@ enum mctrl_gpio_idx { > UART_GPIO_RI = UART_GPIO_RNG, > UART_GPIO_RTS, > UART_GPIO_DTR, > - UART_GPIO_OUT1, > - UART_GPIO_OUT2, > UART_GPIO_MAX, > }; Thanks! Doh, I knew one day these seemingly unused enum values would get out of sync wr.t. the code. Will fix in v2... Gr{oetje,eeting}s, Geert ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios @ 2016-04-28 8:35 ` Geert Uytterhoeven 0 siblings, 0 replies; 5+ messages in thread From: Geert Uytterhoeven @ 2016-04-28 8:35 UTC (permalink / raw) To: Richard Genoud Cc: Geert Uytterhoeven, Greg Kroah-Hartman, Jiri Slaby, Peter Hurley, Arnd Bergmann, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Hi Richard, On Wed, Apr 27, 2016 at 10:20 AM, Richard Genoud <richard.genoud@gmail.com> wrote: > 2016-04-22 17:10 GMT+02:00 Geert Uytterhoeven <geert+renesas@glider.be>: >> The OUT1 and OUT2 pins present on some legacy UARTs are basically GPIOs. >> It doesn't make much sense to emulate GPIOs using other GPIOs, hence >> drop support for that. >> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >> --- >> drivers/tty/serial/serial_mctrl_gpio.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c >> index 02147361eaa94747..821ffa637eb630cb 100644 >> --- a/drivers/tty/serial/serial_mctrl_gpio.c >> +++ b/drivers/tty/serial/serial_mctrl_gpio.c >> @@ -43,8 +43,6 @@ static const struct { >> { "rng", TIOCM_RNG, false, }, >> { "rts", TIOCM_RTS, true, }, >> { "dtr", TIOCM_DTR, true, }, >> - { "out1", TIOCM_OUT1, true, }, >> - { "out2", TIOCM_OUT2, true, }, >> }; >> >> void mctrl_gpio_set(struct mctrl_gpios *gpios, unsigned int mctrl) >> -- >> 1.9.1 >> > Maybe I missed something, but I think you want to remove > UART_GPIO_OUT{1,2} also : > diff --git a/drivers/tty/serial/serial_mctrl_gpio.h > b/drivers/tty/serial/serial_mctrl_gpio.h > index 9716db283290..10632e72b89f 100644 > --- a/drivers/tty/serial/serial_mctrl_gpio.h > +++ b/drivers/tty/serial/serial_mctrl_gpio.h > @@ -32,8 +32,6 @@ enum mctrl_gpio_idx { > UART_GPIO_RI = UART_GPIO_RNG, > UART_GPIO_RTS, > UART_GPIO_DTR, > - UART_GPIO_OUT1, > - UART_GPIO_OUT2, > UART_GPIO_MAX, > }; Thanks! Doh, I knew one day these seemingly unused enum values would get out of sync wr.t. the code. Will fix in v2... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-28 8:36 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-04-22 15:10 [PATCH] serial: mctrl_gpio: Drop support for out1-gpios and out2-gpios Geert Uytterhoeven 2016-04-22 18:32 ` Peter Hurley 2016-04-27 8:20 ` Richard Genoud 2016-04-28 8:35 ` Geert Uytterhoeven 2016-04-28 8:35 ` Geert Uytterhoeven
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.