[PATCH] rpm: explicitly disable tomcrypt

[PATCH] rpm: explicitly disable tomcrypt

[Andreas Oberritter]

Configure autodetects libtomcrypt, but then it adds libtommath to
$LIBS and fails to link subsequent tests if it's unavailable.

| checking for pcre.h... yes
| checking for pcre_compile in -lpcre... no
| checking whether to build with PCRE library... no
| ++ executing failure action
| configure: error: unable to find usable PCRE library

Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
---
 meta/recipes-devtools/rpm/rpm_5.4.16.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/rpm/rpm_5.4.16.bb b/meta/recipes-devtools/rpm/rpm_5.4.16.bb
index cbdca88..f2c12d2 100644
--- a/meta/recipes-devtools/rpm/rpm_5.4.16.bb
+++ b/meta/recipes-devtools/rpm/rpm_5.4.16.bb
@@ -328,6 +328,7 @@ EXTRA_OECONF += "--verbose \
 		--without-ruby \
 		--without-squirrel \
 		--without-sasl2 \
+		--without-tomcrypt \
 		--with-build-extlibdep \
 		--with-build-maxextlibdep \
 		--without-valgrind \
-- 
1.9.1

Re: [PATCH] rpm: explicitly disable tomcrypt

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

On 25 April 2016 at 08:25, Andreas Oberritter <obi@opendreambox.org> wrote:

> Configure autodetects libtomcrypt, but then it adds libtommath to
> $LIBS and fails to link subsequent tests if it's unavailable.
>

There was a patch last week to add a PACKAGECONFIG instead, so I'll pick
that instead of this.

Ross

[-- Attachment #2: Type: text/html, Size: 720 bytes --]

Re: [PATCH] rpm: explicitly disable tomcrypt

[Andreas Oberritter]

On 25.04.2016 11:11, Burton, Ross wrote:
> On 25 April 2016 at 08:25, Andreas Oberritter <obi@opendreambox.org> wrote:
> 
>> Configure autodetects libtomcrypt, but then it adds libtommath to
>> $LIBS and fails to link subsequent tests if it's unavailable.
>>
> 
> There was a patch last week to add a PACKAGECONFIG instead, so I'll pick
> that instead of this.

Oh, I didn't notice. Note that the other patch doesn't add the necessary
dependencies, so enabling tomcrypt won't work. And it would be nice to
include the user-visible error message in the commit log.

Regards,
Andreas

Re: [PATCH] rpm: explicitly disable tomcrypt

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

On 25 April 2016 at 10:30, Andreas Oberritter <obi@opendreambox.org> wrote:

> Oh, I didn't notice. Note that the other patch doesn't add the necessary
> dependencies, so enabling tomcrypt won't work. And it would be nice to
> include the user-visible error message in the commit log.
>

The missing dependencies is a good point, patches swapped :)

Ross

[-- Attachment #2: Type: text/html, Size: 769 bytes --]