All of lore.kernel.org
 help / color / mirror / Atom feed
From: narmstrong@baylibre.com (Neil Armstrong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clocksource: sp804: Add support for OX810SE 24bit timer width
Date: Mon, 25 Apr 2016 16:48:24 +0200	[thread overview]
Message-ID: <571E2E38.3060401@baylibre.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1604220953000.3941@nanos>

On 04/22/2016 09:53 AM, Thomas Gleixner wrote:
> On Fri, 22 Apr 2016, Daniel Lezcano wrote:
> 
>> On Fri, Apr 01, 2016 at 04:22:38PM +0200, Neil Armstrong wrote:
>>> In order to support the Dual-Timer on the Oxford Semiconductor OX810SE SoC,
>>> implement variable counter width, keeping 32bit as default width.
>>> Add new compatible string oxsemi,ox810se-rps-timer in order to select
>>> the 24bit counter width.
>>>
>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>> ---
>>>  drivers/clocksource/timer-sp804.c | 107 ++++++++++++++++++++++++--------------
>>>  include/clocksource/timer-sp804.h |  42 ++++++++++++---
>>>  2 files changed, 102 insertions(+), 47 deletions(-)
>>
>> I will take those patches but this driver really deserves a cleanup.
> 
> If it deserves a cleanup, then this should happen _BEFORE_ we add new
> functionality to it.
> 
> Thanks,
> 
> 	tglx
> 

Hi Thomas, Daniel,

Sure this driver should have a cleanup, but it still depends on old legacy vexpress calls.

The reason I submitted a change and a small cleanup over this driver is because the high
similarities of the HW and avoiding adding a brand new driver cloning much of its
functionalities.

I propose to study an eventual cleanup, but could this change be submitted for 4.7 since
it's part of a base platform support serie ?

Thanks,
Neil

WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	rmk+kernel@arm.linux.org.uk, sudeep.holla@arm.com
Subject: Re: [PATCH 1/2] clocksource: sp804: Add support for OX810SE 24bit timer width
Date: Mon, 25 Apr 2016 16:48:24 +0200	[thread overview]
Message-ID: <571E2E38.3060401@baylibre.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1604220953000.3941@nanos>

On 04/22/2016 09:53 AM, Thomas Gleixner wrote:
> On Fri, 22 Apr 2016, Daniel Lezcano wrote:
> 
>> On Fri, Apr 01, 2016 at 04:22:38PM +0200, Neil Armstrong wrote:
>>> In order to support the Dual-Timer on the Oxford Semiconductor OX810SE SoC,
>>> implement variable counter width, keeping 32bit as default width.
>>> Add new compatible string oxsemi,ox810se-rps-timer in order to select
>>> the 24bit counter width.
>>>
>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>> ---
>>>  drivers/clocksource/timer-sp804.c | 107 ++++++++++++++++++++++++--------------
>>>  include/clocksource/timer-sp804.h |  42 ++++++++++++---
>>>  2 files changed, 102 insertions(+), 47 deletions(-)
>>
>> I will take those patches but this driver really deserves a cleanup.
> 
> If it deserves a cleanup, then this should happen _BEFORE_ we add new
> functionality to it.
> 
> Thanks,
> 
> 	tglx
> 

Hi Thomas, Daniel,

Sure this driver should have a cleanup, but it still depends on old legacy vexpress calls.

The reason I submitted a change and a small cleanup over this driver is because the high
similarities of the HW and avoiding adding a brand new driver cloning much of its
functionalities.

I propose to study an eventual cleanup, but could this change be submitted for 4.7 since
it's part of a base platform support serie ?

Thanks,
Neil

  reply	other threads:[~2016-04-25 14:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 14:22 [PATCH 0/2] clocksource: sp804: Add OX810SE 24bit mode Support Neil Armstrong
2016-04-01 14:22 ` Neil Armstrong
2016-04-01 14:22 ` [PATCH 1/2] clocksource: sp804: Add support for OX810SE 24bit timer width Neil Armstrong
2016-04-01 14:22   ` Neil Armstrong
2016-04-01 15:33   ` Mathieu Poirier
2016-04-01 15:33     ` Mathieu Poirier
2016-04-16 19:07     ` Neil Armstrong
2016-04-16 19:07       ` Neil Armstrong
2016-04-22  7:46   ` Daniel Lezcano
2016-04-22  7:46     ` Daniel Lezcano
2016-04-22  7:53     ` Thomas Gleixner
2016-04-22  7:53       ` Thomas Gleixner
2016-04-25 14:48       ` Neil Armstrong [this message]
2016-04-25 14:48         ` Neil Armstrong
2016-04-26 16:30         ` Daniel Lezcano
2016-04-26 16:30           ` Daniel Lezcano
2016-05-11  7:31           ` Neil Armstrong
2016-05-11  7:31             ` Neil Armstrong
2016-04-01 14:22 ` [PATCH 2/2] dt-bindings: timer: sp804: add new compatible for OX810SE SoC Neil Armstrong
2016-04-01 14:22   ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571E2E38.3060401@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.