From: al.stone@linaro.org (Al Stone)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] ARM64: ACPI: Update documentation for latest specification version
Date: Mon, 25 Apr 2016 12:49:38 -0600 [thread overview]
Message-ID: <571E66C2.3000007@linaro.org> (raw)
In-Reply-To: <20160419111545.GB9571@red-moon>
On 04/19/2016 05:15 AM, Lorenzo Pieralisi wrote:
> On Mon, Apr 18, 2016 at 01:32:22PM -0600, Al Stone wrote:
>> The ACPI 6.1 specification was recently released at the end of January
>> 2016, but the arm64 kernel documentation for the use of ACPI was written
>> for the 5.1 version of the spec. There were significant additions to the
>> spec that had not yet been mentioned -- for example, the 6.0 mechanisms
>> added to make it easier to define processors and low power idle states,
>> as well as the 6.1 addition allowing regular interrupts (not just from
>> GPIO) be used to signal ACPI general purpose events.
>>
>> This patch reflects going back through and examining the specs in detail
>> and updating content appropriately. Whilst there, a few odds and ends of
>> typos were caught as well. This brings the documentation up to date with
>> ACPI 6.1 for arm64.
>>
[snip...]
>> @@ -185,9 +185,22 @@ tables (all section numbers refer to the ACPI 5.1 specfication):
>> -- If PCI is supported, the MCFG (Memory mapped ConFiGuration
>> Table), section 5.2.6, specifically Table 5-31.
>>
>> + -- If booting without a console=<device> kernel parameter is
>> + supported, the SPCR (Serial Port Console Redirection table),
>> + section 5.2.6, specifically Table 5-31.
>> +
>> + -- If virtualization is supported, the IORT (Input Output Remapping
>> + Table, section 5.2.6, specifically Table 5-31.
>
> Why only "If virtualization is supported" ? Missing closing bracket.
Hrm. I guess that is an unnecessary qualification.
> I still question sections of this document that IMHO do not belong
> in the kernel documentation (but in the ACPI specs - eg _PRx methods
> usage), anyway the information seems accurate so, pending changes above:
>
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>
Thanks, Lorenzo. The suggested changes all seem fine; I'll include them
in a v5.
--
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Linaro Enterprise Group
al.stone at linaro.org
-----------------------------------
WARNING: multiple messages have this Message-ID (diff)
From: Al Stone <al.stone@linaro.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org,
patches@linaro.org, linaro-kernel@lists.linaro.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v4] ARM64: ACPI: Update documentation for latest specification version
Date: Mon, 25 Apr 2016 12:49:38 -0600 [thread overview]
Message-ID: <571E66C2.3000007@linaro.org> (raw)
In-Reply-To: <20160419111545.GB9571@red-moon>
On 04/19/2016 05:15 AM, Lorenzo Pieralisi wrote:
> On Mon, Apr 18, 2016 at 01:32:22PM -0600, Al Stone wrote:
>> The ACPI 6.1 specification was recently released at the end of January
>> 2016, but the arm64 kernel documentation for the use of ACPI was written
>> for the 5.1 version of the spec. There were significant additions to the
>> spec that had not yet been mentioned -- for example, the 6.0 mechanisms
>> added to make it easier to define processors and low power idle states,
>> as well as the 6.1 addition allowing regular interrupts (not just from
>> GPIO) be used to signal ACPI general purpose events.
>>
>> This patch reflects going back through and examining the specs in detail
>> and updating content appropriately. Whilst there, a few odds and ends of
>> typos were caught as well. This brings the documentation up to date with
>> ACPI 6.1 for arm64.
>>
[snip...]
>> @@ -185,9 +185,22 @@ tables (all section numbers refer to the ACPI 5.1 specfication):
>> -- If PCI is supported, the MCFG (Memory mapped ConFiGuration
>> Table), section 5.2.6, specifically Table 5-31.
>>
>> + -- If booting without a console=<device> kernel parameter is
>> + supported, the SPCR (Serial Port Console Redirection table),
>> + section 5.2.6, specifically Table 5-31.
>> +
>> + -- If virtualization is supported, the IORT (Input Output Remapping
>> + Table, section 5.2.6, specifically Table 5-31.
>
> Why only "If virtualization is supported" ? Missing closing bracket.
Hrm. I guess that is an unnecessary qualification.
> I still question sections of this document that IMHO do not belong
> in the kernel documentation (but in the ACPI specs - eg _PRx methods
> usage), anyway the information seems accurate so, pending changes above:
>
> Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
>
Thanks, Lorenzo. The suggested changes all seem fine; I'll include them
in a v5.
--
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Linaro Enterprise Group
al.stone@linaro.org
-----------------------------------
next prev parent reply other threads:[~2016-04-25 18:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 19:32 [PATCH v4] ARM64: ACPI: Update documentation for latest specification version Al Stone
2016-04-18 19:32 ` Al Stone
2016-04-19 11:15 ` Lorenzo Pieralisi
2016-04-19 11:15 ` Lorenzo Pieralisi
2016-04-25 18:49 ` Al Stone [this message]
2016-04-25 18:49 ` Al Stone
2016-04-21 13:37 ` Alexey Klimov
2016-04-21 13:37 ` Alexey Klimov
2016-04-25 19:01 ` Al Stone
2016-04-25 19:01 ` Al Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571E66C2.3000007@linaro.org \
--to=al.stone@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.