All of lore.kernel.org
 help / color / mirror / Atom feed
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] soc: brcmstb: select SOC_BUS
Date: Mon, 25 Apr 2016 16:00:31 -0700	[thread overview]
Message-ID: <571EA18F.2030401@gmail.com> (raw)
In-Reply-To: <1461625017-1939162-1-git-send-email-arnd@arndb.de>

On 25/04/16 15:55, Arnd Bergmann wrote:
> The newly added code for the SoC bus fails to link if the
> bus is not built:
> 
> drivers/soc/built-in.o: In function `brcmstb_soc_device_init':
> :(.init.text+0x110): undefined reference to `soc_device_register'
> 
> This adds a 'select' statement to avoid the error.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Fixes: cef4bafcea2c ("soc: brcmstb: add SoC driver to brcmstb")

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks!

> ---
>  drivers/soc/brcmstb/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/brcmstb/Kconfig b/drivers/soc/brcmstb/Kconfig
> index 39cab3b..7fec3b4 100644
> --- a/drivers/soc/brcmstb/Kconfig
> +++ b/drivers/soc/brcmstb/Kconfig
> @@ -1,6 +1,7 @@
>  menuconfig SOC_BRCMSTB
>  	bool "Broadcom STB SoC drivers"
>  	depends on ARM
> +	select SOC_BUS
>  	help
>  	  Enables drivers for the Broadcom Set-Top Box (STB) series of chips.
>  	  This option alone enables only some support code, while the drivers
> 


-- 
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>,
	Brian Norris <computersforpeace@gmail.com>,
	Gregory Fong <gregory.0xf0@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: brcmstb: select SOC_BUS
Date: Mon, 25 Apr 2016 16:00:31 -0700	[thread overview]
Message-ID: <571EA18F.2030401@gmail.com> (raw)
In-Reply-To: <1461625017-1939162-1-git-send-email-arnd@arndb.de>

On 25/04/16 15:55, Arnd Bergmann wrote:
> The newly added code for the SoC bus fails to link if the
> bus is not built:
> 
> drivers/soc/built-in.o: In function `brcmstb_soc_device_init':
> :(.init.text+0x110): undefined reference to `soc_device_register'
> 
> This adds a 'select' statement to avoid the error.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Fixes: cef4bafcea2c ("soc: brcmstb: add SoC driver to brcmstb")

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks!

> ---
>  drivers/soc/brcmstb/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/brcmstb/Kconfig b/drivers/soc/brcmstb/Kconfig
> index 39cab3b..7fec3b4 100644
> --- a/drivers/soc/brcmstb/Kconfig
> +++ b/drivers/soc/brcmstb/Kconfig
> @@ -1,6 +1,7 @@
>  menuconfig SOC_BRCMSTB
>  	bool "Broadcom STB SoC drivers"
>  	depends on ARM
> +	select SOC_BUS
>  	help
>  	  Enables drivers for the Broadcom Set-Top Box (STB) series of chips.
>  	  This option alone enables only some support code, while the drivers
> 


-- 
Florian

  reply	other threads:[~2016-04-25 23:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 22:55 [PATCH] soc: brcmstb: select SOC_BUS Arnd Bergmann
2016-04-25 22:55 ` Arnd Bergmann
2016-04-25 23:00 ` Florian Fainelli [this message]
2016-04-25 23:00   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=571EA18F.2030401@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.