From: Jens Axboe <axboe@kernel.dk>
To: Shaohua Li <shli@fb.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org
Cc: qkrwngud825@gmail.com, Kernel-team@fb.com,
"v4.3+" <stable@vger.kernel.org>,
Ming Lei <ming.lei@canonical.com>, Jens Axboe <axboe@fb.com>,
Neil Brown <neilb@suse.de>
Subject: Re: [PATCH] MD: make bio mergeable
Date: Mon, 25 Apr 2016 19:15:58 -0600 [thread overview]
Message-ID: <571EC14E.6040703@kernel.dk> (raw)
In-Reply-To: <571EBD56.7010204@kernel.dk>
On 04/25/2016 06:59 PM, Jens Axboe wrote:
> On 04/25/2016 05:52 PM, Shaohua Li wrote:
>> blk_queue_split marks bio unmergeable, which makes sense for normal bio.
>> But if dispatching the bio to underlayer disk, the blk_queue_split
>> checks are invalid, hence it's possible the bio becomes mergeable.
>>
>> In the reported bug, this bug causes trim against raid0 performance slash
>> https://bugzilla.kernel.org/show_bug.cgi?id=117051
>
> Good catch! Will apply for this series, thanks Shaohua.
Actually, let's let that go through the md tree instead. But you can add
my Reviewed-by, and it'd be nice to get this into 4.6.
--
Jens Axboe
next prev parent reply other threads:[~2016-04-26 1:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 23:52 [PATCH] MD: make bio mergeable Shaohua Li
2016-04-25 23:52 ` Shaohua Li
2016-04-26 0:59 ` Jens Axboe
2016-04-26 1:15 ` Jens Axboe [this message]
2016-04-26 9:56 ` Ming Lei
2016-04-26 14:21 ` Jens Axboe
2016-04-26 15:17 ` Ming Lei
2016-04-28 20:00 ` Holger Kiehl
2016-04-28 21:19 ` Shaohua Li
2016-04-28 21:19 ` Shaohua Li
2016-04-29 9:23 ` Holger Kiehl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571EC14E.6040703@kernel.dk \
--to=axboe@kernel.dk \
--cc=Kernel-team@fb.com \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=neilb@suse.de \
--cc=qkrwngud825@gmail.com \
--cc=shli@fb.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.