From: Shaohua Li <shli@fb.com>
To: Holger Kiehl <Holger.Kiehl@dwd.de>
Cc: linux-block@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-raid <linux-raid@vger.kernel.org>,
qkrwngud825@gmail.com, Kernel-team@fb.com,
Ming Lei <ming.lei@canonical.com>, Jens Axboe <axboe@fb.com>,
Neil Brown <neilb@suse.de>
Subject: Re: [PATCH] MD: make bio mergeable
Date: Thu, 28 Apr 2016 14:19:10 -0700 [thread overview]
Message-ID: <20160428211908.GA3116523@devbig084.prn1.facebook.com> (raw)
In-Reply-To: <alpine.LRH.2.20.1604281933200.31165@diagnostix.dwd.de>
On Thu, Apr 28, 2016 at 08:00:22PM +0000, Holger Kiehl wrote:
> Hello,
>
> On Mon, 25 Apr 2016, Shaohua Li wrote:
>
> > blk_queue_split marks bio unmergeable, which makes sense for normal bio.
> > But if dispatching the bio to underlayer disk, the blk_queue_split
> > checks are invalid, hence it's possible the bio becomes mergeable.
> >
> > In the reported bug, this bug causes trim against raid0 performance slash
> > https://bugzilla.kernel.org/show_bug.cgi?id=117051
> >
> This patch makes a huge difference. On a system with two Samsung 850 Pro
> in a MD Raid0 setup the time for fstrim went down from ~30min to 18sec!
>
> However, on another system with two Intel P3700 1.6TB NVMe PCIe SSD's
> also setup as one big MD Raid0, the patch does not make any difference
> at all. fstrim takes more then 4 hours!
Does the raid0 cross two partitions or two SSD?
can you post blktrace data in the bugzilloa, I'll track the bug there.
Thanks,
Shaohua
WARNING: multiple messages have this Message-ID (diff)
From: Shaohua Li <shli@fb.com>
To: Holger Kiehl <Holger.Kiehl@dwd.de>
Cc: <linux-block@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-raid <linux-raid@vger.kernel.org>, <qkrwngud825@gmail.com>,
<Kernel-team@fb.com>, Ming Lei <ming.lei@canonical.com>,
Jens Axboe <axboe@fb.com>, Neil Brown <neilb@suse.de>
Subject: Re: [PATCH] MD: make bio mergeable
Date: Thu, 28 Apr 2016 14:19:10 -0700 [thread overview]
Message-ID: <20160428211908.GA3116523@devbig084.prn1.facebook.com> (raw)
In-Reply-To: <alpine.LRH.2.20.1604281933200.31165@diagnostix.dwd.de>
On Thu, Apr 28, 2016 at 08:00:22PM +0000, Holger Kiehl wrote:
> Hello,
>
> On Mon, 25 Apr 2016, Shaohua Li wrote:
>
> > blk_queue_split marks bio unmergeable, which makes sense for normal bio.
> > But if dispatching the bio to underlayer disk, the blk_queue_split
> > checks are invalid, hence it's possible the bio becomes mergeable.
> >
> > In the reported bug, this bug causes trim against raid0 performance slash
> > https://bugzilla.kernel.org/show_bug.cgi?id=117051
> >
> This patch makes a huge difference. On a system with two Samsung 850 Pro
> in a MD Raid0 setup the time for fstrim went down from ~30min to 18sec!
>
> However, on another system with two Intel P3700 1.6TB NVMe PCIe SSD's
> also setup as one big MD Raid0, the patch does not make any difference
> at all. fstrim takes more then 4 hours!
Does the raid0 cross two partitions or two SSD?
can you post blktrace data in the bugzilloa, I'll track the bug there.
Thanks,
Shaohua
next prev parent reply other threads:[~2016-04-28 21:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 23:52 [PATCH] MD: make bio mergeable Shaohua Li
2016-04-25 23:52 ` Shaohua Li
2016-04-26 0:59 ` Jens Axboe
2016-04-26 1:15 ` Jens Axboe
2016-04-26 9:56 ` Ming Lei
2016-04-26 14:21 ` Jens Axboe
2016-04-26 15:17 ` Ming Lei
2016-04-28 20:00 ` Holger Kiehl
2016-04-28 21:19 ` Shaohua Li [this message]
2016-04-28 21:19 ` Shaohua Li
2016-04-29 9:23 ` Holger Kiehl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428211908.GA3116523@devbig084.prn1.facebook.com \
--to=shli@fb.com \
--cc=Holger.Kiehl@dwd.de \
--cc=Kernel-team@fb.com \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=neilb@suse.de \
--cc=qkrwngud825@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.