From: Shannon Zhao <zhaoshenglong@huawei.com>
To: Shannon Zhao <shannon.zhao@linaro.org>,
Andrew Jones <drjones@redhat.com>
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org,
qemu-devel@nongnu.org, peter.huangpeng@huawei.com
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH v3 3/3] hw/arm/virt-acpi-build: Add PMU IRQ number in ACPI table
Date: Tue, 26 Apr 2016 19:08:25 +0800 [thread overview]
Message-ID: <571F4C29.8030503@huawei.com> (raw)
In-Reply-To: <571E205E.3040508@linaro.org>
On 2016/4/25 21:49, Shannon Zhao wrote:
> On 2016年04月25日 20:42, Andrew Jones wrote:
>> > On Mon, Apr 25, 2016 at 03:11:46PM +0800, Shannon Zhao wrote:
>>>> >> > From: Shannon Zhao <shannon.zhao@linaro.org>
>>>> >> >
>>>> >> > Add PMU IRQ number in ACPI table, then we can use PMU in guest through
>>>> >> > ACPI.
>>>> >> >
>>>> >> > Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>>>> >> > Reviewed-by: Andrew Jones <drjones@redhat.com>
>>>> >> > ---
>>>> >> > hw/arm/virt-acpi-build.c | 3 +++
>>>> >> > 1 file changed, 3 insertions(+)
>> > Question: for testing of this, did you use
>> > https://lkml.org/lkml/2016/4/12/755 ?
> Actually I didn't test PMU with ACPI since I didn't notice the patch
> series you point out and it's very obvious for QEMU changes(adding irq
> flag and irq number in GICC). I will have a test later.
I have test this patch series using ACPI and guest with the patches you
point out. Guest prints below logs and perf works well in guest.
[ 0.000000] ACPI-PMU: Assign CPU 0 girq 23 level 0
[ 0.000000] ACPI-PMU: Assign CPU 1 girq 23 level 0
[ 0.000000] ACPI-PMU: Assign CPU 2 girq 23 level 0
[ 0.000000] ACPI-PMU: Assign CPU 3 girq 23 level 0
[...]
[ 0.094782] ACPI-PMU: Setting up 4 PMUs for CPU type D07
Thanks,
--
Shannon
WARNING: multiple messages have this Message-ID (diff)
From: Shannon Zhao <zhaoshenglong@huawei.com>
To: Shannon Zhao <shannon.zhao@linaro.org>,
Andrew Jones <drjones@redhat.com>
Cc: qemu-arm@nongnu.org, peter.maydell@linaro.org,
qemu-devel@nongnu.org, peter.huangpeng@huawei.com
Subject: Re: [Qemu-devel] [PATCH v3 3/3] hw/arm/virt-acpi-build: Add PMU IRQ number in ACPI table
Date: Tue, 26 Apr 2016 19:08:25 +0800 [thread overview]
Message-ID: <571F4C29.8030503@huawei.com> (raw)
In-Reply-To: <571E205E.3040508@linaro.org>
On 2016/4/25 21:49, Shannon Zhao wrote:
> On 2016年04月25日 20:42, Andrew Jones wrote:
>> > On Mon, Apr 25, 2016 at 03:11:46PM +0800, Shannon Zhao wrote:
>>>> >> > From: Shannon Zhao <shannon.zhao@linaro.org>
>>>> >> >
>>>> >> > Add PMU IRQ number in ACPI table, then we can use PMU in guest through
>>>> >> > ACPI.
>>>> >> >
>>>> >> > Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>>>> >> > Reviewed-by: Andrew Jones <drjones@redhat.com>
>>>> >> > ---
>>>> >> > hw/arm/virt-acpi-build.c | 3 +++
>>>> >> > 1 file changed, 3 insertions(+)
>> > Question: for testing of this, did you use
>> > https://lkml.org/lkml/2016/4/12/755 ?
> Actually I didn't test PMU with ACPI since I didn't notice the patch
> series you point out and it's very obvious for QEMU changes(adding irq
> flag and irq number in GICC). I will have a test later.
I have test this patch series using ACPI and guest with the patches you
point out. Guest prints below logs and perf works well in guest.
[ 0.000000] ACPI-PMU: Assign CPU 0 girq 23 level 0
[ 0.000000] ACPI-PMU: Assign CPU 1 girq 23 level 0
[ 0.000000] ACPI-PMU: Assign CPU 2 girq 23 level 0
[ 0.000000] ACPI-PMU: Assign CPU 3 girq 23 level 0
[...]
[ 0.094782] ACPI-PMU: Setting up 4 PMUs for CPU type D07
Thanks,
--
Shannon
next prev parent reply other threads:[~2016-04-26 11:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 7:11 [Qemu-devel] [PATCH v3 0/3] Add guest PMU in machine virt Shannon Zhao
2016-04-25 7:11 ` Shannon Zhao
2016-04-25 7:11 ` [Qemu-devel] [PATCH v3 1/3] target-arm: kvm64: set guest PMUv3 feature bit if supported Shannon Zhao
2016-04-25 7:11 ` Shannon Zhao
2016-04-25 7:11 ` [Qemu-arm] [PATCH v3 2/3] hw/arm/virt: Add PMU node for virt machine Shannon Zhao
2016-04-25 7:11 ` [Qemu-devel] " Shannon Zhao
2016-04-25 9:22 ` [Qemu-arm] " Andrew Jones
2016-04-25 9:22 ` Andrew Jones
2016-04-25 11:37 ` [Qemu-arm] " Shannon Zhao
2016-04-25 11:37 ` Shannon Zhao
2016-04-25 11:52 ` [Qemu-arm] " Andrew Jones
2016-04-25 11:52 ` Andrew Jones
2016-04-25 13:54 ` [Qemu-arm] " Shannon Zhao
2016-04-25 13:54 ` Shannon Zhao
2016-04-25 14:17 ` [Qemu-arm] " Andrew Jones
2016-04-25 14:17 ` Andrew Jones
2016-04-25 7:11 ` [Qemu-arm] [PATCH v3 3/3] hw/arm/virt-acpi-build: Add PMU IRQ number in ACPI table Shannon Zhao
2016-04-25 7:11 ` [Qemu-devel] " Shannon Zhao
2016-04-25 12:42 ` [Qemu-arm] " Andrew Jones
2016-04-25 12:42 ` Andrew Jones
2016-04-25 13:49 ` [Qemu-arm] " Shannon Zhao
2016-04-25 13:49 ` Shannon Zhao
2016-04-26 11:08 ` Shannon Zhao [this message]
2016-04-26 11:08 ` Shannon Zhao
2016-04-26 11:18 ` [Qemu-arm] " Andrew Jones
2016-04-26 11:18 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571F4C29.8030503@huawei.com \
--to=zhaoshenglong@huawei.com \
--cc=drjones@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.