* [PATCH] nvme: fix cntlid type @ 2016-04-16 18:57 Christoph Hellwig 2016-04-26 11:47 ` Christoph Hellwig 2016-04-26 14:31 ` Jens Axboe 0 siblings, 2 replies; 3+ messages in thread From: Christoph Hellwig @ 2016-04-16 18:57 UTC (permalink / raw) Controller IDs in NVMe are unsigned 16-bit types. In the Fabrics driver we actually pass ctrl->id by reference, so we need it to have the correct type. Signed-off-by: Christoph Hellwig <hch at lst.de> --- drivers/nvme/host/nvme.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h index 8e8fae8..9b96e75 100644 --- a/drivers/nvme/host/nvme.h +++ b/drivers/nvme/host/nvme.h @@ -84,7 +84,7 @@ struct nvme_ctrl { char serial[20]; char model[40]; char firmware_rev[8]; - int cntlid; + u16 cntlid; u32 ctrl_config; -- 2.1.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] nvme: fix cntlid type 2016-04-16 18:57 [PATCH] nvme: fix cntlid type Christoph Hellwig @ 2016-04-26 11:47 ` Christoph Hellwig 2016-04-26 14:31 ` Jens Axboe 1 sibling, 0 replies; 3+ messages in thread From: Christoph Hellwig @ 2016-04-26 11:47 UTC (permalink / raw) ping? ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] nvme: fix cntlid type 2016-04-16 18:57 [PATCH] nvme: fix cntlid type Christoph Hellwig 2016-04-26 11:47 ` Christoph Hellwig @ 2016-04-26 14:31 ` Jens Axboe 1 sibling, 0 replies; 3+ messages in thread From: Jens Axboe @ 2016-04-26 14:31 UTC (permalink / raw) On 04/16/2016 12:57 PM, Christoph Hellwig wrote: > Controller IDs in NVMe are unsigned 16-bit types. In the Fabrics driver we > actually pass ctrl->id by reference, so we need it to have the correct type. > > Signed-off-by: Christoph Hellwig <hch at lst.de> > --- > drivers/nvme/host/nvme.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h > index 8e8fae8..9b96e75 100644 > --- a/drivers/nvme/host/nvme.h > +++ b/drivers/nvme/host/nvme.h > @@ -84,7 +84,7 @@ struct nvme_ctrl { > char serial[20]; > char model[40]; > char firmware_rev[8]; > - int cntlid; > + u16 cntlid; > > u32 ctrl_config; Looks fine, added for 4.7. -- Jens Axboe ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-26 14:31 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-04-16 18:57 [PATCH] nvme: fix cntlid type Christoph Hellwig 2016-04-26 11:47 ` Christoph Hellwig 2016-04-26 14:31 ` Jens Axboe
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.