From: Roger Quadros <rogerq@ti.com>
To: balbi@kernel.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: omap: get rid of dma_status
Date: Wed, 27 Apr 2016 14:34:28 +0300 [thread overview]
Message-ID: <5720A3C4.6030506@ti.com> (raw)
In-Reply-To: <1460384305-21256-1-git-send-email-rogerq@ti.com>
Felipe,
On 11/04/16 17:18, Roger Quadros wrote:
> dma_status bit flag is set but never really used
> so get rid of it.
>
> Reported-by: Felipe Balbi <balbi@kernel.org>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
Gentle ping on this one for -next. Thanks.
cheers,
-roger
> ---
> drivers/usb/dwc3/dwc3-omap.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
> index 55da2c7..890b8a6 100644
> --- a/drivers/usb/dwc3/dwc3-omap.c
> +++ b/drivers/usb/dwc3/dwc3-omap.c
> @@ -126,8 +126,6 @@ struct dwc3_omap {
> u32 debug_offset;
> u32 irq0_offset;
>
> - u32 dma_status:1;
> -
> struct extcon_dev *edev;
> struct notifier_block vbus_nb;
> struct notifier_block id_nb;
> @@ -277,9 +275,6 @@ static irqreturn_t dwc3_omap_interrupt(int irq, void *_omap)
>
> reg = dwc3_omap_read_irqmisc_status(omap);
>
> - if (reg & USBOTGSS_IRQMISC_DMADISABLECLR)
> - omap->dma_status = false;
> -
> dwc3_omap_write_irqmisc_status(omap, reg);
>
> reg = dwc3_omap_read_irq0_status(omap);
> @@ -504,7 +499,6 @@ static int dwc3_omap_probe(struct platform_device *pdev)
>
> /* check the DMA Status */
> reg = dwc3_omap_readl(omap->base, USBOTGSS_SYSCONFIG);
> - omap->dma_status = !!(reg & USBOTGSS_SYSCONFIG_DMADISABLE);
>
> ret = devm_request_irq(dev, omap->irq, dwc3_omap_interrupt, 0,
> "dwc3-omap", omap);
>
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: <balbi@kernel.org>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc3: omap: get rid of dma_status
Date: Wed, 27 Apr 2016 14:34:28 +0300 [thread overview]
Message-ID: <5720A3C4.6030506@ti.com> (raw)
In-Reply-To: <1460384305-21256-1-git-send-email-rogerq@ti.com>
Felipe,
On 11/04/16 17:18, Roger Quadros wrote:
> dma_status bit flag is set but never really used
> so get rid of it.
>
> Reported-by: Felipe Balbi <balbi@kernel.org>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
Gentle ping on this one for -next. Thanks.
cheers,
-roger
> ---
> drivers/usb/dwc3/dwc3-omap.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
> index 55da2c7..890b8a6 100644
> --- a/drivers/usb/dwc3/dwc3-omap.c
> +++ b/drivers/usb/dwc3/dwc3-omap.c
> @@ -126,8 +126,6 @@ struct dwc3_omap {
> u32 debug_offset;
> u32 irq0_offset;
>
> - u32 dma_status:1;
> -
> struct extcon_dev *edev;
> struct notifier_block vbus_nb;
> struct notifier_block id_nb;
> @@ -277,9 +275,6 @@ static irqreturn_t dwc3_omap_interrupt(int irq, void *_omap)
>
> reg = dwc3_omap_read_irqmisc_status(omap);
>
> - if (reg & USBOTGSS_IRQMISC_DMADISABLECLR)
> - omap->dma_status = false;
> -
> dwc3_omap_write_irqmisc_status(omap, reg);
>
> reg = dwc3_omap_read_irq0_status(omap);
> @@ -504,7 +499,6 @@ static int dwc3_omap_probe(struct platform_device *pdev)
>
> /* check the DMA Status */
> reg = dwc3_omap_readl(omap->base, USBOTGSS_SYSCONFIG);
> - omap->dma_status = !!(reg & USBOTGSS_SYSCONFIG_DMADISABLE);
>
> ret = devm_request_irq(dev, omap->irq, dwc3_omap_interrupt, 0,
> "dwc3-omap", omap);
>
next prev parent reply other threads:[~2016-04-27 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 14:18 [PATCH] usb: dwc3: omap: get rid of dma_status Roger Quadros
2016-04-11 14:18 ` Roger Quadros
2016-04-27 11:34 ` Roger Quadros [this message]
2016-04-27 11:34 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5720A3C4.6030506@ti.com \
--to=rogerq@ti.com \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.