From: Tero Kristo <t-kristo@ti.com>
To: Franklin S Cooper Jr <fcooper@ti.com>, <thierry.reding@gmail.com>,
<robh+dt@kernel.org>, <tony@atomide.com>, <paul@pwsan.com>,
<linux-pwm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-clk@vger.kernel.org>, <vigneshr@ti.com>, <nsekhar@ti.com>
Subject: Re: [PATCH v7 1/9] clk: ti: am335x/am4372: Add tbclk to pwm node
Date: Wed, 27 Apr 2016 15:48:30 +0300 [thread overview]
Message-ID: <5720B51E.6050106@ti.com> (raw)
In-Reply-To: <1461710209-6563-2-git-send-email-fcooper@ti.com>
On 27/04/16 01:36, Franklin S Cooper Jr wrote:
> Add tblck to the pwm nodes. This insures that the ehrpwm driver has access
> to the time-based clk.
>
> Do not remove similar entries for ehrpwm node. Later patches will switch
> from using ehrpwm node name to pwm. But to maintain ABI compatibility we
> shouldn't remove the old entries.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> Acked-by: Stephen Boyd <sboyd@codeaurora.org>
I don't like adding new clock aliases to the list as I am trying to get
rid of them, but in this case we can't avoid it I believe. Thus,
Acked-by: Tero Kristo <t-kristo@ti.com>
> ---
> drivers/clk/ti/clk-33xx.c | 3 +++
> drivers/clk/ti/clk-43xx.c | 6 ++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/drivers/clk/ti/clk-33xx.c b/drivers/clk/ti/clk-33xx.c
> index ef2ec64..0e47d95 100644
> --- a/drivers/clk/ti/clk-33xx.c
> +++ b/drivers/clk/ti/clk-33xx.c
> @@ -108,6 +108,9 @@ static struct ti_dt_clk am33xx_clks[] = {
> DT_CLK("48300200.ehrpwm", "tbclk", "ehrpwm0_tbclk"),
> DT_CLK("48302200.ehrpwm", "tbclk", "ehrpwm1_tbclk"),
> DT_CLK("48304200.ehrpwm", "tbclk", "ehrpwm2_tbclk"),
> + DT_CLK("48300200.pwm", "tbclk", "ehrpwm0_tbclk"),
> + DT_CLK("48302200.pwm", "tbclk", "ehrpwm1_tbclk"),
> + DT_CLK("48304200.pwm", "tbclk", "ehrpwm2_tbclk"),
> { .node_name = NULL },
> };
>
> diff --git a/drivers/clk/ti/clk-43xx.c b/drivers/clk/ti/clk-43xx.c
> index 097fc90..7255aa8 100644
> --- a/drivers/clk/ti/clk-43xx.c
> +++ b/drivers/clk/ti/clk-43xx.c
> @@ -115,6 +115,12 @@ static struct ti_dt_clk am43xx_clks[] = {
> DT_CLK("48306200.ehrpwm", "tbclk", "ehrpwm3_tbclk"),
> DT_CLK("48308200.ehrpwm", "tbclk", "ehrpwm4_tbclk"),
> DT_CLK("4830a200.ehrpwm", "tbclk", "ehrpwm5_tbclk"),
> + DT_CLK("48300200.pwm", "tbclk", "ehrpwm0_tbclk"),
> + DT_CLK("48302200.pwm", "tbclk", "ehrpwm1_tbclk"),
> + DT_CLK("48304200.pwm", "tbclk", "ehrpwm2_tbclk"),
> + DT_CLK("48306200.pwm", "tbclk", "ehrpwm3_tbclk"),
> + DT_CLK("48308200.pwm", "tbclk", "ehrpwm4_tbclk"),
> + DT_CLK("4830a200.pwm", "tbclk", "ehrpwm5_tbclk"),
> { .node_name = NULL },
> };
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com>
To: Franklin S Cooper Jr <fcooper@ti.com>,
thierry.reding@gmail.com, robh+dt@kernel.org, tony@atomide.com,
paul@pwsan.com, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org, vigneshr@ti.com, nsekhar@ti.com
Subject: Re: [PATCH v7 1/9] clk: ti: am335x/am4372: Add tbclk to pwm node
Date: Wed, 27 Apr 2016 15:48:30 +0300 [thread overview]
Message-ID: <5720B51E.6050106@ti.com> (raw)
In-Reply-To: <1461710209-6563-2-git-send-email-fcooper@ti.com>
On 27/04/16 01:36, Franklin S Cooper Jr wrote:
> Add tblck to the pwm nodes. This insures that the ehrpwm driver has access
> to the time-based clk.
>
> Do not remove similar entries for ehrpwm node. Later patches will switch
> from using ehrpwm node name to pwm. But to maintain ABI compatibility we
> shouldn't remove the old entries.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> Acked-by: Stephen Boyd <sboyd@codeaurora.org>
I don't like adding new clock aliases to the list as I am trying to get
rid of them, but in this case we can't avoid it I believe. Thus,
Acked-by: Tero Kristo <t-kristo@ti.com>
> ---
> drivers/clk/ti/clk-33xx.c | 3 +++
> drivers/clk/ti/clk-43xx.c | 6 ++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/drivers/clk/ti/clk-33xx.c b/drivers/clk/ti/clk-33xx.c
> index ef2ec64..0e47d95 100644
> --- a/drivers/clk/ti/clk-33xx.c
> +++ b/drivers/clk/ti/clk-33xx.c
> @@ -108,6 +108,9 @@ static struct ti_dt_clk am33xx_clks[] = {
> DT_CLK("48300200.ehrpwm", "tbclk", "ehrpwm0_tbclk"),
> DT_CLK("48302200.ehrpwm", "tbclk", "ehrpwm1_tbclk"),
> DT_CLK("48304200.ehrpwm", "tbclk", "ehrpwm2_tbclk"),
> + DT_CLK("48300200.pwm", "tbclk", "ehrpwm0_tbclk"),
> + DT_CLK("48302200.pwm", "tbclk", "ehrpwm1_tbclk"),
> + DT_CLK("48304200.pwm", "tbclk", "ehrpwm2_tbclk"),
> { .node_name = NULL },
> };
>
> diff --git a/drivers/clk/ti/clk-43xx.c b/drivers/clk/ti/clk-43xx.c
> index 097fc90..7255aa8 100644
> --- a/drivers/clk/ti/clk-43xx.c
> +++ b/drivers/clk/ti/clk-43xx.c
> @@ -115,6 +115,12 @@ static struct ti_dt_clk am43xx_clks[] = {
> DT_CLK("48306200.ehrpwm", "tbclk", "ehrpwm3_tbclk"),
> DT_CLK("48308200.ehrpwm", "tbclk", "ehrpwm4_tbclk"),
> DT_CLK("4830a200.ehrpwm", "tbclk", "ehrpwm5_tbclk"),
> + DT_CLK("48300200.pwm", "tbclk", "ehrpwm0_tbclk"),
> + DT_CLK("48302200.pwm", "tbclk", "ehrpwm1_tbclk"),
> + DT_CLK("48304200.pwm", "tbclk", "ehrpwm2_tbclk"),
> + DT_CLK("48306200.pwm", "tbclk", "ehrpwm3_tbclk"),
> + DT_CLK("48308200.pwm", "tbclk", "ehrpwm4_tbclk"),
> + DT_CLK("4830a200.pwm", "tbclk", "ehrpwm5_tbclk"),
> { .node_name = NULL },
> };
>
>
WARNING: multiple messages have this Message-ID (diff)
From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 1/9] clk: ti: am335x/am4372: Add tbclk to pwm node
Date: Wed, 27 Apr 2016 15:48:30 +0300 [thread overview]
Message-ID: <5720B51E.6050106@ti.com> (raw)
In-Reply-To: <1461710209-6563-2-git-send-email-fcooper@ti.com>
On 27/04/16 01:36, Franklin S Cooper Jr wrote:
> Add tblck to the pwm nodes. This insures that the ehrpwm driver has access
> to the time-based clk.
>
> Do not remove similar entries for ehrpwm node. Later patches will switch
> from using ehrpwm node name to pwm. But to maintain ABI compatibility we
> shouldn't remove the old entries.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> Acked-by: Stephen Boyd <sboyd@codeaurora.org>
I don't like adding new clock aliases to the list as I am trying to get
rid of them, but in this case we can't avoid it I believe. Thus,
Acked-by: Tero Kristo <t-kristo@ti.com>
> ---
> drivers/clk/ti/clk-33xx.c | 3 +++
> drivers/clk/ti/clk-43xx.c | 6 ++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/drivers/clk/ti/clk-33xx.c b/drivers/clk/ti/clk-33xx.c
> index ef2ec64..0e47d95 100644
> --- a/drivers/clk/ti/clk-33xx.c
> +++ b/drivers/clk/ti/clk-33xx.c
> @@ -108,6 +108,9 @@ static struct ti_dt_clk am33xx_clks[] = {
> DT_CLK("48300200.ehrpwm", "tbclk", "ehrpwm0_tbclk"),
> DT_CLK("48302200.ehrpwm", "tbclk", "ehrpwm1_tbclk"),
> DT_CLK("48304200.ehrpwm", "tbclk", "ehrpwm2_tbclk"),
> + DT_CLK("48300200.pwm", "tbclk", "ehrpwm0_tbclk"),
> + DT_CLK("48302200.pwm", "tbclk", "ehrpwm1_tbclk"),
> + DT_CLK("48304200.pwm", "tbclk", "ehrpwm2_tbclk"),
> { .node_name = NULL },
> };
>
> diff --git a/drivers/clk/ti/clk-43xx.c b/drivers/clk/ti/clk-43xx.c
> index 097fc90..7255aa8 100644
> --- a/drivers/clk/ti/clk-43xx.c
> +++ b/drivers/clk/ti/clk-43xx.c
> @@ -115,6 +115,12 @@ static struct ti_dt_clk am43xx_clks[] = {
> DT_CLK("48306200.ehrpwm", "tbclk", "ehrpwm3_tbclk"),
> DT_CLK("48308200.ehrpwm", "tbclk", "ehrpwm4_tbclk"),
> DT_CLK("4830a200.ehrpwm", "tbclk", "ehrpwm5_tbclk"),
> + DT_CLK("48300200.pwm", "tbclk", "ehrpwm0_tbclk"),
> + DT_CLK("48302200.pwm", "tbclk", "ehrpwm1_tbclk"),
> + DT_CLK("48304200.pwm", "tbclk", "ehrpwm2_tbclk"),
> + DT_CLK("48306200.pwm", "tbclk", "ehrpwm3_tbclk"),
> + DT_CLK("48308200.pwm", "tbclk", "ehrpwm4_tbclk"),
> + DT_CLK("4830a200.pwm", "tbclk", "ehrpwm5_tbclk"),
> { .node_name = NULL },
> };
>
>
next prev parent reply other threads:[~2016-04-27 12:48 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 22:36 [PATCH v7 0/9] ARM: dts: DRA7: Add dt nodes for PWMSS Franklin S Cooper Jr
2016-04-26 22:36 ` Franklin S Cooper Jr
2016-04-26 22:36 ` Franklin S Cooper Jr
2016-04-26 22:36 ` [PATCH v7 1/9] clk: ti: am335x/am4372: Add tbclk to pwm node Franklin S Cooper Jr
2016-04-26 22:36 ` Franklin S Cooper Jr
2016-04-26 22:36 ` Franklin S Cooper Jr
2016-04-27 12:48 ` Tero Kristo [this message]
2016-04-27 12:48 ` Tero Kristo
2016-04-27 12:48 ` Tero Kristo
2016-04-26 22:36 ` [PATCH v7 2/9] ARM: dts: am437x: Add missing compatibles to PWM binding documents Franklin S Cooper Jr
2016-04-26 22:36 ` Franklin S Cooper Jr
2016-04-26 22:36 ` Franklin S Cooper Jr
2016-04-28 21:07 ` Rob Herring
2016-04-28 21:07 ` Rob Herring
2016-04-28 21:11 ` Franklin S Cooper Jr.
2016-04-28 21:11 ` Franklin S Cooper Jr.
2016-04-28 21:11 ` Franklin S Cooper Jr.
2016-04-28 21:55 ` Rob Herring
2016-04-28 21:55 ` Rob Herring
2016-04-26 22:36 ` [PATCH v7 3/9] pwm: pwm-tiehrpwm: Update dt binding document to use generic node name Franklin S Cooper Jr
2016-04-26 22:36 ` Franklin S Cooper Jr
2016-04-26 22:36 ` Franklin S Cooper Jr
2016-04-26 22:36 ` [PATCH v7 4/9] pwm: pwm-tiecap: Update dt binding document to use proper unit address Franklin S Cooper Jr
2016-04-26 22:36 ` Franklin S Cooper Jr
2016-04-28 21:31 ` Rob Herring
2016-04-28 21:31 ` Rob Herring
2016-04-28 21:41 ` Franklin S Cooper Jr.
2016-04-28 21:41 ` Franklin S Cooper Jr.
2016-04-28 21:41 ` Franklin S Cooper Jr.
2016-04-26 22:36 ` [PATCH v7 5/9] ARM: dts: am437x/am33xx/da850: Add new ECAP and EPWM bindings Franklin S Cooper Jr
2016-04-26 22:36 ` Franklin S Cooper Jr
2016-04-28 21:35 ` Rob Herring
2016-04-28 21:35 ` Rob Herring
2016-04-26 22:36 ` [PATCH v7 6/9] pwms: pwm-ti*: Get the clock from the PWMSS parent when using old bindings Franklin S Cooper Jr
2016-04-26 22:36 ` Franklin S Cooper Jr
2016-04-26 22:36 ` [PATCH v7 7/9] ARM: dts: am437x/am33xx: Remove hwmod entries for ECAP and EPWM nodes Franklin S Cooper Jr
2016-04-26 22:36 ` Franklin S Cooper Jr
2016-04-26 22:36 ` [PATCH v7 8/9] ARM: AM335x/AM437x: hwmod: Remove eQEP, ePWM and eCAP hwmod entries Franklin S Cooper Jr
2016-04-26 22:36 ` Franklin S Cooper Jr
2016-04-26 22:36 ` [PATCH v7 9/9] ARM: dts: DRA7: Add dt nodes for PWMSS Franklin S Cooper Jr
2016-04-26 22:36 ` Franklin S Cooper Jr
2016-04-27 19:32 ` [PATCH v7 0/9] " Tony Lindgren
2016-04-27 19:32 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5720B51E.6050106@ti.com \
--to=t-kristo@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=fcooper@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=paul@pwsan.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.