From: Jose Abreu <Jose.Abreu@synopsys.com>
To: alsa-devel@alsa-project.org, broonie@kernel.org
Cc: Rob Herring <robh@kernel.org>,
Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
devicetree@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2 v6] ASoC: dwc: Update DOCUMENTATION for I2S Driver
Date: Wed, 27 Apr 2016 18:32:42 +0100 [thread overview]
Message-ID: <5720F7BA.9030500@synopsys.com> (raw)
In-Reply-To: <30ee79f0744cdf3561d43654f1ecf3d486bf7a08.1461749984.git.joabreu@synopsys.com>
Hi Mark,
Sorry. Follows bellow.
On 27-04-2016 11:05, Jose Abreu wrote:
> This patch updates documentation for the Designware I2S
> driver.
>
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Carlos Palminha <palminha@synopsys.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-snps-arc@lists.infradead.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-kernel@vger.kernel.org
> ---
>
> No changes v5 -> v6.
>
> Changes v4 -> v5:
> * interrupts is now required property
> * Drop 'snps-use-dmaengine' property
>
> This patch was only introduced in v4.
>
> Documentation/devicetree/bindings/sound/designware-i2s.txt | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/designware-i2s.txt b/Documentation/devicetree/bindings/sound/designware-i2s.txt
> index 7bb5424..27a728f 100644
> --- a/Documentation/devicetree/bindings/sound/designware-i2s.txt
> +++ b/Documentation/devicetree/bindings/sound/designware-i2s.txt
> @@ -3,14 +3,18 @@ DesignWare I2S controller
> Required properties:
> - compatible : Must be "snps,designware-i2s"
> - reg : Must contain the I2S core's registers location and length
> + - interrupts: <IRQ> where IRQ is the interrupt number.
> - clocks : Pairs of phandle and specifier referencing the controller's
> clocks. The controller expects one clock: the clock used as the sampling
> rate reference clock sample.
> - clock-names : "i2sclk" for the sample rate reference clock.
> +
> +Optional properties:
> - dmas: Pairs of phandle and specifier for the DMA channels that are used by
> the core. The core expects one or two dma channels: one for transmit and
> - one for receive.
> - - dma-names : "tx" for the transmit channel, "rx" for the receive channel.
> + one for receive. Set this parameter if the I2S DMA block is enabled.
> + - dma-names : "tx" for the transmit channel, "rx" for the receive channel. Set
> + this parameter if the I2S DMA block is enabled.
>
> For more details on the 'dma', 'dma-names', 'clock' and 'clock-names'
> properties please check:
> @@ -23,6 +27,7 @@ Example:
> soc_i2s: i2s@7ff90000 {
> compatible = "snps,designware-i2s";
> reg = <0x0 0x7ff90000 0x0 0x1000>;
> + interrupts = <15>;
> clocks = <&scpi_i2sclk 0>;
> clock-names = "i2sclk";
> #sound-dai-cells = <0>;
WARNING: multiple messages have this Message-ID (diff)
From: Jose.Abreu@synopsys.com (Jose Abreu)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 2/2 v6] ASoC: dwc: Update DOCUMENTATION for I2S Driver
Date: Wed, 27 Apr 2016 18:32:42 +0100 [thread overview]
Message-ID: <5720F7BA.9030500@synopsys.com> (raw)
In-Reply-To: <30ee79f0744cdf3561d43654f1ecf3d486bf7a08.1461749984.git.joabreu@synopsys.com>
Hi Mark,
Sorry. Follows bellow.
On 27-04-2016 11:05, Jose Abreu wrote:
> This patch updates documentation for the Designware I2S
> driver.
>
> Signed-off-by: Jose Abreu <joabreu at synopsys.com>
> Acked-by: Rob Herring <robh at kernel.org>
> Cc: Rob Herring <robh at kernel.org>
> Cc: Carlos Palminha <palminha at synopsys.com>
> Cc: Alexey Brodkin <abrodkin at synopsys.com>
> Cc: devicetree at vger.kernel.org
> Cc: linux-snps-arc at lists.infradead.org
> Cc: alsa-devel at alsa-project.org
> Cc: linux-kernel at vger.kernel.org
> ---
>
> No changes v5 -> v6.
>
> Changes v4 -> v5:
> * interrupts is now required property
> * Drop 'snps-use-dmaengine' property
>
> This patch was only introduced in v4.
>
> Documentation/devicetree/bindings/sound/designware-i2s.txt | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/designware-i2s.txt b/Documentation/devicetree/bindings/sound/designware-i2s.txt
> index 7bb5424..27a728f 100644
> --- a/Documentation/devicetree/bindings/sound/designware-i2s.txt
> +++ b/Documentation/devicetree/bindings/sound/designware-i2s.txt
> @@ -3,14 +3,18 @@ DesignWare I2S controller
> Required properties:
> - compatible : Must be "snps,designware-i2s"
> - reg : Must contain the I2S core's registers location and length
> + - interrupts: <IRQ> where IRQ is the interrupt number.
> - clocks : Pairs of phandle and specifier referencing the controller's
> clocks. The controller expects one clock: the clock used as the sampling
> rate reference clock sample.
> - clock-names : "i2sclk" for the sample rate reference clock.
> +
> +Optional properties:
> - dmas: Pairs of phandle and specifier for the DMA channels that are used by
> the core. The core expects one or two dma channels: one for transmit and
> - one for receive.
> - - dma-names : "tx" for the transmit channel, "rx" for the receive channel.
> + one for receive. Set this parameter if the I2S DMA block is enabled.
> + - dma-names : "tx" for the transmit channel, "rx" for the receive channel. Set
> + this parameter if the I2S DMA block is enabled.
>
> For more details on the 'dma', 'dma-names', 'clock' and 'clock-names'
> properties please check:
> @@ -23,6 +27,7 @@ Example:
> soc_i2s: i2s at 7ff90000 {
> compatible = "snps,designware-i2s";
> reg = <0x0 0x7ff90000 0x0 0x1000>;
> + interrupts = <15>;
> clocks = <&scpi_i2sclk 0>;
> clock-names = "i2sclk";
> #sound-dai-cells = <0>;
WARNING: multiple messages have this Message-ID (diff)
From: Jose Abreu <Jose.Abreu@synopsys.com>
To: <alsa-devel@alsa-project.org>, <broonie@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
<devicetree@vger.kernel.org>,
<linux-snps-arc@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2 v6] ASoC: dwc: Update DOCUMENTATION for I2S Driver
Date: Wed, 27 Apr 2016 18:32:42 +0100 [thread overview]
Message-ID: <5720F7BA.9030500@synopsys.com> (raw)
In-Reply-To: <30ee79f0744cdf3561d43654f1ecf3d486bf7a08.1461749984.git.joabreu@synopsys.com>
Hi Mark,
Sorry. Follows bellow.
On 27-04-2016 11:05, Jose Abreu wrote:
> This patch updates documentation for the Designware I2S
> driver.
>
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Carlos Palminha <palminha@synopsys.com>
> Cc: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: devicetree@vger.kernel.org
> Cc: linux-snps-arc@lists.infradead.org
> Cc: alsa-devel@alsa-project.org
> Cc: linux-kernel@vger.kernel.org
> ---
>
> No changes v5 -> v6.
>
> Changes v4 -> v5:
> * interrupts is now required property
> * Drop 'snps-use-dmaengine' property
>
> This patch was only introduced in v4.
>
> Documentation/devicetree/bindings/sound/designware-i2s.txt | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/designware-i2s.txt b/Documentation/devicetree/bindings/sound/designware-i2s.txt
> index 7bb5424..27a728f 100644
> --- a/Documentation/devicetree/bindings/sound/designware-i2s.txt
> +++ b/Documentation/devicetree/bindings/sound/designware-i2s.txt
> @@ -3,14 +3,18 @@ DesignWare I2S controller
> Required properties:
> - compatible : Must be "snps,designware-i2s"
> - reg : Must contain the I2S core's registers location and length
> + - interrupts: <IRQ> where IRQ is the interrupt number.
> - clocks : Pairs of phandle and specifier referencing the controller's
> clocks. The controller expects one clock: the clock used as the sampling
> rate reference clock sample.
> - clock-names : "i2sclk" for the sample rate reference clock.
> +
> +Optional properties:
> - dmas: Pairs of phandle and specifier for the DMA channels that are used by
> the core. The core expects one or two dma channels: one for transmit and
> - one for receive.
> - - dma-names : "tx" for the transmit channel, "rx" for the receive channel.
> + one for receive. Set this parameter if the I2S DMA block is enabled.
> + - dma-names : "tx" for the transmit channel, "rx" for the receive channel. Set
> + this parameter if the I2S DMA block is enabled.
>
> For more details on the 'dma', 'dma-names', 'clock' and 'clock-names'
> properties please check:
> @@ -23,6 +27,7 @@ Example:
> soc_i2s: i2s@7ff90000 {
> compatible = "snps,designware-i2s";
> reg = <0x0 0x7ff90000 0x0 0x1000>;
> + interrupts = <15>;
> clocks = <&scpi_i2sclk 0>;
> clock-names = "i2sclk";
> #sound-dai-cells = <0>;
next prev parent reply other threads:[~2016-04-27 17:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 10:05 [PATCH 0/2 v6] Add I2S audio support for ARC AXS10x boards Jose Abreu
2016-04-27 10:05 ` Jose Abreu
2016-04-27 10:05 ` Jose Abreu
2016-04-27 10:05 ` [PATCH 1/2 v6] ASoC: dwc: Add custom PCM driver Jose Abreu
2016-04-27 10:05 ` Jose Abreu
2016-04-27 10:05 ` Jose Abreu
2016-04-29 9:02 ` Jose Abreu
2016-04-29 9:02 ` Jose Abreu
2016-04-29 9:02 ` Jose Abreu
2016-04-29 10:42 ` Mark Brown
2016-04-29 10:42 ` Mark Brown
2016-04-29 10:42 ` Mark Brown
2016-05-04 17:35 ` Mark Brown
2016-05-04 17:35 ` Mark Brown
[not found] ` <cover.1461749984.git.joabreu-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2016-04-27 10:05 ` [PATCH 2/2 v6] ASoC: dwc: Update DOCUMENTATION for I2S Driver Jose Abreu
2016-04-27 10:05 ` Jose Abreu
2016-04-27 10:05 ` Jose Abreu
2016-04-27 17:32 ` Jose Abreu [this message]
2016-04-27 17:32 ` Jose Abreu
2016-04-27 17:32 ` Jose Abreu
[not found] ` <5720F7BA.9030500-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2016-04-27 17:35 ` Mark Brown
2016-04-27 17:35 ` Mark Brown
2016-04-27 17:35 ` Mark Brown
[not found] ` <30ee79f0744cdf3561d43654f1ecf3d486bf7a08.1461749984.git.joabreu-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2016-05-04 16:56 ` Mark Brown
2016-05-04 16:56 ` Mark Brown
2016-05-04 16:56 ` Mark Brown
2016-04-27 16:54 ` [PATCH 0/2 v6] Add I2S audio support for ARC AXS10x boards Mark Brown
2016-04-27 16:54 ` Mark Brown
2016-04-27 16:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5720F7BA.9030500@synopsys.com \
--to=jose.abreu@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.