[PATCH 2/2] sparc: Implement and wire up vio_hotplug for vio.

[PATCH 2/2] sparc: Implement and wire up vio_hotplug for vio.

[John Paul Adrian Glaubitz]

Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
---
 arch/sparc/kernel/vio.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/sparc/kernel/vio.c b/arch/sparc/kernel/vio.c
index d705560..f6bb857 100644
--- a/arch/sparc/kernel/vio.c
+++ b/arch/sparc/kernel/vio.c
@@ -45,6 +45,14 @@ static const struct vio_device_id *vio_match_device(
 	return NULL;
 }
 
+static int vio_hotplug(struct device *dev, struct kobj_uevent_env *env)
+{
+	const struct vio_dev *vio_dev = to_vio_dev(dev);
+
+	add_uevent_var(env, "MODALIAS=vio:T%sS%s", vio_dev->type, vio_dev->compat);
+	return 0;
+}
+
 static int vio_bus_match(struct device *dev, struct device_driver *drv)
 {
 	struct vio_dev *vio_dev = to_vio_dev(dev);
@@ -123,6 +131,7 @@ static struct device_attribute vio_dev_attrs[] = {
 static struct bus_type vio_bus_type = {
 	.name		= "vio",
 	.dev_attrs	= vio_dev_attrs,
+	.uevent         = vio_hotplug,
 	.match		= vio_bus_match,
 	.probe		= vio_device_probe,
 	.remove		= vio_device_remove,
-- 
2.8.0.rc3

Re: [PATCH 2/2] sparc: Implement and wire up vio_hotplug for vio.

[Sam Ravnborg]

On Thu, Apr 14, 2016 at 08:14:42PM +0200, John Paul Adrian Glaubitz wrote:
> Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>

Re: [PATCH 2/2] sparc: Implement and wire up vio_hotplug for vio.

[David Miller]

From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Date: Thu, 14 Apr 2016 20:14:42 +0200

> Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>

Applied.

Re: [PATCH 2/2] sparc: Implement and wire up vio_hotplug for vio.

[John Paul Adrian Glaubitz]

On 04/27/2016 10:39 PM, David Miller wrote:
> From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Date: Thu, 14 Apr 2016 20:14:42 +0200
> 
>> Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> 
> Applied.

Thanks!

However, I normally use my full name for all open source development,
e.g. with all three first names. Do you think you could change that
with git-rebase && git commit --amend --author?

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Re: [PATCH 2/2] sparc: Implement and wire up vio_hotplug for vio.

[David Miller]

From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Date: Wed, 27 Apr 2016 23:05:01 +0200

> On 04/27/2016 10:39 PM, David Miller wrote:
>> From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
>> Date: Thu, 14 Apr 2016 20:14:42 +0200
>> 
>>> Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
>> 
>> Applied.
> 
> Thanks!
> 
> However, I normally use my full name for all open source development,
> e.g. with all three first names. Do you think you could change that
> with git-rebase && git commit --amend --author?

My tree may never be rebased, as people clone and do work against it,
therefore any commit made there is permanent.

Please just be careful with patches you submit in the future, thanks.

Sorry.

Re: [PATCH 2/2] sparc: Implement and wire up vio_hotplug for vio.

[Julian Calaby]

Hi All,

On Thu, Apr 28, 2016 at 12:00 PM, David Miller <davem@davemloft.net> wrote:
> From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Date: Wed, 27 Apr 2016 23:05:01 +0200
>
>> On 04/27/2016 10:39 PM, David Miller wrote:
>>> From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
>>> Date: Thu, 14 Apr 2016 20:14:42 +0200
>>>
>>>> Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
>>>
>>> Applied.
>>
>> Thanks!
>>
>> However, I normally use my full name for all open source development,
>> e.g. with all three first names. Do you think you could change that
>> with git-rebase && git commit --amend --author?
>
> My tree may never be rebased, as people clone and do work against it,
> therefore any commit made there is permanent.
>
> Please just be careful with patches you submit in the future, thanks.

What's odd is that the name in the From: line of the original email is correct.

David, do you use patchwork? If so, it might be that John Paul
Adrian's name is incorrect in there. (This has caused Kalle some
issues in the past)

If so, one of you needs to fix this for any future submissions.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 2/2] sparc: Implement and wire up vio_hotplug for vio.

[David Miller]

From: Julian Calaby <julian.calaby@gmail.com>
Date: Thu, 28 Apr 2016 12:07:29 +1000

> David, do you use patchwork?

For everything, I use patchwork.

Re: [PATCH 2/2] sparc: Implement and wire up vio_hotplug for vio.

[Julian Calaby]

Hi David,

On Thu, Apr 28, 2016 at 12:10 PM, David Miller <davem@davemloft.net> wrote:
> From: Julian Calaby <julian.calaby@gmail.com>
> Date: Thu, 28 Apr 2016 12:07:29 +1000
>
>> David, do you use patchwork?
>
> For everything, I use patchwork.
>

I thought so, but it doesn't hurt to check.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 2/2] sparc: Implement and wire up vio_hotplug for vio.

[John Paul Adrian Glaubitz]

On Wed, Apr 27, 2016 at 10:00:32PM -0400, David Miller wrote:
> My tree may never be rebased, as people clone and do work against it,
> therefore any commit made there is permanent.
> 
> Please just be careful with patches you submit in the future, thanks.

Well, my patches are

      Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>

so, I think did everything correctly on my side. I don't exactly know
my name was cut off, but I guess it's too late now -.-.

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Re: [PATCH 2/2] sparc: Implement and wire up vio_hotplug for vio.

[John Paul Adrian Glaubitz]

Hi!

On 04/28/2016 11:13 AM, John Paul Adrian Glaubitz wrote:
> On Wed, Apr 27, 2016 at 10:00:32PM -0400, David Miller wrote:
>> My tree may never be rebased, as people clone and do work against it,
>> therefore any commit made there is permanent.
>>
>> Please just be careful with patches you submit in the future, thanks.
> 
> Well, my patches are
> 
>       Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> 
> so, I think did everything correctly on my side. I don't exactly know
> my name was cut off, but I guess it's too late now -.-.

I was just wondering: Would it be possible to ask Linus to fix my name
when he pulls in the changes from the sparc tree? From what I can see,
the current changes are not in Linus' tree yet, so there might be a
chance to fix the problem.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Re: [PATCH 2/2] sparc: Implement and wire up vio_hotplug for vio.

[David Miller]

From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Date: Mon, 2 May 2016 01:13:19 +0200

> Hi!
> 
> On 04/28/2016 11:13 AM, John Paul Adrian Glaubitz wrote:
>> On Wed, Apr 27, 2016 at 10:00:32PM -0400, David Miller wrote:
>>> My tree may never be rebased, as people clone and do work against it,
>>> therefore any commit made there is permanent.
>>>
>>> Please just be careful with patches you submit in the future, thanks.
>> 
>> Well, my patches are
>> 
>>       Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
>> 
>> so, I think did everything correctly on my side. I don't exactly know
>> my name was cut off, but I guess it's too late now -.-.
> 
> I was just wondering: Would it be possible to ask Linus to fix my name
> when he pulls in the changes from the sparc tree? From what I can see,
> the current changes are not in Linus' tree yet, so there might be a
> chance to fix the problem.

Doesn't work like that, the commit message is part of the SHA1 ID hash
and that cannot change.