From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i2c: designware_i2c: Optionally check enable status register
Date: Thu, 28 Apr 2016 08:06:49 +0200 [thread overview]
Message-ID: <5721A879.2070704@denx.de> (raw)
In-Reply-To: <1461740532-27074-1-git-send-email-sr@denx.de>
Hello Stefan,
Am 27.04.2016 um 09:02 schrieb Stefan Roese:
> Some platforms don't implement the enable status register at offset 0x9c.
> The SPEAr600 platform is one of them. The recently added check to this
> status register can't be performend on these platforms.
>
> This patch introduces a new config option that can be enabled on such
> platforms not supporting this register.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Heiko Schocher <hs@denx.de>
> ---
> drivers/i2c/designware_i2c.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
No objections, but I miss an entry in drivers/i2c/Kconfig or at least an
entry in README. Please add this, thanks!
bye,
Heiko
>
> diff --git a/drivers/i2c/designware_i2c.c b/drivers/i2c/designware_i2c.c
> index 0c7cd0b..e60fd0a 100644
> --- a/drivers/i2c/designware_i2c.c
> +++ b/drivers/i2c/designware_i2c.c
> @@ -36,6 +36,14 @@ struct dw_i2c {
> struct dw_scl_sda_cfg *scl_sda_cfg;
> };
>
> +#ifdef CONFIG_SYS_I2C_DW_ENABLE_STATUS_UNSUPPORTED
> +static void dw_i2c_enable(struct i2c_regs *i2c_base, bool enable)
> +{
> + u32 ena = enable ? IC_ENABLE_0B : 0;
> +
> + writel(ena, &i2c_base->ic_enable);
> +}
> +#else
> static void dw_i2c_enable(struct i2c_regs *i2c_base, bool enable)
> {
> u32 ena = enable ? IC_ENABLE_0B : 0;
> @@ -56,6 +64,7 @@ static void dw_i2c_enable(struct i2c_regs *i2c_base, bool enable)
>
> printf("timeout in %sabling I2C adapter\n", enable ? "en" : "dis");
> }
> +#endif
>
> /*
> * i2c_set_bus_speed - Set the i2c speed
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2016-04-28 6:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 7:02 [U-Boot] [PATCH] i2c: designware_i2c: Optionally check enable status register Stefan Roese
2016-04-28 6:06 ` Heiko Schocher [this message]
2016-04-28 6:10 ` Stefan Roese
2016-04-28 6:22 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5721A879.2070704@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.